Re: [PR] Bump jakarta.enterprise:jakarta.enterprise.cdi-api from 4.0.1 to 4.1.0 [cxf]

2024-04-19 Thread via GitHub
dependabot[bot] commented on PR #1816: URL: https://github.com/apache/cxf/pull/1816#issuecomment-2066966329 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me

Re: [PR] Add check to prevent redundant values in headers when using GZIPOutInterceptor [cxf]

2024-04-19 Thread via GitHub
reta commented on code in PR #1819: URL: https://github.com/apache/cxf/pull/1819#discussion_r1572837369 ## core/src/main/java/org/apache/cxf/transport/common/gzip/GZIPOutInterceptor.java: ## @@ -337,7 +337,10 @@ private static void addHeader(Message message, String name,

Re: [PR] [CXF-9004]Jetty12 : always use pre-saved HTTP_REQUEST from InMessage … [cxf]

2024-04-19 Thread via GitHub
ffang merged PR #1823: URL: https://github.com/apache/cxf/pull/1823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For

Re: [PR] Exception for getUserPrincipal() in AbstractHTTPDestination is slurped since CXF 4.1.x [cxf]

2024-04-19 Thread via GitHub
ffang commented on code in PR #1822: URL: https://github.com/apache/cxf/pull/1822#discussion_r1572923309 ## rt/transports/http/src/main/java/org/apache/cxf/transport/http/AbstractHTTPDestination.java: ## @@ -410,8 +410,12 @@ private boolean

Re: [PR] Bump jakarta.enterprise:jakarta.enterprise.cdi-api from 4.0.1 to 4.1.0 [cxf]

2024-04-19 Thread via GitHub
reta closed pull request #1816: Bump jakarta.enterprise:jakarta.enterprise.cdi-api from 4.0.1 to 4.1.0 URL: https://github.com/apache/cxf/pull/1816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Exception for getUserPrincipal() in AbstractHTTPDestination is slurped since CXF 4.1.x [cxf]

2024-04-19 Thread via GitHub
ffang commented on code in PR #1822: URL: https://github.com/apache/cxf/pull/1822#discussion_r1572882731 ## rt/transports/http/src/main/java/org/apache/cxf/transport/http/AbstractHTTPDestination.java: ## @@ -410,8 +410,12 @@ private boolean

Re: [PR] Exception for getUserPrincipal() in AbstractHTTPDestination is slurped since CXF 4.1.x [cxf]

2024-04-19 Thread via GitHub
rzo1 closed pull request #1822: Exception for getUserPrincipal() in AbstractHTTPDestination is slurped since CXF 4.1.x URL: https://github.com/apache/cxf/pull/1822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Exception for getUserPrincipal() in AbstractHTTPDestination is slurped since CXF 4.1.x [cxf]

2024-04-19 Thread via GitHub
rzo1 commented on code in PR #1822: URL: https://github.com/apache/cxf/pull/1822#discussion_r1572898811 ## rt/transports/http/src/main/java/org/apache/cxf/transport/http/AbstractHTTPDestination.java: ## @@ -410,8 +410,12 @@ private boolean

Re: [PR] [CXF-9004]Jetty12 : always use pre-saved HTTP_REQUEST from InMessage … [cxf]

2024-04-19 Thread via GitHub
ffang commented on PR #1823: URL: https://github.com/apache/cxf/pull/1823#issuecomment-2067229753 Thanks @reta ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Exception for getUserPrincipal() in AbstractHTTPDestination is slurped since CXF 4.1.x [cxf]

2024-04-19 Thread via GitHub
rzo1 opened a new pull request, #1822: URL: https://github.com/apache/cxf/pull/1822 Hi all, I am currently checking the integration of CXF 4.1.0-SNAPSHOT into TomEE 10 and I noticed a change in `AbstractHTTPDestination`. An additional `try-catch` was added around

Re: [PR] Exception for getUserPrincipal() in AbstractHTTPDestination is slurped since CXF 4.1.x [cxf]

2024-04-19 Thread via GitHub
ffang commented on PR #1822: URL: https://github.com/apache/cxf/pull/1822#issuecomment-2066538612 Hi @rzo1 , Yes, this change is caused by Jetty12 upgrade. And it's good that we just catch NPE from jetty other than more generic exceptions. Thanks for reporting and fixing this!

Re: [PR] Exception for getUserPrincipal() in AbstractHTTPDestination is slurped since CXF 4.1.x [cxf]

2024-04-19 Thread via GitHub
reta commented on code in PR #1822: URL: https://github.com/apache/cxf/pull/1822#discussion_r1572368151 ## rt/transports/http/src/main/java/org/apache/cxf/transport/http/AbstractHTTPDestination.java: ## @@ -410,8 +410,12 @@ private boolean

Re: [PR] CXF-8951: Concurrent WebClient usage causes massive thread overhead [cxf]

2024-04-19 Thread via GitHub
reta commented on PR #1777: URL: https://github.com/apache/cxf/pull/1777#issuecomment-2066394896 Thanks a lot @jimma ! > For the httpclient executor, should it set to some shared new fixed size thread pool like cpu processor count *2 by default > instead of using JDK's

Re: [PR] Bump com.googlecode.maven-download-plugin:download-maven-plugin from 1.8.1 to 1.9.0 [cxf]

2024-04-19 Thread via GitHub
reta merged PR #1821: URL: https://github.com/apache/cxf/pull/1821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For

Re: [PR] Bump org.testng:testng from 7.10.0 to 7.10.1 [cxf]

2024-04-19 Thread via GitHub
reta merged PR #1820: URL: https://github.com/apache/cxf/pull/1820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For

Re: [PR] Exception for getUserPrincipal() in AbstractHTTPDestination is slurped since CXF 4.1.x [cxf]

2024-04-19 Thread via GitHub
rzo1 commented on PR #1822: URL: https://github.com/apache/cxf/pull/1822#issuecomment-2066319454 Ok from what I can read in the commit history, it seems, it was introduced because of jetty 12? The underlying exception (reason for failing GH actions) is a NPE in Jetty: ```

Re: [PR] Exception for getUserPrincipal() in AbstractHTTPDestination is slurped since CXF 4.1.x [cxf]

2024-04-19 Thread via GitHub
rzo1 commented on code in PR #1822: URL: https://github.com/apache/cxf/pull/1822#discussion_r1572491679 ## rt/transports/http/src/main/java/org/apache/cxf/transport/http/AbstractHTTPDestination.java: ## @@ -410,8 +410,12 @@ private boolean

Re: [PR] CXF-8951: Concurrent WebClient usage causes massive thread overhead [cxf]

2024-04-19 Thread via GitHub
reta merged PR #1777: URL: https://github.com/apache/cxf/pull/1777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For

Re: [PR] Exception for getUserPrincipal() in AbstractHTTPDestination is slurped since CXF 4.1.x [cxf]

2024-04-19 Thread via GitHub
ffang commented on code in PR #1822: URL: https://github.com/apache/cxf/pull/1822#discussion_r1572581658 ## rt/transports/http/src/main/java/org/apache/cxf/transport/http/AbstractHTTPDestination.java: ## @@ -410,8 +410,12 @@ private boolean