Re: [VOTE] FLIP-239: Port JDBC Connector to FLIP-27-143

2023-10-11 Thread Jing Ge
+1(binding) Thanks! Best regards, Jing On Wed, Oct 11, 2023 at 9:34 AM Yuepeng Pan wrote: > +1(non-binding) > Thanks for your driving the voting thread. > > Best Regards. > Yuepeng Pan > > On 2023/10/06 16:33:40 Joao Boto wrote: > > Hi all, Thank you to everyone for the feedback on

[jira] [Created] (FLINK-33249) comment should be parsed by StringLiteral() instead of SqlCharStringLiteral to avoid parsing failure

2023-10-11 Thread xiaogang zhou (Jira)
xiaogang zhou created FLINK-33249: - Summary: comment should be parsed by StringLiteral() instead of SqlCharStringLiteral to avoid parsing failure Key: FLINK-33249 URL:

Re: [DISCUSS] FLIP-370 : Support Balanced Tasks Scheduling

2023-10-11 Thread Yuepeng Pan
Hi, Shammon. Thanks for your feedback. >1. This mechanism will be only supported in `SlotPool` or both `SlotPool` and >`DeclarativeSlotPool`? As described on the FLIP page, the current design plans to introduce the waiting mechanism only in the `SlotPool`, because the existing

[jira] [Created] (FLINK-33248) Calling CURRENT_WATERMARK without parameters gives IndexOutOfBoundsException

2023-10-11 Thread Bonnie Varghese (Jira)
Bonnie Varghese created FLINK-33248: --- Summary: Calling CURRENT_WATERMARK without parameters gives IndexOutOfBoundsException Key: FLINK-33248 URL: https://issues.apache.org/jira/browse/FLINK-33248

Re: [VOTE] FLIP-371: Provide initialization context for Committer creation in TwoPhaseCommittingSink

2023-10-11 Thread Gyula Fóra
Thanks , Peter. +1 Gyula On Wed, 11 Oct 2023 at 14:47, Péter Váry wrote: > Hi all, > > Thank you to everyone for the feedback on FLIP-371[1]. > Based on the discussion thread [2], I think we are ready to take a vote to > contribute this to Flink. > I'd like to start a vote for it. > The vote

[jira] [Created] (FLINK-33247) IllegalArgumentException in NoticeFileChecker

2023-10-11 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33247: - Summary: IllegalArgumentException in NoticeFileChecker Key: FLINK-33247 URL: https://issues.apache.org/jira/browse/FLINK-33247 Project: Flink Issue Type:

Re: [VOTE] FLIP-367: Support Setting Parallelism for Table/SQL Sources

2023-10-11 Thread Jane Chan
+1 (non-binding) Best, Jane On Wed, Oct 11, 2023 at 5:13 PM Samrat Deb wrote: > +1 (non binding) > > On Wed, 11 Oct 2023 at 1:29 PM, Martijn Visser > wrote: > > > +1 (binding) > > > > On Wed, Oct 11, 2023 at 9:15 AM Sergey Nuyanzin > > wrote: > > > > > > +1 (binding) > > > > > > that's a

Re: Re: [DISCUSS] FLIP-373: Support Configuring Different State TTLs using SQL Hint

2023-10-11 Thread Jane Chan
Thank you all for the valuable feedback. There is a difference when users incorrectly use hints, and there are two possible scenarios: <1> STATE_TTL hint can be applied to the current query block but with an invalid key or value. In this case, the validation exception will be thrown. The

[jira] [Created] (FLINK-33246) Add RescalingIT case that uses checkpoints and resource requests

2023-10-11 Thread Stefan Richter (Jira)
Stefan Richter created FLINK-33246: -- Summary: Add RescalingIT case that uses checkpoints and resource requests Key: FLINK-33246 URL: https://issues.apache.org/jira/browse/FLINK-33246 Project: Flink

Re: [DISCUSSION] test connectors against Flink master in PRs

2023-10-11 Thread Etienne Chauchot
Hi, Cross-posting in that thread too: FYI, build issues for connectors related to architecture tests adding or removing violations is under fixing and tracked here (1) [1] https://issues.apache.org/jira/browse/FLINK-32563 Best Etienne Le 03/07/2023 à 10:05, Etienne Chauchot a écrit :

[jira] [Created] (FLINK-33245) finegrained_resource_management module failed

2023-10-11 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33245: - Summary: finegrained_resource_management module failed Key: FLINK-33245 URL: https://issues.apache.org/jira/browse/FLINK-33245 Project: Flink Issue Type:

Re: [ANNOUNCE] Release 1.18.0, release candidate #1

2023-10-11 Thread Etienne Chauchot
Hi all, FYI, build issues for connectors related to architecture tests adding or removing violations is under fixing and tracked here (1) Of course, it is indeed not a blocker as connectors development is decoupled from Flink development. [1]

[jira] [Created] (FLINK-33244) Not Able To Pass the Configuration On Flink Session

2023-10-11 Thread Amarjeet Singh (Jira)
Amarjeet Singh created FLINK-33244: -- Summary: Not Able To Pass the Configuration On Flink Session Key: FLINK-33244 URL: https://issues.apache.org/jira/browse/FLINK-33244 Project: Flink

[jira] [Created] (FLINK-33243) .scalafmt.conf cannot be found in Test packaging/licensing job

2023-10-11 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33243: - Summary: .scalafmt.conf cannot be found in Test packaging/licensing job Key: FLINK-33243 URL: https://issues.apache.org/jira/browse/FLINK-33243 Project: Flink

[jira] [Created] (FLINK-33242) flink-misc doesn't succeed due to the YARN tests

2023-10-11 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33242: - Summary: flink-misc doesn't succeed due to the YARN tests Key: FLINK-33242 URL: https://issues.apache.org/jira/browse/FLINK-33242 Project: Flink Issue

Re: Re: [DISCUSS] FLIP-373: Support Configuring Different State TTLs using SQL Hint

2023-10-11 Thread Yun Tang
I think showing the TTL for operators is a nice-to-have feature, not a must one in this FLIP. We can still get the information from the operator descriptions. And I think we can continue the TTL showing work based on FLINK-33230 [1]. Last but not least, I prefer to throw exceptions if the TTL

[VOTE] FLIP-371: Provide initialization context for Committer creation in TwoPhaseCommittingSink

2023-10-11 Thread Péter Váry
Hi all, Thank you to everyone for the feedback on FLIP-371[1]. Based on the discussion thread [2], I think we are ready to take a vote to contribute this to Flink. I'd like to start a vote for it. The vote will be open for at least 72 hours (excluding weekends, unless there is an objection or an

Re: Re: [DISCUSS] FLIP-373: Support Configuring Different State TTLs using SQL Hint

2023-10-11 Thread ConradJam
+1 TTL shows the state ttl for operators in Flink web ui can be know what operator state Zakelly Lan 于2023年10月11日周三 19:14写道: > Hi Jane, > > The fine-grained TTL management is extremely useful for performance > tuning, so +1 for the idea. I have a minor suggestion: would it be > possible to

[DISCUSS][FLINK-33240] Document deprecated options as well

2023-10-11 Thread Zhanghao Chen
Hi Flink users and developers, Currently, Flink won't generate doc for the deprecated options. This might confuse users when upgrading from an older version of Flink: they have to either carefully read the release notes or check the source code for upgrade guidance on deprecated options. I

[jira] [Created] (FLINK-33241) Align config option generation documentation for Flink's config documentation

2023-10-11 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33241: - Summary: Align config option generation documentation for Flink's config documentation Key: FLINK-33241 URL: https://issues.apache.org/jira/browse/FLINK-33241

[jira] [Created] (FLINK-33240) Generate docs for deprecated options as well

2023-10-11 Thread Zhanghao Chen (Jira)
Zhanghao Chen created FLINK-33240: - Summary: Generate docs for deprecated options as well Key: FLINK-33240 URL: https://issues.apache.org/jira/browse/FLINK-33240 Project: Flink Issue Type:

Re: Re: [DISCUSS] FLIP-373: Support Configuring Different State TTLs using SQL Hint

2023-10-11 Thread Zakelly Lan
Hi Jane, The fine-grained TTL management is extremely useful for performance tuning, so +1 for the idea. I have a minor suggestion: would it be possible to provide a simple hint that allows the omission of the key? For example, something like "SELECT /+ STATE_TTL('1h')/", which would specify the

[jira] [Created] (FLINK-33239) After enabling exactly-once in the Flink Kafka sink, the Kafka broker's memory keeps increasing, eventually causing the Kafka broker to crash.

2023-10-11 Thread Darcy Lin (Jira)
Darcy Lin created FLINK-33239: - Summary: After enabling exactly-once in the Flink Kafka sink, the Kafka broker's memory keeps increasing, eventually causing the Kafka broker to crash. Key: FLINK-33239 URL:

Re: [DISCUSS] FLIP-370 : Support Balanced Tasks Scheduling

2023-10-11 Thread xiangyu feng
Hi Yuepeng, Thanks for your feedback. I agree with u, both approaches can achieve the goal. As long as we can easily extend the balancing strategy to consider more than one factors without changing the interface, the solution is OK for me. Regards, Xiangyu Yuepeng Pan 于2023年10月11日周三 17:38写道:

[jira] [Created] (FLINK-33238) Upgrade org.apache.avro:avro to 1.11.3 to mitigate CVE-2023-39410

2023-10-11 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-33238: -- Summary: Upgrade org.apache.avro:avro to 1.11.3 to mitigate CVE-2023-39410 Key: FLINK-33238 URL: https://issues.apache.org/jira/browse/FLINK-33238 Project: Flink

Re: [DISCUSS] FLIP-370 : Support Balanced Tasks Scheduling

2023-10-11 Thread Yuepeng Pan
Hi, xiangyu. Thanks for your quick reply. >interface currently only includes a description of the number of tasks. So, >IIUC, If there is a need to further expand >current interface and its implementations, right? Yes, that's indeed the case. >I checked the interface design of LoadingWeight and

Re: [VOTE] FLIP-367: Support Setting Parallelism for Table/SQL Sources

2023-10-11 Thread Samrat Deb
+1 (non binding) On Wed, 11 Oct 2023 at 1:29 PM, Martijn Visser wrote: > +1 (binding) > > On Wed, Oct 11, 2023 at 9:15 AM Sergey Nuyanzin > wrote: > > > > +1 (binding) > > > > that's a nice improvement > > thanks for driving that > > > > On Wed, Oct 11, 2023 at 8:42 AM Lincoln Lee > wrote: >

Re: [DISCUSS] FLIP-370 : Support Balanced Tasks Scheduling

2023-10-11 Thread xiangyu feng
Hi Yuepeng, Thx for ur reply. > Nice feedback. In fact, as mentioned in the Google Doc, the LoadingWeight interface currently only includes a description of the number of tasks. So, IIUC, If there is a need to further expand > descriptions of other resource loads, we just extend it based on the

RE: FW: RE: [DISCUSS] FLIP-368 Reorganize the exceptions thrown in state interfaces

2023-10-11 Thread David Radley
Hi Zakelly, Thanks for making this clear for me. We should document the impact on the user in the release notes, which will be a minimal rewrite and recompile of any java using the old APIs. I think it is a good point you make about if there are future implementations that are worth retrying

[jira] [Created] (FLINK-33237) Optimize the data type of JobStatus#state from String to Enum

2023-10-11 Thread Rui Fan (Jira)
Rui Fan created FLINK-33237: --- Summary: Optimize the data type of JobStatus#state from String to Enum Key: FLINK-33237 URL: https://issues.apache.org/jira/browse/FLINK-33237 Project: Flink Issue

Re: [VOTE] FLIP-367: Support Setting Parallelism for Table/SQL Sources

2023-10-11 Thread Martijn Visser
+1 (binding) On Wed, Oct 11, 2023 at 9:15 AM Sergey Nuyanzin wrote: > > +1 (binding) > > that's a nice improvement > thanks for driving that > > On Wed, Oct 11, 2023 at 8:42 AM Lincoln Lee wrote: > > > +1 (binding) > > > > Best, > > Lincoln Lee > > > > > > Leonard Xu 于2023年10月10日周二 09:57写道: >

Re: [VOTE] FLIP-239: Port JDBC Connector to FLIP-27-143

2023-10-11 Thread Yuepeng Pan
+1(non-binding) Thanks for your driving the voting thread. Best Regards. Yuepeng Pan On 2023/10/06 16:33:40 Joao Boto wrote: > Hi all, Thank you to everyone for the feedback on FLIP-239[1]. Based on the > discussion thread [2] and some offline discussions, we have come to a > consensus on the

Re: [VOTE] FLIP-367: Support Setting Parallelism for Table/SQL Sources

2023-10-11 Thread Sergey Nuyanzin
+1 (binding) that's a nice improvement thanks for driving that On Wed, Oct 11, 2023 at 8:42 AM Lincoln Lee wrote: > +1 (binding) > > Best, > Lincoln Lee > > > Leonard Xu 于2023年10月10日周二 09:57写道: > > > +1(binding) > > > > Best, > > Leonard > > > > > On Oct 9, 2023, at 9:45 PM, Jing Ge > wrote:

Re:[VOTE] FLIP-374: Adding a separate configuration for specifying Java Options of the SQL Gateway

2023-10-11 Thread Yuepeng Pan
+1(non-binding). Best Regards, Yuepeng Pan. At 2023-10-11 10:07:38, "Yangze Guo" wrote: >Hi everyone, > >I'd like to start the vote of FLIP-374 [1]. This FLIP is discussed in >the thread [2]. > >The vote will be open for at least 72 hours. Unless there is an >objection, I'll try to close it by

Re: [VOTE] FLIP-374: Adding a separate configuration for specifying Java Options of the SQL Gateway

2023-10-11 Thread Samrat Deb
+1 (non binding ) On Wed, 11 Oct 2023 at 12:02 PM, Jing Ge wrote: > +1(binding) > > Best Regards, > Jing > > On Wed, Oct 11, 2023 at 5:36 AM Zakelly Lan wrote: > > > +1(non-binding) > > > > Thanks for driving this. > > > > Best, > > Zakelly > > > > On Wed, Oct 11, 2023 at 11:22 AM Weihua Hu >

Re: [VOTE] FLIP-367: Support Setting Parallelism for Table/SQL Sources

2023-10-11 Thread Lincoln Lee
+1 (binding) Best, Lincoln Lee Leonard Xu 于2023年10月10日周二 09:57写道: > +1(binding) > > Best, > Leonard > > > On Oct 9, 2023, at 9:45 PM, Jing Ge wrote: > > > > +1(binding) > > > > Best Regards, > > Jing > > > > On Mon, Oct 9, 2023 at 10:40 AM Ahmed Hamdy > wrote: > > > >> +1 (non-binding) > >>

Re: [VOTE] FLIP-374: Adding a separate configuration for specifying Java Options of the SQL Gateway

2023-10-11 Thread Jing Ge
+1(binding) Best Regards, Jing On Wed, Oct 11, 2023 at 5:36 AM Zakelly Lan wrote: > +1(non-binding) > > Thanks for driving this. > > Best, > Zakelly > > On Wed, Oct 11, 2023 at 11:22 AM Weihua Hu wrote: > > > > +1(binding) > > > > Best, > > Weihua > > > > > > On Wed, Oct 11, 2023 at 10:56 AM