[PATCH] Style police work on server/config.c

2002-03-05 Thread Sander Striker
Hi, Patch is attached to prevent line wrapping/munging. I encountered this: Line 396: return !!(cmd-limited (AP_METHOD_BIT methnum)); ^^ Is that a typo or intentional? Sander config.patch Description: Binary data

RE: [PATCH] Style police work on server/config.c

2002-03-05 Thread Sander Striker
From: Sander Striker [mailto:[EMAIL PROTECTED]] Sent: 05 March 2002 11:42 Hi, Patch is attached to prevent line wrapping/munging. I encountered this: Line 396: return !!(cmd-limited (AP_METHOD_BIT methnum)); ^^ Is that a typo or intentional? I also forgot to

[PATCH] server/connection.c detab

2002-03-05 Thread Sander Striker
Hi, More formatting/style/readability stuff. Patch attached yadda yadda yadda. Sander connection.patch Description: Binary data

[PATCH] server/error_bucket.c detab

2002-03-05 Thread Sander Striker
Hi, More detab. Patch attached Sander error_bucket.patch Description: Binary data

[PATCH] server/gen_test_char.c detab

2002-03-05 Thread Sander Striker
Hi, Yet more detab. Patch attached. Sander gen_test_char.patch Description: Binary data

[PATCH] server/listen.c detab

2002-03-05 Thread Sander Striker
Hi, More detab, etc. Can this go? Was there a future purpose to this call, or was it old code commented out? Line 320: /*free(lr);*/ Patch attached. Sander listen.patch Description: Binary data

Re: apr_file_open() and caching file descriptors

2002-03-05 Thread Bill Stoddard
At 05:29 PM 3/4/2002, you wrote: On Mon, 4 Mar 2002, Bill Stoddard wrote: Rather than an option to not register a cleanup, perhaps a function to kill the cleanup would be more generally useful. apr_file_kill_cleanups(apr_file_t *file); You still have a problem with the

[PATCH] server/log.c detab

2002-03-05 Thread Sander Striker
Hi, More detab, etc. Patch attached. Sander log.patch Description: Binary data

Re: Cannot build on LINUX PPC

2002-03-05 Thread Greg Ames
Christian Gross wrote: Now here is another question What do all of you use as a development tool? gcc, gdb, and vi Jeff keeps telling me I should learn emacs, but I'm a bass player and we're notoriously slow Greg

Re: Weird network problem with MPM_WORKER

2002-03-05 Thread Jeff Trawick
Pier Fumagalli [EMAIL PROTECTED] writes: Jeff Trawick [EMAIL PROTECTED] wrote: The Solaris fixes were required to fix a hang in getaddrinfo(). Yeah, looked at the archive and patched the whole baby before posting... Didn't change the behavior... When I had the same symptom as Pier

detab before or after bucket changes? Re: [PATCH]server/error_bucket.c detab

2002-03-05 Thread Brian Pane
Sander Striker wrote: Hi, More detab Patch attached Sander I have only one reservation about this series of detab patches: they'll break the one big pending change that I know of: Cliff's bucket free list diffs It might be easier to get the bucket free list changes applied first, and then

[dennis.lundberg@mdh.se: config/10040: Wrong file suffix for Swedish languge documents]

2002-03-05 Thread Aaron Bannert
This bug report has come up before. Anyone mind if I commit a change to 1.3 to fix this? -aaron - Forwarded message from Dennis Lundberg [EMAIL PROTECTED] - From: Dennis Lundberg [EMAIL PROTECTED] Subject: config/10040: Wrong file suffix for Swedish languge documents To: [EMAIL

PATCH - mod_mime.c to allow broken modules with missing filename

2002-03-05 Thread RCHAPACH Rochester
I tried posting this patch February 4, but it must have gotten lost in the shuffle of 2.0.32, so here it is again. We found this with Tomcat. In theme with the broken module being allowed to leave r-filename as NULL in ap_directory_walk() and ap_file_walk(), the find_ct() of mod_mime.c needs

Re: cvs commit: httpd-2.0/server core.c

2002-03-05 Thread Bill Stoddard
Greg, Please do not mix function change with code style changes. Bill gregames02/03/05 07:46:21 Modified:server core.c Log: fix Directory ~ blah containers. also, eradicate a few nefarious tabs which were found lurking in the vicinity. Submitted by: Rob

Re: the three filter types (was: cvs commit: httpd-2.0/servercore.c)

2002-03-05 Thread Jim Jagielski
At 5:53 PM -0800 3/4/02, Greg Stein wrote: CONTENT: Filters of this type are valid for the time that this content is used to satisfy a request. For simple requests, this is identical to PROTOCOL, but internal redirects and sub-requests can change

RE: [PATCH] server/core.c detab

2002-03-05 Thread Sander Striker
The mail with the attachement bounced because it was 100k. If anyone wants it, please holler. It wasn't all simple find-replace, so better not wait until conflicts arise ;) Sander -Original Message- From: Sander Striker [mailto:[EMAIL PROTECTED]] Sent: 05 March 2002 14:00 To:

Problems writing a module

2002-03-05 Thread Belen Leonardo Javier
Title: Problems writing a module I've got serious problems with the cmd struct. When I try to use it, if I have a struct to fill (in this case named solconf) , I get garbage even if I try to let fields empty. And If i use a linked list, I cannot make the one for the request destroy when the

Re: cvs commit: httpd-2.0/server/mpm/worker worker.c

2002-03-05 Thread Aaron Bannert
I disagree with this patch. If we are getting failures on locks then we have a bug somewhere and I'd rather not see us cover up the problem by decreasing the verbosity. -aaron On Tue, Mar 05, 2002 at 09:18:07PM -, [EMAIL PROTECTED] wrote: trawick 02/03/05 13:18:07 Modified:

Re: cvs commit: httpd-2.0 STATUS

2002-03-05 Thread Aaron Bannert
On Tue, Mar 05, 2002 at 09:23:30PM -, [EMAIL PROTECTED] wrote: trawick 02/03/05 13:23:30 Modified:.STATUS Log: axe the entry on graceful restart problems with worker I was too stupid to read the code to determine that the accept mutex failure log messages

Re: cvs commit: httpd-2.0/server/mpm/worker worker.c

2002-03-05 Thread Jeff Trawick
Aaron Bannert [EMAIL PROTECTED] writes: I disagree with this patch. If we are getting failures on locks then we have a bug somewhere and I'd rather not see us cover up the problem by decreasing the verbosity. Here is the sequence of events: 1) a thread in child process A is waiting on

Re: cvs commit: httpd-2.0/server/mpm/worker worker.c

2002-03-05 Thread Aaron Bannert
On Tue, Mar 05, 2002 at 04:53:23PM -0500, Jeff Trawick wrote: Here is the sequence of events: 1) a thread in child process A is waiting on semaphore 2) graceful restart triggered 3) parent process cleans up the semaphore 4) that thread in child process A gets a failure (EIDRM) from the

Re: cvs commit: httpd-2.0 STATUS

2002-03-05 Thread Jeff Trawick
Aaron Bannert [EMAIL PROTECTED] writes: On Tue, Mar 05, 2002 at 09:23:30PM -, [EMAIL PROTECTED] wrote: trawick 02/03/05 13:23:30 Modified:.STATUS Log: axe the entry on graceful restart problems with worker I was too stupid to read the code to

Re: cvs commit: httpd-2.0/server/mpm/worker worker.c

2002-03-05 Thread Jeff Trawick
Aaron Bannert [EMAIL PROTECTED] writes: On Tue, Mar 05, 2002 at 04:53:23PM -0500, Jeff Trawick wrote: Here is the sequence of events: 1) a thread in child process A is waiting on semaphore 2) graceful restart triggered 3) parent process cleans up the semaphore 4) that thread in

Re: cvs commit: httpd-2.0/server/mpm/worker worker.c

2002-03-05 Thread Aaron Bannert
On Tue, Mar 05, 2002 at 05:07:38PM -0500, Jeff Trawick wrote: Aaron Bannert [EMAIL PROTECTED] writes: On Tue, Mar 05, 2002 at 04:53:23PM -0500, Jeff Trawick wrote: Here is the sequence of events: 1) a thread in child process A is waiting on semaphore 2) graceful restart

Re: apr_file_open() and caching file descriptors

2002-03-05 Thread Bill Stoddard
Haven't had much time to think about this today, but I did discover that the XTHREAD support in win32 apr_file io is seriously broken. apr_file_open(APR_XTHREAD) on Windows should -not- be creating the overlapped structure and the io completion event. If an open file is being shared across

Re: AddOutputFilterByType

2002-03-05 Thread Justin Erenkrantz
On Tue, Mar 05, 2002 at 07:04:43AM -0800, Ryan Bloom wrote: Why is this thing being run in the fixups phase? The whole point of the insert_filters phase is to insert filters for the given resource Why are we trying to insert resource based filters in the fixups? Especially given that the

Re: AddOutputFilterByType

2002-03-05 Thread William A. Rowe, Jr.
At 04:29 PM 3/5/2002, you wrote: Also, why does mod_negotiation handle fixups in type_checker and mod_dir does it in fixups? I'd suggest that we should move the handle_multi call to be a fixups so that we are consistent where our redirect calls occur -- justin Cut it out already :-) We don't

Re: apr_file_open() and caching file descriptors

2002-03-05 Thread Bill Stoddard
Will submit a patch later on this evening... Bill - Original Message - From: Bill Stoddard [EMAIL PROTECTED] To: Cliff Woolley [EMAIL PROTECTED] Cc: [EMAIL PROTECTED]; APR Development List [EMAIL PROTECTED] Sent: Tuesday, March 05, 2002 5:24 PM Subject: Re: apr_file_open() and caching

Re: AddOutputFilterByType

2002-03-05 Thread Justin Erenkrantz
On Tue, Mar 05, 2002 at 04:43:50PM -0600, William A Rowe, Jr wrote: Cut it out already :-) I'll try Rbb and I chatted about this earlier today It seems like once the decision is reached that we have a fast internal redirect, we should _stop_ processing that main request Obviously some

RE: AddOutputFilterByType

2002-03-05 Thread Ryan Bloom
Rbb and I chatted about this earlier today It seems like once the decision is reached that we have a fast internal redirect, we should _stop_ processing that main request Obviously some well defined return value from the hook fn, similar to DONE but not quite the same Ahem,

Re: cvs commit: httpd-2.0/server/mpm/worker worker.c

2002-03-05 Thread Jeff Trawick
Aaron Bannert [EMAIL PROTECTED] writes: On Tue, Mar 05, 2002 at 05:07:38PM -0500, Jeff Trawick wrote: Aaron Bannert [EMAIL PROTECTED] writes: On Tue, Mar 05, 2002 at 04:53:23PM -0500, Jeff Trawick wrote: Here is the sequence of events: 1) a thread in child process A is

Re: cvs commit: httpd-2.0/server/mpm/worker worker.c

2002-03-05 Thread Aaron Bannert
On Tue, Mar 05, 2002 at 07:02:46PM -0500, Jeff Trawick wrote: Will they actually hold the semaphore while they are servicing long-lived connections? no the semaphore is held only during the poll+accept I guess we'd have to make it so that as soon as that worker* is done

Re: cvs commit: httpd-2.0 STATUS

2002-03-05 Thread Aaron Bannert
On Tue, Mar 05, 2002 at 05:03:16PM -0500, Jeff Trawick wrote: axe the entry on graceful restart problems with worker I was too stupid to read the code to determine that the accept mutex failure log messages were harmless and not indicative of a real problem I'll

Re: cvs commit: httpd-2.0/server/mpm/worker worker.c

2002-03-05 Thread Jeff Trawick
Aaron Bannert [EMAIL PROTECTED] writes: On Tue, Mar 05, 2002 at 07:02:46PM -0500, Jeff Trawick wrote: Will they actually hold the semaphore while they are servicing long-lived connections? no... the semaphore is held only during the poll+accept I guess we'd have

Re: the three filter types

2002-03-05 Thread Greg Stein
On Mon, Mar 04, 2002 at 11:13:29PM -0600, William A Rowe, Jr wrote: At 07:53 PM 3/4/2002, you wrote: Just wanted to state that I believe Ryan has the correct distinction here -- that we have three types of filters However, the third type is a misnomer, and we can derive the proper name from

RE: AddOutputFilterByType

2002-03-05 Thread William A. Rowe, Jr.
What would be most cool is to set an r-replace_request member to the subrequest we will run Then in the run request phase, look at replace_request and run the insert_filters/run_handler against that replacement That could be goodness I agree that I'm not sure if it is really

Current CVS with PHP/CGI on Win32

2002-03-05 Thread Sebastian Bergmann
Just built the current CVS of httpd-20 and ran into the following problem: I use PHP with httpd-20 through CGI and everything works fine with a httpd-20 from a week ago, or so Accessing a php file with the current CVS HEAD version of httpd-20 results in a ''download offer'' of the

Re: cvs commit: httpd-2.0/modules/http http_request.c

2002-03-05 Thread Greg Stein
On Tue, Mar 05, 2002 at 05:41:28AM -, [EMAIL PROTECTED] wrote: rbb 02/03/04 21:41:28 Modified:modules/http http_request.c Log: Remove another hack from the server. The add_required_filters function was required to make sure that the sub request had the correct

Re: the three filter types (was: cvs commit: httpd-2.0/server core.c)

2002-03-05 Thread Greg Stein
On Mon, Mar 04, 2002 at 08:35:35PM -0800, Ryan Bloom wrote: On Sun, Mar 03, 2002 at 10:34:55PM -, [EMAIL PROTECTED] wrote: ... Just wanted to state that I believe Ryan has the correct distinction here -- that we have three types of filters. However, the third type is a misnomer, and