Re: svn commit: r906779 - /httpd/httpd/trunk/docs/manual/configuring.xml

2010-02-05 Thread Jeff Trawick
On Thu, Feb 4, 2010 at 9:48 PM, poir...@apache.org wrote: Author: poirier Date: Fri Feb  5 02:48:34 2010 New Revision: 906779 URL: http://svn.apache.org/viewvc?rev=906779view=rev Log: Be specific about which environment variables can be used in expansions in the server configuration file.

Re: svn commit: r906779 - /httpd/httpd/trunk/docs/manual/configuring.xml

2010-02-05 Thread Dan Poirier
[Moving discussion from dev@ to d...@httpd.apache.org] On Fri, Feb 5, 2010, at 06:57:58 AM, Jeff Trawick traw...@gmail.com wrote: On Thu, Feb 4, 2010 at 9:48 PM, poir...@apache.org wrote: +    pOnly environment variables defined before the server is started +    can be used in expansions.  

Re: [PATCH] LogLevel refactoring part 1

2010-02-05 Thread Dan Poirier
On Wed, Feb 3, 2010, at 03:22:21 AM, Stefan Fritsch s...@sfritsch.de wrote: ap_log_error_wrapper.diff: On C99 compilers, avoid argument setup and function call overhead if the log message will be discarded anyway. Also allow to disable higher loglevels at compile time by defining

Re: [PATCH] LogLevel refactoring part 1

2010-02-05 Thread Akins, Brian
On 2/5/10 9:39 AM, Dan Poirier poir...@pobox.com wrote: . E.g. maybe today I'd like to see all debug trace from authentication, but tomorrow just see SSL stuff. +1 -- Brian Akins

Re: [PATCH] LogLevel refactoring part 1

2010-02-05 Thread Stefan Fritsch
On Friday 05 February 2010, Dan Poirier wrote: On Wed, Feb 3, 2010, at 03:22:21 AM, Stefan Fritsch s...@sfritsch.de wrote: ap_log_error_wrapper.diff: On C99 compilers, avoid argument setup and function call overhead if the log message will be discarded anyway. Also allow to disable

Re: svn commit: r905454 - in /httpd/httpd/trunk: include/ap_mmn.h include/http_config.h modules/debugging/mod_dumpio.c server/core.c server/log.c server/main.c

2010-02-05 Thread Stefan Fritsch
On Thursday 04 February 2010, Jim Jagielski wrote: +char *err = Loglevel keyword must be one of emerg/alert/crit/error/warn/ +notice/info/debug; +int i = 0; Won't this be confusing that every error would refer to Loglevel, even if the bad directive is

r-connection-remote_ip and mod_remoteip

2010-02-05 Thread Graham Leggett
Hi all, Recently I have to deal with a number of modules that try to override the r-connection-remote_ip value in order to use the IP address originating from a load balancer, which obscures the real IP address of the client. All of these modules, including mod_remoteip in trunk, take a

Re: r-connection-remote_ip and mod_remoteip

2010-02-05 Thread William A. Rowe Jr.
On 2/5/2010 4:35 PM, Graham Leggett wrote: ideally there should be a value r-remote_ip, populated initially from connection-remote_ip, which a request can change at will, and that will go away when the request is finished. Modules that want to do access control, etc should rather look in