Re: [Patch] Async write completion for the full connection filter stack

2014-09-11 Thread Tim Bannister
On 10 Sep 2014, at 18:19, Jim Jagielski j...@jagunet.com wrote: On Sep 10, 2014, at 12:07 PM, Graham Leggett minf...@sharp.fm wrote: Having thought long and hard about this, giving filters an opportunity to write has nothing to do with either data or metadata, we just want to give the

RE: [Patch] Async write completion for the full connection filter stack

2014-09-11 Thread Plüm , Rüdiger , Vodafone Group
From: Graham Leggett [mailto:minf...@sharp.fm] Sent: Donnerstag, 11. September 2014 06:40 To: dev@httpd.apache.org Subject: Re: [Patch] Async write completion for the full connection filter stack On 11 Sep 2014, at 1:51 AM, Yann Ylavic ylavic@gmail.commailto:ylavic@gmail.com wrote:

Re: mod_proxy: PHP SCRIPT_FILENAME (PHP-FPM using UDS) and Apache documentation

2014-09-11 Thread Jan Kaluža
On 09/10/2014 07:17 PM, Jim Jagielski wrote: I know that PHP is current doing a LOT of fixes on hPHP-FPM... I've recently come to https://bugs.php.net/bug.php?id=65641 and was thinking if we can do anything about it. Jan Kaluza On Sep 10, 2014, at 12:00 PM, Martynas Bendorius

RE: [Patch] Async write completion for the full connection filter stack

2014-09-11 Thread Plüm , Rüdiger , Vodafone Group
-Original Message- From: Yann Ylavic [mailto:ylavic@gmail.com] Sent: Donnerstag, 11. September 2014 09:52 To: httpd Subject: Re: [Patch] Async write completion for the full connection filter stack On Thu, Sep 11, 2014 at 6:39 AM, Graham Leggett minf...@sharp.fm wrote: On

Re: mod_proxy: PHP SCRIPT_FILENAME (PHP-FPM using UDS) and Apache documentation

2014-09-11 Thread Jim Jagielski
Recall that that when used, the req is basically tacked on what is provided in the SetHandler, so whether a trailing / is required or not depends 100% on how the app is expecting it to be. On Sep 10, 2014, at 1:26 PM, Martynas Bendorius marty...@martynas.it wrote: Yes, I've tried their latest

Re: mod_proxy: PHP SCRIPT_FILENAME (PHP-FPM using UDS) and Apache documentation

2014-09-11 Thread Jim Jagielski
When *we* generate SCRIPT_FILENAME, we simply use what r-filename is. On Sep 11, 2014, at 3:04 AM, Jan Kaluža jkal...@redhat.com wrote: On 09/10/2014 07:17 PM, Jim Jagielski wrote: I know that PHP is current doing a LOT of fixes on hPHP-FPM... I've recently come to

Re: mod_proxy: PHP SCRIPT_FILENAME (PHP-FPM using UDS) and Apache documentation

2014-09-11 Thread Jim Jagielski
Hmmm... ProxyPassMatch .*/sample/(test.php.*) fcgi://127.0.0.1:9000//tmp/sample/$1 So they *put* the '//' there. On Sep 11, 2014, at 3:04 AM, Jan Kaluža jkal...@redhat.com wrote: On 09/10/2014 07:17 PM, Jim Jagielski wrote: I know that PHP is current doing a LOT of fixes on

Re: [Patch] Async write completion for the full connection filter stack

2014-09-11 Thread Yann Ylavic
On Thu, Sep 11, 2014 at 9:51 AM, Yann Ylavic ylavic@gmail.com wrote: On Thu, Sep 11, 2014 at 6:39 AM, Graham Leggett minf...@sharp.fm wrote: I don’t follow - that means something different as I’m reading it. We must only signal that we have less data in the output filters if we actually

Re: [Patch] Async write completion for the full connection filter stack

2014-09-11 Thread Yann Ylavic
On Thu, Sep 11, 2014 at 2:12 PM, Yann Ylavic ylavic@gmail.com wrote: AP_DECLARE(int) ap_filter_reinstate_brigade(ap_filter_t *f, apr_bucket_brigade *buffered_bb, apr_bucket_brigade *bb,

mod_status: Apache 2.4 incorrect IP (proxy, not useragent_ip) on server-status page

2014-09-11 Thread Martynas Bendorius
Hello, Would it be possible to change the documentation of mod_remoteip for 2.4 (http://httpd.apache.org/docs/2.4/mod/mod_remoteip.html), and get is reported by mod_status removed from the page? As it leds Apache customers to believe that it will report a real (useragent) IP instead of a

Re: mod_status: Apache 2.4 incorrect IP (proxy, not useragent_ip) on server-status page

2014-09-11 Thread Jim Jagielski
isn't the question rather What should ap_get_remote_host() return?? On Sep 11, 2014, at 8:17 AM, Martynas Bendorius marty...@martynas.it wrote: Hello, Would it be possible to change the documentation of mod_remoteip for 2.4 (http://httpd.apache.org/docs/2.4/mod/mod_remoteip.html), and get

Re: mod_status: Apache 2.4 incorrect IP (proxy, not useragent_ip) on server-status page

2014-09-11 Thread Martynas Bendorius
Yes, we may re-phrase it like that, if we'd like to fix it in apache source (and not documentation) :) Currently ap_get_remote_host in server/core.c doesn't return useragent_ip, and instead of it we get conn-client_ip. Best regards, Martynas Bendorius On 9/11/14 4:21 PM, Jim Jagielski wrote:

RE: Re: mod_status: Apache 2.4 incorrect IP (proxy, not useragent_ip) on server-status page

2014-09-11 Thread wrowe
+1, this is the right question, Jim. From the docs for mod_remoteip; This module is used to treat the useragent which initiated the request as the originating useragent as identified by httpd for the purposes of authorization and logging The module overrides the client IP address for the

Re: [Patch] Async write completion for the full connection filter stack

2014-09-11 Thread Graham Leggett
On 11 Sep 2014, at 9:51 AM, Yann Ylavic ylavic@gmail.com wrote: If we or any filter has created the brigade on *deferred_write_pool (or an ancestor, I'm only talking about this case), it is dead now (unaccessible), and IMO should be marked as so. In the case the caller let the function

Re: [Patch] Async write completion for the full connection filter stack

2014-09-11 Thread Graham Leggett
On 11 Sep 2014, at 2:12 PM, Yann Ylavic ylavic@gmail.com wrote: Again I missed something... This code is indeed what I'd like ap_core_output_filter() (or any filter) to be able to do, but it won't work without a slight change in ap_filter_reinstate_brigade(), which is :

RE: Re: mod_status: Apache 2.4 incorrect IP (proxy, not useragent_ip) on server-status page

2014-09-11 Thread wrowe
However, the API is not going to make this trivial to fix. ap_get_remote_host is connection-based. And that is what mod_authz_host is currently relying upon. It seems that there needs to be a way for mod_remoteip to override the existing behavior, perhaps ap_set_remote_host(), that will

Re: mod_status: Apache 2.4 incorrect IP (proxy, not useragent_ip) on server-status page

2014-09-11 Thread Jim Jagielski
Ugg. Yeah; we should actually have a complimentary version that takes request_req as the param, not conn_rec. ap_get_remote_host_r()?? Ugly. On Sep 11, 2014, at 11:28 AM, wr...@rowe-clan.net wrote: However, the API is not going to make this trivial to fix. ap_get_remote_host is

RE: Re: mod_status: Apache 2.4 incorrect IP (proxy, not useragent_ip) on server-status page

2014-09-11 Thread wrowe
- Original Message - Subject: Re: mod_status: Apache 2.4 incorrect IP (proxy, not useragent_ip) on server-status page From: Jim Jagielski j...@jagunet.com Date: 9/11/14 10:45 am To: dev@httpd.apache.org Ugg. Yeah; we should actually have a complimentary version that takes

Re: mod_status: Apache 2.4 incorrect IP (proxy, not useragent_ip) on server-status page

2014-09-11 Thread Reindl Harald
Am 11.09.2014 um 18:13 schrieb wr...@rowe-clan.net: Subject: Re: mod_status: Apache 2.4 incorrect IP (proxy, not useragent_ip) on server-status page From: Jim Jagielski j...@jagunet.com Date: 9/11/14 10:45 am To: dev@httpd.apache.org Ugg. Yeah; we should actually have

Re: mod_status: Apache 2.4 incorrect IP (proxy, not useragent_ip) on server-status page

2014-09-11 Thread Jim Jagielski
Well, fixing this *specifically* for mod_status is easy, but, as you say, the problem is more systemic than that. On Sep 11, 2014, at 12:13 PM, wr...@rowe-clan.net wrote: - Original Message - Subject: Re: mod_status: Apache 2.4 incorrect IP (proxy, not useragent_ip) on

Trunk errors for proxy

2014-09-11 Thread Jim Jagielski
Anyone else seeing the test framework erroring out on mod_proxy* tests on trunk? t/modules/proxy.t ... 7/17 # Failed test 16 in t/modules/proxy.t at line 74 # Failed test 17 in t/modules/proxy.t at line 75 t/modules/proxy.t ... Failed 2/17 subtests

Re: Trunk errors for proxy

2014-09-11 Thread Jim Jagielski
Nevermind... local build issue. On Sep 11, 2014, at 2:01 PM, Jim Jagielski j...@jagunet.com wrote: Anyone else seeing the test framework erroring out on mod_proxy* tests on trunk? t/modules/proxy.t ... 7/17 # Failed test 16 in t/modules/proxy.t at line 74 # Failed test 17

Re: [PATCH] SuexecUserGroup inside Directory context

2014-09-11 Thread nsc
+1 nsc On 2014.09.11 22:16, Martynas Bendorius wrote: I've created a patch for it, as I didn't have my question answered :) From my point of view it's still secure, as it doesn't allow to set SuexecUserGroup in .htaccess. I tested it and had no problems with it. Please include it into the

Re: [Patch] Async write completion for the full connection filter stack

2014-09-11 Thread Ruediger Pluem
On 09/11/2014 05:20 PM, Graham Leggett wrote: On 11 Sep 2014, at 9:51 AM, Yann Ylavic ylavic@gmail.com wrote: If we or any filter has created the brigade on *deferred_write_pool (or an ancestor, I'm only talking about this case), it is dead now (unaccessible), and IMO should be marked