PR 53435, r101624, mod_ssl: error strings can't be loaded again once?

2014-11-11 Thread Jan Kaluža
Hi, latest comment in PR 53435 shows that memory leak in mod_ssl which happens during graceful restarts can be caused by r101624. Since this commit is 11 years old, I wanted to ask people here, if following is still true with current OpenSSL: @@ -255,7 +255,11 @@ static apr_status_t

Fwd: SuexecUserGroup inside Directory context

2014-11-11 Thread Marc Aymerich
On 9/11/14 1:26 AM, Martynas Bendorius wrote: For someone who is going to review the patch, I am adding more information of why is the patch needed. Patch includes only a few minor changes to it, that would help shared web hosting to adopt FastCGI for some critical parts like global

is this pattern in event safe?

2014-11-11 Thread Eric Covener
is this pattern in event safe? apr_pool_clear(cs-p); ap_push_pool(worker_queue_info, cs-p); cs itself is allocated from cs-p (ptrans) Must cs-p be copied to the stack since MaxMemFree could return these bytes? (I have been chasing a rare crash in this neighborhood, but this

Re: PR 53435, r101624, mod_ssl: error strings can't be loaded again once?

2014-11-11 Thread Dr Stephen Henson
On 11/11/2014 13:32, Jan Kaluža wrote: Hi, latest comment in PR 53435 shows that memory leak in mod_ssl which happens during graceful restarts can be caused by r101624. Since this commit is 11 years old, I wanted to ask people here, if following is still true with current OpenSSL: @@

Re: [Patch] mod_ssl SSL_CLIENT_CERT_SUBJECTS - access to full client certificate chain

2014-11-11 Thread Kaspar Brand
On 09.11.2014 14:30, Graham Leggett wrote: On 06 Nov 2014, at 8:05 AM, Kaspar Brand httpd-dev.2...@velox.ch wrote: Is there another way to do this? Manually performing what certificateExactMatch is specifying, I would say - i.e., use the (SSL_CLIENT_M_SERIAL,SSL_CLIENT_I_DN) tuple as a

Re: PR 53435, r101624, mod_ssl: error strings can't be loaded again once?

2014-11-11 Thread Kaspar Brand
On 12.11.2014 03:28, Dr Stephen Henson wrote: I just checked the sources and this was fixed in OpenSSL 0.9.7m just over 7 years ago... For 0.9.8, it was fixed with 0.9.8e: https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=900f7a87760d1053127976480efcd71371787d6e I.e., given that

Re: PR 53435, r101624, mod_ssl: error strings can't be loaded again once?

2014-11-11 Thread Jan Kaluža
On 11/12/2014 07:16 AM, Kaspar Brand wrote: On 12.11.2014 03:28, Dr Stephen Henson wrote: I just checked the sources and this was fixed in OpenSSL 0.9.7m just over 7 years ago... For 0.9.8, it was fixed with 0.9.8e: