Re: [PATCH] Balancers, VirtualHost and ProxyPass

2014-12-12 Thread Jan Kaluža
On 12/11/2014 03:05 PM, Plüm, Rüdiger, Vodafone Group wrote: -Original Message- From: Jan Kaluža [mailto:jkal...@redhat.com] Sent: Donnerstag, 11. Dezember 2014 14:40 To: dev@httpd.apache.org Subject: Re: [PATCH] Balancers, VirtualHost and ProxyPass On 12/11/2014 08:47 AM, Jan Kaluža

Re: [PATCH] Balancers, VirtualHost and ProxyPass

2014-12-12 Thread Ruediger Pluem
On 12/12/2014 09:44 AM, Jan Kaluža wrote: On 12/11/2014 03:05 PM, Plüm, Rüdiger, Vodafone Group wrote: -Original Message- From: Jan Kaluža [mailto:jkal...@redhat.com] Sent: Donnerstag, 11. Dezember 2014 14:40 To: dev@httpd.apache.org Subject: Re: [PATCH] Balancers, VirtualHost

Re: [PATCH] Balancers, VirtualHost and ProxyPass

2014-12-12 Thread Yann Ylavic
Hi Jan, On Fri, Dec 12, 2014 at 9:44 AM, Jan Kaluža jkal...@redhat.com wrote: On 12/11/2014 03:05 PM, Plüm, Rüdiger, Vodafone Group wrote: Looks fine in general. Details: I hope I've finally fixed everything now :), see the attached patch please. Aren't the following parameters missing for

Re: [PATCH] Balancers, VirtualHost and ProxyPass

2014-12-12 Thread Yann Ylavic
On Fri, Dec 12, 2014 at 12:08 PM, Yann Ylavic ylavic@gmail.com wrote: IMHO there should be a deep copy here, that's another balancer, with its own mutexes, own members having their own parameters, own sockets... Oh, got it now... If this is expected, the admin can still declare a new

Re: [PATCH] Balancers, VirtualHost and ProxyPass

2014-12-12 Thread Jan Kaluža
On 12/12/2014 12:08 PM, Yann Ylavic wrote: Hi Jan, On Fri, Dec 12, 2014 at 9:44 AM, Jan Kaluža jkal...@redhat.com wrote: On 12/11/2014 03:05 PM, Plüm, Rüdiger, Vodafone Group wrote: Looks fine in general. Details: I hope I've finally fixed everything now :), see the attached patch please.

Re: [PATCH] Balancers, VirtualHost and ProxyPass

2014-12-12 Thread Jan Kaluža
On 12/12/2014 11:56 AM, Ruediger Pluem wrote: On 12/12/2014 09:44 AM, Jan Kaluža wrote: On 12/11/2014 03:05 PM, Plüm, Rüdiger, Vodafone Group wrote: -Original Message- From: Jan Kaluža [mailto:jkal...@redhat.com] Sent: Donnerstag, 11. Dezember 2014 14:40 To: dev@httpd.apache.org

AW: [PATCH] Balancers, VirtualHost and ProxyPass

2014-12-12 Thread Plüm , Rüdiger , Vodafone Group
-Ursprüngliche Nachricht- Von: Jan Kaluža [mailto:jkal...@redhat.com] Gesendet: Freitag, 12. Dezember 2014 14:00 An: dev@httpd.apache.org Betreff: Re: [PATCH] Balancers, VirtualHost and ProxyPass You are right :(. Fix attached. Order of errstatuses should not be a problem. Its

Re: [PATCH] Balancers, VirtualHost and ProxyPass

2014-12-12 Thread Yann Ylavic
On Fri, Dec 12, 2014 at 2:09 PM, Plüm, Rüdiger, Vodafone Group ruediger.pl...@vodafone.com wrote: -Ursprüngliche Nachricht- Von: Jan Kaluža [mailto:jkal...@redhat.com] Gesendet: Freitag, 12. Dezember 2014 14:00 An: dev@httpd.apache.org Betreff: Re: [PATCH] Balancers, VirtualHost and

Re: [PATCH] Balancers, VirtualHost and ProxyPass

2014-12-12 Thread Jan Kaluža
On 12/12/2014 02:17 PM, Yann Ylavic wrote: On Fri, Dec 12, 2014 at 2:09 PM, Plüm, Rüdiger, Vodafone Group ruediger.pl...@vodafone.com wrote: -Ursprüngliche Nachricht- Von: Jan Kaluža [mailto:jkal...@redhat.com] Gesendet: Freitag, 12. Dezember 2014 14:00 An: dev@httpd.apache.org

Re: [PATCH] Balancers, VirtualHost and ProxyPass

2014-12-12 Thread Yann Ylavic
On Fri, Dec 12, 2014 at 2:23 PM, Jan Kaluža jkal...@redhat.com wrote: Thanks you both, that one was painful :(. Thank *you* for the improvement! Most of my remarks were noise, sorry if you wasted time with them... Yann.