Re: mod_proxy_wstunnel ignores proxy_wstunnel_transfer errors

2015-03-18 Thread Yann Ylavic
On Wed, Mar 18, 2015 at 8:07 AM, Jan Kaluža jkal...@redhat.com wrote: I have no big knowledge of WebSockets, but it should be possible to detect Switching Protocol header and return HTTP error if some error happens before we switch to WebSocket. Would this be acceptable, or you think this

Re: mod_proxy_wstunnel ignores proxy_wstunnel_transfer errors

2015-03-18 Thread Jan Kaluža
On 03/18/2015 10:01 AM, Yann Ylavic wrote: On Wed, Mar 18, 2015 at 9:48 AM, Jan Kaluža jkal...@redhat.com wrote: On 03/18/2015 09:23 AM, Yann Ylavic wrote: On Wed, Mar 18, 2015 at 8:07 AM, Jan Kaluža jkal...@redhat.com wrote: I have no big knowledge of WebSockets, but it should be possible

Re: mod_proxy_wstunnel ignores proxy_wstunnel_transfer errors

2015-03-18 Thread Yann Ylavic
Corresponding patch attached... On Wed, Mar 18, 2015 at 10:57 AM, Yann Ylavic ylavic@gmail.com wrote: On Wed, Mar 18, 2015 at 10:44 AM, Yann Ylavic ylavic@gmail.com wrote: [] Index: modules/proxy/mod_proxy_wstunnel.c ===

Re: mod_proxy_wstunnel ignores proxy_wstunnel_transfer errors

2015-03-18 Thread Jan Kaluža
On 03/18/2015 11:07 AM, Yann Ylavic wrote: Corresponding patch attached... On Wed, Mar 18, 2015 at 10:57 AM, Yann Ylavic ylavic@gmail.com wrote: On Wed, Mar 18, 2015 at 10:44 AM, Yann Ylavic ylavic@gmail.com wrote: [] Index: modules/proxy/mod_proxy_wstunnel.c

Re: mod_proxy_wstunnel ignores proxy_wstunnel_transfer errors

2015-03-18 Thread Jan Kaluža
On 03/18/2015 09:23 AM, Yann Ylavic wrote: On Wed, Mar 18, 2015 at 8:07 AM, Jan Kaluža jkal...@redhat.com wrote: I have no big knowledge of WebSockets, but it should be possible to detect Switching Protocol header and return HTTP error if some error happens before we switch to WebSocket.

Re: mod_proxy_wstunnel ignores proxy_wstunnel_transfer errors

2015-03-18 Thread Yann Ylavic
On Wed, Mar 18, 2015 at 10:44 AM, Yann Ylavic ylavic@gmail.com wrote: [] Index: modules/proxy/mod_proxy_wstunnel.c === --- modules/proxy/mod_proxy_wstunnel.c(revision 1665828) +++ modules/proxy/mod_proxy_wstunnel.c

Re: mod_proxy_wstunnel ignores proxy_wstunnel_transfer errors

2015-03-18 Thread Yann Ylavic
On Wed, Mar 18, 2015 at 9:48 AM, Jan Kaluža jkal...@redhat.com wrote: On 03/18/2015 09:23 AM, Yann Ylavic wrote: On Wed, Mar 18, 2015 at 8:07 AM, Jan Kaluža jkal...@redhat.com wrote: I have no big knowledge of WebSockets, but it should be possible to detect Switching Protocol header and

Re: mod_proxy_wstunnel ignores proxy_wstunnel_transfer errors

2015-03-18 Thread Yann Ylavic
On Wed, Mar 18, 2015 at 10:30 AM, Jan Kaluža jkal...@redhat.com wrote: What's going on here is that backend does not reply anything. proxy_wstunnel_transfer returns APR_EOF without receiving 101 Switching Protocols from the backend and without passing anything to the client. Hm, so

Re: mod_proxy_wstunnel ignores proxy_wstunnel_transfer errors

2015-03-18 Thread Jan Kaluža
On 03/17/2015 02:10 PM, Eric Covener wrote: On Tue, Mar 17, 2015 at 9:06 AM, Yann Ylavic ylavic@gmail.com wrote: GET /test/ HTTP/1.1 User-Agent: curl/7.29.0 Host: 127.0.0.1 Accept: */* No Upgrade header in this test? Right, no Upgrade header. That's the particular situation where one

Re: mod_proxy_wstunnel ignores proxy_wstunnel_transfer errors

2015-03-18 Thread Jan Kaluža
On 03/17/2015 02:06 PM, Yann Ylavic wrote: On Tue, Mar 17, 2015 at 1:47 PM, Jan Kaluža jkal...@redhat.com wrote: On 03/17/2015 01:23 PM, Yann Ylavic wrote: On Tue, Mar 17, 2015 at 12:38 PM, Jan Kaluža jkal...@redhat.com wrote: Hi, I have found out that when WSS is used and SSL handshake