Re: *Match, RewriteRule POLA violation?

2015-05-01 Thread Niklas Edmundsson
On Thu, 30 Apr 2015, Yann Ylavic wrote: On Thu, Apr 30, 2015 at 2:57 PM, Jim Riggs apache-li...@riggs.me wrote: Thanks, Yann. I remember looking at this code before. The question remains, though: Is it currently wrong? Does it need to be fixed, or was this distinction made intentionally? Is

Re: *Match, RewriteRule POLA violation?

2015-05-01 Thread André Malo
* Niklas Edmundsson wrote: On Thu, 30 Apr 2015, Yann Ylavic wrote: On Thu, Apr 30, 2015 at 2:57 PM, Jim Riggs apache-li...@riggs.me wrote: Thanks, Yann. I remember looking at this code before. The question remains, though: Is it currently wrong? Does it need to be fixed, or was this

Re: Best practice for handling synchronous signals SIGFPE etc

2015-05-01 Thread Mark Taylor
Great information, thanks all! -Mark On Mon, Apr 20, 2015 at 6:15 PM, Sorin Manolache sor...@gmail.com wrote: On 2015-04-20 21:50, Mark Taylor wrote: I found that ./server/mpm_unix.c is registering a handler (sig_coredump) for SIGFPE, SIGSEGV, and other synchronous signals. I'd like to

mod_ssl: inline SSL_X509_INFO_load_path(); please review

2015-05-01 Thread Stefan Sperling
I believe SSL_X509_INFO_load_path() should be inlined into its only caller. I'd like some eyes on this change since it's not just mechanical. The desired behaviour seems to be load as many certs as possible from a directory, looping over its file entries. Ignore errors, e.g. in case the file is

Re: mod_ssl namespacing: app_data2

2015-05-01 Thread Stefan Sperling
On Fri, May 01, 2015 at 09:39:14AM -0400, Eric Covener wrote: On Fri, May 1, 2015 at 9:33 AM, Stefan Sperling s...@apache.org wrote: This moves symbols related to '2nd application data' into the ssl_ namespace. File-level static symbols have no external linkage so don't need a

Re: Looking ahead to 2.4.13 / 2.2.30

2015-05-01 Thread Jim Jagielski
Yeah... I was gonna propose that once I had the weekend to take a more in-depth look at 2.4... But I am +1 for a release v. soon. Yeah, I'll RM 2.4 On Apr 30, 2015, at 5:52 PM, William A Rowe Jr wr...@rowe-clan.net wrote: On Thu, Apr 2, 2015 at 4:46 PM, William A. Rowe Jr. wr...@rowe-clan.net

Re: mod_ssl namespacing: app_data2

2015-05-01 Thread Stefan Sperling
On Sat, Apr 18, 2015 at 07:22:06PM +0200, Stefan Sperling wrote: This moves symbols related to '2nd application data' into the ssl_ namespace. File-level static symbols have no external linkage so don't need a namespace. Same patch as before, but moving into modssl_ function namespace, instead

Re: mod_ssl namespacing: app_data2

2015-05-01 Thread Eric Covener
On Fri, May 1, 2015 at 9:33 AM, Stefan Sperling s...@apache.org wrote: This moves symbols related to '2nd application data' into the ssl_ namespace. File-level static symbols have no external linkage so don't need a namespace. Same patch as before, but moving into modssl_ function namespace,