Re: maintainer mode and test framework

2015-08-24 Thread Eric Covener
On Mon, Aug 24, 2015 at 9:41 AM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: mod_test_session.c did some non C90 variable declarations intermixed with code. I'll check in the fix shortly. Btw. what is holding us back from more recent C? Old platforms, obviously... Do we have an idea

maintainer mode and test framework

2015-08-24 Thread Stefan Eissing
Just a tiny question how the senior guys here do to: If I build httpd in maintainer-mode (which I want), the test framework will no longer build since it inherits the compiler flags from apxs, I assume. Is there an easy way around this? //Stefan green/bytes GmbH Hafenweg 16, 48155 Münster,

Re: maintainer mode and test framework

2015-08-24 Thread Eric Covener
On Mon, Aug 24, 2015 at 9:23 AM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: Just a tiny question how the senior guys here do to: If I build httpd in maintainer-mode (which I want), the test framework will no longer build since it inherits the compiler flags from apxs, I assume. Is

Re: maintainer mode and test framework

2015-08-24 Thread Stefan Eissing
OK, now you made me fix it. ;-) mod_test_session.c did some non C90 variable declarations intermixed with code. I'll check in the fix shortly. Btw. what is holding us back from more recent C? Old platforms, obviously... Do we have an idea which? Am 24.08.2015 um 15:24 schrieb Eric Covener

regression tests

2015-08-24 Thread Stefan Eissing
I seem to get Test Summary Report --- t/filter/case.t (Wstat: 0 Tests: 4 Failed: 1) Failed test: 2 in regression tests since my vacation. Anything rings a bell? green/bytes GmbH Hafenweg 16, 48155 Münster, Germany Phone: +49 251 2807760. Amtsgericht Münster:

Re: maintainer mode and test framework

2015-08-24 Thread William A Rowe Jr
On Aug 24, 2015 08:45, Eric Covener cove...@gmail.com wrote: On Mon, Aug 24, 2015 at 9:41 AM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: mod_test_session.c did some non C90 variable declarations intermixed with code. I'll check in the fix shortly. Btw. what is holding us back from

PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-24 Thread Jan Kaluža
Hi, unfortunately, the r1680920 brought undesired behavior described in PR 58267 to 2.2.x. The bug is well described in the PR, so I won't describe it in this email. I have tried to debug it and I think the problem is that we use also server-server_hostname to compute the hash in the

Re: PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-24 Thread Jan Kaluža
On 08/24/2015 04:47 PM, Jan Kaluža wrote: Hi, unfortunately, the r1680920 brought undesired behavior described in PR 58267 to 2.2.x. The bug is well described in the PR, so I won't describe it in this email. I have tried to debug it and I think the problem is that we use also

Re: Fwd: Unexpected Warnings from Macro Use in 2.4

2015-08-24 Thread Eric Covener
On Mon, Aug 24, 2015 at 11:21 AM, Rainer Jung rainer.j...@kippdata.de wrote: think it would be better if httpd core (${x}) and mod_rewrite (%{x}) could stay as-is and mod_macro would support yet another prefix like . +1 -- Eric Covener cove...@gmail.com

Re: Fwd: Unexpected Warnings from Macro Use in 2.4

2015-08-24 Thread Rainer Jung
Am 24.08.2015 um 13:40 schrieb Nick Gearls: This is definitely a bug as we have a major incompatibility between two features. Remark: although mod_macro can use $ and % for unescaped characters, ${x} is used by Define and %{x} by mod_rewrite :-( Shooting from the hip: {x} Haven't checked

Re: PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-24 Thread Yann Ylavic
Hi Jan, I was working on the same issue... and was going to implement 2) :) On Mon, Aug 24, 2015 at 4:47 PM, Jan Kaluža jkal...@redhat.com wrote: Now, the root of the error is that the scoreboard size is static (set to proxy_lb_workers + PROXY_DYNAMIC_BALANCER_LIMIT), but it is not

protocols and mod_h2 consolidation

2015-08-24 Thread Stefan Eissing
As you might have noticed, I am doing some cleanup work on mod_h2 and want to create THE PATCH for backporting soon. The new core directives Protocols and ProtocolsHonorOrder are implemented, such as on a server or virtual host one may write Protocols h2c http/1.1 # enable h2c and

Re: protocols and mod_h2 consolidation

2015-08-24 Thread Eric Covener
On Mon, Aug 24, 2015 at 12:29 PM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: I hope this works for everyone. The next weeks might be a good time to think about it and propose any changes and correct my mistakes. Look good in concept to me

Re: svn commit: r1696105 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_socache_memcache.xml modules/cache/mod_socache_memcache.c

2015-08-24 Thread Christophe JAILLET
Hi, Yann and thanks for the review. Le 21/08/2015 15:47, Yann Ylavic a écrit : On Sun, Aug 16, 2015 at 12:05 AM, jaillet...@apache.org wrote: Author: jailletc36 Date: Sat Aug 15 22:05:08 2015 New Revision: 1696105 URL: http://svn.apache.org/r1696105 [] Modified:

Re: svn commit: r1696960 - in /httpd/httpd/trunk: CHANGES docs/log-message-tags/next-number modules/proxy/mod_proxy_balancer.c

2015-08-24 Thread Yann Ylavic
On Fri, Aug 21, 2015 at 8:07 PM, Ruediger Pluem rpl...@apache.org wrote: On 08/21/2015 07:02 PM, Yann Ylavic wrote: On Fri, Aug 21, 2015 at 4:15 PM, Ruediger Pluem rpl...@apache.org wrote: Hm. Doesn't that mean that if I keep on adding stuff and do graceful restarts that at one point in

Re: modules\http2 - H2Engine directive?

2015-08-24 Thread Stefan Eissing
Ni Norm, yes, I removed it last week and though I removed it from the doc xml as well. Seems I forgot the Readme. Will fix soon. Sorry for any confusion. //Stefan Am 24.08.2015 um 05:53 schrieb NormW no...@gknw.net: Hi, The 'H2Engine on' directive is identified in the Readme.h2 as the

Re: modules\http2 - H2Engine directive?

2015-08-24 Thread NormW
Hi Stefan, Thanks for the clarification! A text search for 'H2Engine' shows it in a number of other languages under '.\manual\mod\directives', 'manual\mod\quickreference' and in '\docs\conf\extra\httpd-h2.conf.in'. HTH, Thanks, Norm On 24/08/2015 6:06 PM, Stefan Eissing wrote: Ni Norm, yes,

Re: svn commit: r1696105 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_socache_memcache.xml modules/cache/mod_socache_memcache.c

2015-08-24 Thread Yann Ylavic
On Mon, Aug 24, 2015 at 8:17 AM, Christophe JAILLET christophe.jail...@wanadoo.fr wrote: Le 21/08/2015 15:47, Yann Ylavic a écrit : On Sun, Aug 16, 2015 at 12:05 AM, jaillet...@apache.org wrote: +if ((i 1) || (i 1800)) { Why a limit of 1800? Maybe the implicit INT_MAX is good

Re: svn commit: r1697322 - /httpd/httpd/branches/2.4.x/STATUS

2015-08-24 Thread Nick Kew
On Mon, 24 Aug 2015 07:40:33 - rpl...@apache.org wrote: --- httpd/httpd/branches/2.4.x/STATUS (original) +++ httpd/httpd/branches/2.4.x/STATUS Mon Aug 24 07:40:33 2015 @@ -238,8 +238,15 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK: +1: rpluem, ylavic niq: 1. the

Fwd: Unexpected Warnings from Macro Use in 2.4

2015-08-24 Thread Nick Gearls
This is definitely a bug as we have a major incompatibility between two features. Remark: although mod_macro can use $ and % for unescaped characters, ${x} is used by Define and %{x} by mod_rewrite :-( I suppose the preferred solution to not be incompatible with the current situation would be

Re: Unexpected Warnings from Macro Use in 2.4

2015-08-24 Thread Eric Covener
On Mon, Aug 24, 2015 at 7:40 AM, Nick Gearls nickgea...@gmail.com wrote: Remark: although mod_macro can use $ and % for unescaped characters, ${x} is used by Define and %{x} by mod_rewrite :-( Just to make sure it's clear, ${x} is even older then Define and is used to resolve real native

Re: PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-24 Thread Yann Ylavic
On Mon, Aug 24, 2015 at 5:51 PM, Yann Ylavic ylavic@gmail.com wrote: On Mon, Aug 24, 2015 at 4:47 PM, Jan Kaluža jkal...@redhat.com wrote: 2) Increment proxy_lb_workers according to number of workers in balancer when using ProxyPass /foobar/ Balancer://foobar/ in the VirtualHost. The

Re: svn commit: r1696105 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_socache_memcache.xml modules/cache/mod_socache_memcache.c

2015-08-24 Thread Christophe JAILLET
Le 24/08/2015 11:18, Yann Ylavic a écrit : On Mon, Aug 24, 2015 at 8:17 AM, Christophe JAILLET christophe.jail...@wanadoo.fr wrote: Le 21/08/2015 15:47, Yann Ylavic a écrit : On Sun, Aug 16, 2015 at 12:05 AM, jaillet...@apache.org wrote: +if ((i 1) || (i 1800)) { Why a limit of 1800?

Re: protocols and mod_h2 consolidation

2015-08-24 Thread Gregg Smith
Hi, On 8/24/2015 9:29 AM, Stefan Eissing wrote: I hope this works for everyone. The next weeks might be a good time to think about it and propose any changes and correct my mistakes. There are two things that go bump on my lowest non-eol version of MSVC. h2_worker.c .\h2_worker.c(113) :