Re: mod_mime_magic, gzipped tarballs and Docker

2016-01-08 Thread Yann Ylavic
Hi, On Fri, Jan 8, 2016 at 8:49 AM, Jan Kaluža wrote: > > Content-Type: application/x-tar > Content-Encoding: x-gzip [] > > So, the mod_mime_magic is saying here that the body is tarball encoded by > gzip. AIUI, mod_mime_magic does indeed try to uncompress the tar.gz and

Re: mod_mime_magic, gzipped tarballs and Docker

2016-01-08 Thread William A Rowe Jr
Do we have to repeat the softmagic call if checkzmagic resolves to x-gzip/x-deflate and the internal content type needs to be deciphered? If so, a tweak to this patch sounds like a winner, and could selectively recognize different inflation streams including bzip2 etc. On Fri, Jan 8, 2016 at

Re: Work in progress: mod_proxy Health Check module

2016-01-08 Thread Jim Jagielski
Thx! Any other comments/suggestions? > On Jan 8, 2016, at 10:53 AM, Eric Covener wrote: > > On Fri, Jan 8, 2016 at 10:18 AM, Jim Jagielski wrote: >> I am thinking about the actual health-check impl a bit more, >> hence the lack of commits. As noted,

Re: mod_mime_magic, gzipped tarballs and Docker

2016-01-08 Thread Jim Jagielski
Looks right to me... using the address of a local var is nasty and broken and for sure will cause grief. > On Jan 8, 2016, at 2:30 PM, Christophe JAILLET > wrote: > > Hi, > > not directly related to this discussion, but while looking at mod_mime_magic, > could

Re: mod_mime_magic, gzipped tarballs and Docker

2016-01-08 Thread Jim Jagielski
Alternatively, it could use a global extern var and avoid the dup. > On Jan 8, 2016, at 3:00 PM, Jim Jagielski wrote: > > Looks right to me... using the address of a local var is nasty > and broken and for sure will cause grief. > >> On Jan 8, 2016, at 2:30 PM, Christophe

Re: mod_mime_magic, gzipped tarballs and Docker

2016-01-08 Thread Christophe JAILLET
Hi, not directly related to this discussion, but while looking at mod_mime_magic, could someone have a look at: http://svn.apache.org/viewvc?view=revision=date=1491700 I also tried to get some feedback some time ago (http://marc.info/?l=apache-httpd-dev=137106479314698) but at that time,

Re: Work in progress: mod_proxy Health Check module

2016-01-08 Thread Daniel Ruggeri
++1 on this vein of thought. Implementing the health checking similar to the modularized lb methods makes the most sense to me. I can already think of several methods (file, conf, external script, lua script) of obtaining data on how to probe and react. Just some thoughts worth considering...

Re: mod_mime_magic, gzipped tarballs and Docker

2016-01-08 Thread Jan Kaluža
On 01/08/2016 08:49 AM, Jan Kaluža wrote: Hi, it seems Docker client has a problem handling httpd responses [1] when you run Docker server behind httpd working as a reverse proxy. It is caused by "mod_mime_magic" adding following Content-Type and Content-Encoding to gzipped tarballs sent as a

Re: mod_mime_magic, gzipped tarballs and Docker

2016-01-08 Thread Jim Jagielski
-0.9... This seems a very heavy solution to a specific one-off problem. > On Jan 8, 2016, at 4:27 AM, Yann Ylavic wrote: > > Hi, > > On Fri, Jan 8, 2016 at 8:49 AM, Jan Kaluža wrote: >> >> Content-Type: application/x-tar >> Content-Encoding: x-gzip

Re: mod_mime_magic, gzipped tarballs and Docker

2016-01-08 Thread William A Rowe Jr
On Fri, Jan 8, 2016 at 3:27 AM, Yann Ylavic wrote: > > On Fri, Jan 8, 2016 at 8:49 AM, Jan Kaluža wrote: > > > > Content-Type: application/x-tar > > Content-Encoding: x-gzip > > > > So, the mod_mime_magic is saying here that the body is tarball encoded

Re: Issues w/ sessions on trunk?

2016-01-08 Thread Paul Spangler
On 1/8/2016 6:49 AM, Jim Jagielski wrote: Just noticed that the test framework reports issues w/ sessions on trunk: t/modules/session.t . 1/105 # Failed test 8 in t/modules/session.t at line 63 fail #2 # Failed test 18 in t/modules/session.t at line 63 fail #4 #

Issues w/ sessions on trunk?

2016-01-08 Thread Jim Jagielski
Just noticed that the test framework reports issues w/ sessions on trunk: t/modules/session.t . 1/105 # Failed test 8 in t/modules/session.t at line 63 fail #2 # Failed test 18 in t/modules/session.t at line 63 fail #4 # Failed test 38 in t/modules/session.t at line 63

Re: svn commit: r1723737 - in /httpd/test/mod_h2/trunk: mh2fuzz/h2c_conn.c mh2fuzz/h2c_session.c test/test_frames.sh

2016-01-08 Thread Mike Rumph
Comment below. On 1/8/2016 7:26 AM, ic...@apache.org wrote: Author: icing Date: Fri Jan 8 15:26:16 2016 New Revision: 1723737 URL: http://svn.apache.org/viewvc?rev=1723737=rev Log: normalized frame output for testing Modified: httpd/test/mod_h2/trunk/mh2fuzz/h2c_conn.c

Re: Issues w/ sessions on trunk?

2016-01-08 Thread Yann Ylavic
Ok, I'll start from there, thanks. On Fri, Jan 8, 2016 at 4:50 PM, Jim Jagielski wrote: > I went ahead and committed what was there and ran tests > to make sure it runs clean before doing so. > >> On Jan 8, 2016, at 10:48 AM, Yann Ylavic wrote: >> >> On

Re: Issues w/ sessions on trunk?

2016-01-08 Thread Jim Jagielski
I went ahead and committed what was there and ran tests to make sure it runs clean before doing so. > On Jan 8, 2016, at 10:48 AM, Yann Ylavic wrote: > > On Fri, Jan 8, 2016 at 3:34 PM, Paul Spangler wrote: >> On 1/8/2016 6:49 AM, Jim Jagielski

Re: mod_mime_magic, gzipped tarballs and Docker

2016-01-08 Thread Yann Ylavic
On Fri, Jan 8, 2016 at 5:30 PM, Yann Ylavic wrote: > On Fri, Jan 8, 2016 at 3:17 PM, William A Rowe Jr wrote: >> >> Agreed it is configuration, but cant we simply tweak our recommended >> conf/magic >> file??? >> >> # standard unix compress >> # Enable

Re: Issues w/ sessions on trunk?

2016-01-08 Thread Jim Jagielski
Yann, will you be doing that? Backporting the tests from: https://bz.apache.org/bugzilla/attachment.cgi?id=33187=diff ??? > On Jan 8, 2016, at 9:34 AM, Paul Spangler wrote: > > On 1/8/2016 6:49 AM, Jim Jagielski wrote: >> Just noticed that the test framework

Re: Work in progress: mod_proxy Health Check module

2016-01-08 Thread Eric Covener
On Fri, Jan 8, 2016 at 10:18 AM, Jim Jagielski wrote: > I am thinking about the actual health-check impl a bit more, > hence the lack of commits. As noted, initially I was thinking > about optional functions, defined in mod_proxy_http, mod_proxy_ajp, > etc. Then I started

Re: mod_mime_magic, gzipped tarballs and Docker

2016-01-08 Thread Jim Jagielski
It just seems like feature-creep and YetAnotherDirective for something that is better handled some other way. As OtherBill notes, a small edit to the magic file "fixes" this. > On Jan 8, 2016, at 11:16 AM, Yann Ylavic wrote: > > On Fri, Jan 8, 2016 at 1:43 PM, Jim

Re: Work in progress: mod_proxy Health Check module

2016-01-08 Thread Jim Jagielski
I am thinking about the actual health-check impl a bit more, hence the lack of commits. As noted, initially I was thinking about optional functions, defined in mod_proxy_http, mod_proxy_ajp, etc. Then I started thinking that maybe doing it via providers might be better, allowing for more "custom"

Re: Issues w/ sessions on trunk?

2016-01-08 Thread Yann Ylavic
On Fri, Jan 8, 2016 at 3:34 PM, Paul Spangler wrote: > On 1/8/2016 6:49 AM, Jim Jagielski wrote: >> >> Just noticed that the test framework reports issues w/ sessions on trunk: >> >> t/modules/session.t . 1/105 # Failed test 8 in >> t/modules/session.t at

mod_index : missing Content-Location header

2016-01-08 Thread Jose Kahan
Hi, Best wishes for 2016! Does anyone know why mod_dir doesn't generate a Content-Location header when a URI ending in "/" is requested? This is a behavior that is common in 2.2 and 2.4. For some publishing tools, it's useful to know what's the actual URI that's mapped to "/" thru

Re: mod_mime_magic, gzipped tarballs and Docker

2016-01-08 Thread Yann Ylavic
On Fri, Jan 8, 2016 at 1:43 PM, Jim Jagielski wrote: > -0.9... > > This seems a very heavy solution to a specific one-off problem. Not sure this is the patch which is heavy here... Anytime mod_mime_magic recognizes the type of a gzip file (by the magic bytes), it

Re: mod_mime_magic, gzipped tarballs and Docker

2016-01-08 Thread Yann Ylavic
On Fri, Jan 8, 2016 at 3:17 PM, William A Rowe Jr wrote: > On Fri, Jan 8, 2016 at 3:27 AM, Yann Ylavic wrote: >> >> >> On Fri, Jan 8, 2016 at 8:49 AM, Jan Kaluža wrote: >> > >> > Content-Type: application/x-tar >> >