Re: svn commit: r1742822 - /httpd/httpd/trunk/modules/http/http_core.c

2016-05-13 Thread Yann Ylavic
On Fri, May 13, 2016 at 7:25 PM, Yann Ylavic wrote: > On Fri, May 13, 2016 at 6:57 PM, Yann Ylavic wrote: >> >> But for the above cases or an error while reading/validating the >> headers or running post_read_request(), we finally call ap_die() or >>

Re: svn commit: r1742822 - /httpd/httpd/trunk/modules/http/http_core.c

2016-05-13 Thread Yann Ylavic
On Fri, May 13, 2016 at 7:25 PM, Yann Ylavic wrote: > +if (r->the_request) { > +access_status = r->status; > +r->status = HTTP_OK; > +ap_update_child_status(conn->sbh, SERVER_BUSY_WRITE, r); > +

Re: svn commit: r1742822 - /httpd/httpd/trunk/modules/http/http_core.c

2016-05-13 Thread Yann Ylavic
On Fri, May 13, 2016 at 6:57 PM, Yann Ylavic wrote: > On Fri, May 13, 2016 at 6:49 PM, William A Rowe Jr > wrote: >> On Fri, May 13, 2016 at 11:41 AM, Yann Ylavic wrote: >>> >>> On Thu, May 12, 2016 at 4:55 PM, William A Rowe Jr

Re: svn commit: r1742822 - /httpd/httpd/trunk/modules/http/http_core.c

2016-05-13 Thread Yann Ylavic
On Fri, May 13, 2016 at 6:49 PM, William A Rowe Jr wrote: > On Fri, May 13, 2016 at 11:41 AM, Yann Ylavic wrote: >> >> On Thu, May 12, 2016 at 4:55 PM, William A Rowe Jr >> wrote: >> > >> > I'd explained in another thread this week

Re: svn commit: r1742822 - /httpd/httpd/trunk/modules/http/http_core.c

2016-05-13 Thread William A Rowe Jr
On Fri, May 13, 2016 at 11:41 AM, Yann Ylavic wrote: > On Thu, May 12, 2016 at 4:55 PM, William A Rowe Jr > wrote: > > > > I'd explained in another thread this week why this patch is invalid, > > and I've gone ahead and reverted. > > > > We agreed

Re: svn commit: r1742822 - /httpd/httpd/trunk/modules/http/http_core.c

2016-05-13 Thread Yann Ylavic
On Thu, May 12, 2016 at 4:55 PM, William A Rowe Jr wrote: > > I'd explained in another thread this week why this patch is invalid, > and I've gone ahead and reverted. > > We agreed there is a defect here, what about the attached fix? Looks good, if something bad happened in

Re: svn commit: r1742822 - /httpd/httpd/trunk/modules/http/http_core.c

2016-05-13 Thread William A Rowe Jr
On Thu, May 12, 2016 at 9:55 AM, William A Rowe Jr wrote: > On Sun, May 8, 2016 at 8:53 AM, wrote: > >> Author: rjung >> Date: Sun May 8 13:53:37 2016 >> New Revision: 1742822 >> >> URL: http://svn.apache.org/viewvc?rev=1742822=rev >> Log: >> Fix yet

Re: Scoreboard 3.0

2016-05-13 Thread William A Rowe Jr
On Fri, May 13, 2016 at 8:34 AM, Eric Covener wrote: > On Wed, May 11, 2016 at 6:39 PM, William A Rowe Jr > wrote: > > In the next iteration for trunk I see a value in having both the basic > > activity flag per worker thread so we can see those states at

Re: Timers and mpm-event

2016-05-13 Thread Stefan Eissing
> Am 13.05.2016 um 16:11 schrieb Eric Covener : > > On Fri, May 13, 2016 at 7:02 AM, Stefan Eissing > wrote: >> That would allow HTTP/2 processing to become fully async and it would no >> longer need its own worker thread pool, at least with

Re: Timers and mpm-event

2016-05-13 Thread Eric Covener
On Fri, May 13, 2016 at 7:02 AM, Stefan Eissing wrote: > That would allow HTTP/2 processing to become fully async and it would no > longer need its own worker thread pool, at least with mpm_event. > > Thoughts? One bit I am still ignorant of is all of the beam-ish

Re: Timers and mpm-event

2016-05-13 Thread Eric Covener
On Fri, May 13, 2016 at 7:02 AM, Stefan Eissing wrote: > 1. Is this ever intended to work on a socket that is a main connection? Since > event itself will add this socket to its pollset now and then, I see a > potential conflict. But that can be resolved, since

Re: Timers and mpm-event

2016-05-13 Thread Stefan Eissing
Hijacking this thread... > Am 13.05.2016 um 15:29 schrieb Eric Covener : > > On Fri, May 13, 2016 at 4:33 AM, Luca Toscano wrote: >> - What does PT_USER represents and how it is used? > > PT_USER is what event tracks when you call >

Re: Scoreboard 3.0

2016-05-13 Thread Eric Covener
On Wed, May 11, 2016 at 6:39 PM, William A Rowe Jr wrote: > In the next iteration for trunk I see a value in having both the basic > activity flag per worker thread so we can see those states at a glance as we > can today, as well as a summary table per process of the number

Re: Timers and mpm-event

2016-05-13 Thread Eric Covener
On Fri, May 13, 2016 at 4:33 AM, Luca Toscano wrote: > - What does PT_USER represents and how it is used? PT_USER is what event tracks when you call event_register_poll_callback(). This callback allows a module to run some code when either of a pair of sockets becomes

Timers and mpm-event

2016-05-13 Thread Luca Toscano
Hi Apache devs, I have some questions about how mpm-event uses timers. If I understood correctly the code, there are two main things that the listener thread cares about: - timeout_queue(s), that represents connections waiting for completion, keep alive or in lingering close. - timer_skiplist,

Re: End of the road of 2.2.x maintenance?

2016-05-13 Thread Noel Butler
On 12/05/2016 05:13, Ruediger Pluem wrote: On 05/10/2016 10:38 PM, William A Rowe Jr wrote: It's been a year, and seems to be a good time to revisit this topic while those folks who are present at ApacheCon can discuss f2f the merits of bringing the 2.2.x chapter to a close, and share their

Re: [PATCH] mod_rewrite: support proxying via mod_proxy_http2

2016-05-13 Thread Evgeny Kotkov
Stefan Eissing writes: > Hmm, can someone with more brains than me on mod_rewrite look at the > first patch if we want to add handling for h2: and h2c: uri schemes > here or if there is a better way? Thanks. In case this will help the review, here are some of the