Re: [PATCH 60223] non-empty OpenSSL error queue preventing non-blocking reads through mod_ssl

2016-11-11 Thread Jacob Champion
On 11/11/2016 11:20 AM, Jacob Champion wrote: I suspect that these failures have nothing to do with this patch, but I just want to confirm that before it goes into trunk. Yeah, the failures show up with or without the patch, so I added a couple comments and committed. The SSL failures in

Re: [PATCH 60223] non-empty OpenSSL error queue preventing non-blocking reads through mod_ssl

2016-11-11 Thread Jacob Champion
On 11/11/2016 10:15 AM, William A Rowe Jr wrote: The patch looks reasonable to me. As you point out, fixing this in APR might be worthwhile, but doesn't protect mod_ssl from other OpenSSL consuming logic such as OpenLDAP auth, database connections or other plug-ins that may leave a lingering

Re: [PATCH 60223] non-empty OpenSSL error queue preventing non-blocking reads through mod_ssl

2016-11-11 Thread William A Rowe Jr
On Fri, Nov 11, 2016 at 9:01 AM, Paul Spangler wrote: > On 10/17/2016 2:04 PM, Paul Spangler wrote: > >> Hello, >> >> Due to the way OpenSSL stores errors in a per-thread queue, functions >> such as SSL_read followed by SSL_get_error may not produce the desired >> result if

Re: mod_ftp segaults on rheloids

2016-11-11 Thread William A Rowe Jr
On Fri, Nov 11, 2016 at 2:24 AM, Benjamin Lefoul wrote: > Is this list still active? > Maybe it was not the right place to ask about mod_ftp? > It is the place to ask, and was on my list to respond to your question... sorry I'm overwhelmed with other code this week.

Re: [PATCH 60223] non-empty OpenSSL error queue preventing non-blocking reads through mod_ssl

2016-11-11 Thread Paul Spangler
On 10/17/2016 2:04 PM, Paul Spangler wrote: Hello, Due to the way OpenSSL stores errors in a per-thread queue, functions such as SSL_read followed by SSL_get_error may not produce the desired result if the error queue is not empty prior to calling SSL_read[1]. For example, a non-blocking read

Re: mod_ftp segaults on rheloids

2016-11-11 Thread Benjamin Lefoul
On Fri, 2016-11-11 at 13:22 +0100, Rainer Canavan wrote: > On Fri, Nov 11, 2016 at 10:27 AM, Benjamin Lefoul > wrote: > >  > > On Fri, 2016-11-11 at 08:53 +, Nick Kew wrote: > > >  > > > Did you build mod_ftp yourself on a distro-provided httpd? > > Yes. I did build

Re: mod_ftp segaults on rheloids

2016-11-11 Thread Benjamin Lefoul
On Fri, 2016-11-11 at 08:53 +, Nick Kew wrote: > On Fri, 2016-11-11 at 08:24 +, Benjamin Lefoul wrote: > > > > Is this list still active? > > Maybe it was not the right place to ask about mod_ftp? > > I guess noone picked up the baton.  Too many blanks to fill. > > Did you build mod_ftp

Re: mod_ftp segaults on rheloids

2016-11-11 Thread Nick Kew
On Fri, 2016-11-11 at 08:24 +, Benjamin Lefoul wrote: > Is this list still active? > Maybe it was not the right place to ask about mod_ftp? I guess noone picked up the baton. Too many blanks to fill. Did you build mod_ftp yourself on a distro-provided httpd? What toolchain did you use for

Re: mod_ftp segaults on rheloids

2016-11-11 Thread Benjamin Lefoul
Is this list still active? Maybe it was not the right place to ask about mod_ftp? Benjamin On Tue, 2016-11-08 at 09:36 +0100, Benjamin Lefoul wrote: > Hi, > > I have built mod_ftp on fresh RHELoids (tried on both CentOS7 and > Scientific Linux 7). > Whether I try the default conf or my own,