Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

2016-12-13 Thread William A Rowe Jr
On Tue, Dec 13, 2016 at 6:42 PM, Yann Ylavic wrote: > On Tue, Dec 13, 2016 at 8:37 PM, Ruediger Pluem wrote: > > > > This change is also unrelated to the bad header issue and I think > > if there is interest to address this it should be done in a

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

2016-12-13 Thread Yann Ylavic
On Tue, Dec 13, 2016 at 8:37 PM, Ruediger Pluem wrote: > > On 12/13/2016 02:49 PM, Yann Ylavic wrote: >> >> The pros with this is indeed the reduced complexity (though the loop >> to walk the brigade already existed), the cons are that we rely on the >> caller/handler to not

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

2016-12-13 Thread Jacob Champion
On 12/13/2016 12:18 PM, Ruediger Pluem wrote: Have a look at line 1334 of mod_proxy_http.c: Okay, that's starting to make some more sense. Thanks! On 12/13/2016 11:37 AM, Ruediger Pluem wrote: After this patch we do the wrong thing with an EOC bucket. The current contract is that an EOC

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

2016-12-13 Thread Ruediger Pluem
On 12/13/2016 08:57 PM, Jacob Champion wrote: > On 12/13/2016 11:37 AM, Ruediger Pluem wrote: >> On 12/13/2016 02:49 PM, Yann Ylavic wrote: >>> I don't find the change too complex after all, and that's a quite >>> critical filter for doing the right/safe thing... >>> >>> I'm even inclined to do

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

2016-12-13 Thread Jacob Champion
On 12/13/2016 11:37 AM, Ruediger Pluem wrote: On 12/13/2016 02:49 PM, Yann Ylavic wrote: I don't find the change too complex after all, and that's a quite critical filter for doing the right/safe thing... I'm even inclined to do the below changes, so that we are really safe (i.e. ignore any

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

2016-12-13 Thread Ruediger Pluem
On 12/13/2016 02:49 PM, Yann Ylavic wrote: > On Tue, Dec 13, 2016 at 10:48 AM, Plüm, Rüdiger, Vodafone Group > wrote: >> Another aspect of all these patches that I don't get is why we need >> to eat the contents of the original brigade? IMHO we don't need to do >>

Re: svn commit: r1774010 - in /httpd/test/framework/trunk/t: conf/extra.conf.in modules/ext_filter.t

2016-12-13 Thread Jim Jagielski
Here is the error-log entry: [Tue Dec 13 10:27:36.041785 2016] [ext_filter:error] [pid 58675:tid 123145321619456] (9)Bad file descriptor: [client 127.0.0.1:63016] AH01464: apr_file_close(child input) [Tue Dec 13 10:27:36.041902 2016] [ext_filter:error] [pid 58675:tid 123145321619456] (9)Bad

Re: svn commit: r1774010 - in /httpd/test/framework/trunk/t: conf/extra.conf.in modules/ext_filter.t

2016-12-13 Thread Jim Jagielski
Confirming that 2.4.x HEAD fails as noted in PR 60375 > On Dec 13, 2016, at 10:14 AM, Jim Jagielski wrote: > > >> On Dec 13, 2016, at 8:33 AM, Jim Jagielski wrote: >> >> This fails on all systems that have sed in /usr/bin/sed >> or someplace other than

Re: svn commit: r1774010 - in /httpd/test/framework/trunk/t: conf/extra.conf.in modules/ext_filter.t

2016-12-13 Thread Jim Jagielski
> On Dec 13, 2016, at 8:33 AM, Jim Jagielski wrote: > > This fails on all systems that have sed in /usr/bin/sed > or someplace other than /bin :( > Hmmm... even w/ the change to /usr/bin/sed I'm getting test #1 failing: t/modules/ext_filter.t .. 1..23 # Running under perl

Re: svn commit: r1774014 - /httpd/httpd/branches/2.4.x/STATUS

2016-12-13 Thread Jim Jagielski
Handled in: Committed revision 1774018. Committed revision 1774019. > On Dec 13, 2016, at 8:57 AM, Eric Covener wrote: > > On Tue, Dec 13, 2016 at 8:54 AM, Marion et Christophe JAILLET > wrote: >> Hi, >> >> >> >> I can't send a patch

Re: svn commit: r1774014 - /httpd/httpd/branches/2.4.x/STATUS

2016-12-13 Thread Eric Covener
On Tue, Dec 13, 2016 at 8:54 AM, Marion et Christophe JAILLET wrote: > Hi, > > > > I can't send a patch because I'm on travel, but there is a minor issue with > r1768245. > > I think that should be or . > > > > I thought I had sent a patch for it, but can find it

re: svn commit: r1774014 - /httpd/httpd/branches/2.4.x/STATUS

2016-12-13 Thread Marion et Christophe JAILLET
Hi,   I can't send a patch because I'm on travel, but there is a minor issue with r1768245. I think that should be or .   I thought I had sent a patch for it, but can find it in SVN history. Maybe, I forgot to commit, or it was for another similar issue in another file.   CJ     >

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

2016-12-13 Thread Yann Ylavic
On Tue, Dec 13, 2016 at 10:48 AM, Plüm, Rüdiger, Vodafone Group wrote: >> >> To clarify: I can't reproduce any problems with r1773861 in the first >> place, even with ErrorDocument. I agree that r1773862 (and r1773865) >> work for me; I just don't know what makes them

Re: svn commit: r1774010 - in /httpd/test/framework/trunk/t: conf/extra.conf.in modules/ext_filter.t

2016-12-13 Thread Jim Jagielski
This fails on all systems that have sed in /usr/bin/sed or someplace other than /bin :( > On Dec 13, 2016, at 8:20 AM, jor...@apache.org wrote: > > Author: jorton > Date: Tue Dec 13 13:20:32 2016 > New Revision: 1774010 > > URL: http://svn.apache.org/viewvc?rev=1774010=rev > Log: > Add basic

AW: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

2016-12-13 Thread Plüm , Rüdiger , Vodafone Group
> -Ursprüngliche Nachricht- > Von: Jacob Champion [mailto:champio...@gmail.com] > Gesendet: Dienstag, 13. Dezember 2016 00:01 > An: dev@httpd.apache.org > Betreff: Re: svn commit: r1773865 - > /httpd/httpd/trunk/modules/http/http_filters.c > > On 12/12/2016 01:23 PM, Yann Ylavic wrote: