Re: Bug in mod_ratelimit?

2018-07-19 Thread Cory McIntire
Hi all, We’re going to revert to the 2.4.33 version of mod_ratelimit for now. HEAD requests with large amount of headers were still problematic in our testing with both versions of the patch applied. Thanks, Cory McIntire Release Manager - EasyApache cPanel, Inc. > On Jul 19, 2018, at 3:36

Re: Bug in mod_ratelimit?

2018-07-19 Thread Yann Ylavic
Hi Luca, On Thu, Jul 19, 2018 at 9:59 PM, Luca Toscano wrote: > > I confirm that it works fine in my local dev environment, plus now gdb's > dump_brigade makes sense, but I am not sure that I have understood what was > wrong. In my tests, the headers were the first heap bucket reported by >

Re: Bug in mod_ratelimit?

2018-07-19 Thread Yann Ylavic
On Thu, Jul 19, 2018 at 10:30 PM, Yann Ylavic wrote: > Hi, > > On Thu, Jul 19, 2018 at 10:16 PM, Cory McIntire wrote: >> >> Upon some initial testing of the patch we have found some conditions to >> which this will still break, consider the following: >> >> Put something like this into your php

Re: Bug in mod_ratelimit?

2018-07-19 Thread Yann Ylavic
Hi, On Thu, Jul 19, 2018 at 10:16 PM, Cory McIntire wrote: > > Upon some initial testing of the patch we have found some conditions to which > this will still break, consider the following: > > Put something like this into your php file, > > for ($i = 1; $i <= 2000; $i++) { >

Re: Bug in mod_ratelimit?

2018-07-19 Thread Cory McIntire
Hello, Upon some initial testing of the patch we have found some conditions to which this will still break, consider the following: Put something like this into your php file, for ($i = 1; $i <= 2000; $i++) { header("x$i: $i"); } Set your rate limit pretty low and

Re: Bug in mod_ratelimit?

2018-07-19 Thread Luca Toscano
Hi Yann, 2018-07-19 21:41 GMT+02:00 Yann Ylavic : > On Thu, Jul 19, 2018 at 8:23 PM, Luca Toscano > wrote: > > > > Yann, any idea? > > Looks like we missed the simplest case :/ > > Index: modules/filters/mod_ratelimit.c > === > ---

Re: Bug in mod_ratelimit?

2018-07-19 Thread Eric Covener
On Thu, Jul 19, 2018 at 3:41 PM Yann Ylavic wrote: > > On Thu, Jul 19, 2018 at 8:23 PM, Luca Toscano wrote: > > > > Yann, any idea? > > Looks like we missed the simplest case :/ > > Index: modules/filters/mod_ratelimit.c > === > ---

Re: Bug in mod_ratelimit?

2018-07-19 Thread Cory McIntire
Hello Yann, We can confirm this patch works on our end. We’ll apply this and send out an update. > On Jul 19, 2018, at 2:41 PM, Yann Ylavic wrote: > > On Thu, Jul 19, 2018 at 8:23 PM, Luca Toscano wrote: >> >> Yann, any idea? > > Looks like we missed the simplest case :/ > > Index:

Re: Bug in mod_ratelimit?

2018-07-19 Thread Yann Ylavic
On Thu, Jul 19, 2018 at 8:23 PM, Luca Toscano wrote: > > Yann, any idea? Looks like we missed the simplest case :/ Index: modules/filters/mod_ratelimit.c === --- modules/filters/mod_ratelimit.c(revision 1835556) +++

Re: Bug in mod_ratelimit?

2018-07-19 Thread Eric Covener
On Thu, Jul 19, 2018 at 2:23 PM Luca Toscano wrote: > > Hi again Cory, > > 2018-07-19 19:02 GMT+02:00 Cory McIntire : >> >> Hi Luca, >> >> Sorry for quick reply but we were able to replicate it just now: >> >> # setup a brand new install of wp on a domain (don't have to go through the >> 'db'

Re: Regression with CMake Windows builds, 2.4.29 is the last one passing

2018-07-19 Thread William A Rowe Jr
FWIW, the correct fix seems to be to fix the regression in http://svn.apache.org/viewvc?rev=1832609=rev rather than the windows build. On Thu, Jul 19, 2018, 13:18 William A Rowe Jr wrote: > Hi Michal, thanks for your report. > > On Thu, Jul 19, 2018 at 10:36 AM, Michal Karm > wrote: > >> Hi

Re: Bug in mod_ratelimit?

2018-07-19 Thread Luca Toscano
Hi again Cory, 2018-07-19 19:02 GMT+02:00 Cory McIntire : > Hi Luca, > > Sorry for quick reply but we were able to replicate it just now: > > # setup a brand new install of wp on a domain (don't have to go through > the 'db' setup process, just configure wp-config.php to get to install.php >

Re: Regression with CMake Windows builds, 2.4.29 is the last one passing

2018-07-19 Thread William A Rowe Jr
Hi Michal, thanks for your report. On Thu, Jul 19, 2018 at 10:36 AM, Michal Karm wrote: > Hi guys, > > I would like to ask whether there are any plans on > accepting [1] patch to 2.4.x as it keeps failing the CMake Windows build. > > Furthermore, there is a regression [2] in 2.4.34 CMake

Re: Apache2 mod_http2 segfault

2018-07-19 Thread William A Rowe Jr
This came up on another channel, but seems to be general interest; On Thu, Jul 19, 2018 at 12:18 PM, William A Rowe Jr wrote: > > I'm at a loss to point to the canonical list of experimental components. > Is this it? Are there another authoritative list for 2.4.35-dev? $ grep "Experimental"

Re: Bug in mod_ratelimit?

2018-07-19 Thread Cory McIntire
Hi Luca, Sorry for quick reply but we were able to replicate it just now: # setup a brand new install of wp on a domain (don't have to go through the 'db' setup process, just configure wp-config.php to get to install.php redirect) # install mod_ratelimit, and setup a vhost.conf with the

Re: Bug in mod_ratelimit?

2018-07-19 Thread Cory McIntire
Hi Luca, So far we’ve not seen much in the logs of our customer reports, however I was able to get the following settings: SetOutputFilter RATE_LIMIT SetEnv rate-limit 512 SetEnv rate-initial-burst 625 When removed/commented out and/or removing mod_ratelimit the site would begin to work

Regression with CMake Windows builds, 2.4.29 is the last one passing

2018-07-19 Thread Michal Karm
Hi guys, I would like to ask whether there are any plans on accepting [1] patch to 2.4.x as it keeps failing the CMake Windows build. Furthermore, there is a regression [2] in 2.4.34 CMake Windows build that did not exist in 2.4.29. If anyone has a hit or an idea handy to get me unstuck I try

Re: Bug in mod_ratelimit?

2018-07-19 Thread Luca Toscano
Hi Cory, 2018-07-19 16:10 GMT+02:00 Cory McIntire : > Hello all, > > We’re starting to see some issues where mod_ratelimit change here: > > *) mod_ratelimit: fix behavior when proxing content. PR 62362. > [Luca Toscano, Yann Ylavic] > > Is causing some sites to load in plain text/source

Bug in mod_ratelimit?

2018-07-19 Thread Cory McIntire
Hello all, We’re starting to see some issues where mod_ratelimit change here: *) mod_ratelimit: fix behavior when proxing content. PR 62362. [Luca Toscano, Yann Ylavic] Is causing some sites to load in plain text/source code… We haven’t found the connection beyond unloading

AW: ocsp_force_default initialized with UNSET in httpd 2.4.34

2018-07-19 Thread Plüm , Rüdiger , Vodafone Group
I can do tomorrow and make a proposal in STATUS. Looks like we are all aligned now how to resolve this. Regards Rüdiger > -Ursprüngliche Nachricht- > Von: Stefan Eissing > Gesendet: Donnerstag, 19. Juli 2018 11:10 > An: dev@httpd.apache.org > Betreff: Re: ocsp_force_default

Re: ocsp_force_default initialized with UNSET in httpd 2.4.34

2018-07-19 Thread Stefan Eissing
You'll take care of it, Rüdiger? > Am 18.07.2018 um 13:57 schrieb Ruediger Pluem : > > > > On 07/18/2018 11:44 AM, Stefan Eissing wrote: >>> Am 18.07.2018 um 11:37 schrieb Yann Ylavic : >>> >>> On Wed, Jul 18, 2018 at 11:29 AM, Ruediger Pluem wrote: Good catch. Maybe a dirty

Re: svn commit: r1836237 - in /httpd/httpd/trunk: modules/ssl/ssl_engine_io.c server/core_filters.c server/util_filter.c

2018-07-19 Thread Yann Ylavic
On Thu, Jul 19, 2018 at 4:29 AM, Eric Covener wrote: >> +static APR_INLINE int is_in_memory_bucket(apr_bucket *b) >> +{ >> +/* The bucket data are already in memory unless: >> + * - it's a morphing bucket (heap buffers allocated on read), or >> + * - it's a file bucket (heap