Re: ApacheCon call for presentations, httpd content

2019-05-09 Thread Jim Jagielski
I can always do my "httpd 2.4 overview" as well as my "httpd 2.4 reverse proxy" talk. > On May 2, 2019, at 10:39 AM, Daniel Ruggeri wrote: > > Hi, Rich; > I was looking at the CFP and didn't quite see something that aligns with > httpd. These are the categories allowed: > General >

Re: eor bucket

2019-05-09 Thread Stefan Eissing
Thanks, Yann. Just proposed these for backport. > Am 09.05.2019 um 12:04 schrieb Yann Ylavic : > > r1707362

AW: eor bucket

2019-05-09 Thread Plüm , Rüdiger , Vodafone Group
C2 General > -Ursprüngliche Nachricht- > Von: Yann Ylavic > Gesendet: Donnerstag, 9. Mai 2019 12:00 > An: httpd-dev > Betreff: Re: eor bucket > > On Thu, May 9, 2019 at 11:54 AM Yann Ylavic > wrote: > > > > On Thu, May 9, 2019 at 11:37 AM Stefan Eissing > > wrote: > > > > > > > Am

AW: eor bucket

2019-05-09 Thread Plüm , Rüdiger , Vodafone Group
C2 General > -Ursprüngliche Nachricht- > Von: Yann Ylavic > Gesendet: Donnerstag, 9. Mai 2019 11:54 > An: httpd-dev > Betreff: Re: eor bucket > > On Thu, May 9, 2019 at 11:37 AM Stefan Eissing > wrote: > > > > > Am 09.05.2019 um 11:32 schrieb Yann Ylavic : > > > > > > The issue is

Re: eor bucket

2019-05-09 Thread Yann Ylavic
On Thu, May 9, 2019 at 12:00 PM Yann Ylavic wrote: > > On Thu, May 9, 2019 at 11:54 AM Yann Ylavic wrote: > > > > On Thu, May 9, 2019 at 11:37 AM Stefan Eissing > > wrote: > > > > > > > Am 09.05.2019 um 11:32 schrieb Yann Ylavic : > > > > > > > > The issue is more that the hooks in

Re: eor bucket

2019-05-09 Thread Yann Ylavic
On Thu, May 9, 2019 at 11:54 AM Yann Ylavic wrote: > > On Thu, May 9, 2019 at 11:37 AM Stefan Eissing > wrote: > > > > > Am 09.05.2019 um 11:32 schrieb Yann Ylavic : > > > > > > The issue is more that the hooks in eor_bucket_cleanup() will be run > > > multiple times, rather than a lifetime

Re: eor bucket

2019-05-09 Thread Yann Ylavic
On Thu, May 9, 2019 at 11:37 AM Stefan Eissing wrote: > > > Am 09.05.2019 um 11:32 schrieb Yann Ylavic : > > > > The issue is more that the hooks in eor_bucket_cleanup() will be run > > multiple times, rather than a lifetime issue. > > I read it like this: > The cleanup is only registered on the

Re: eor bucket

2019-05-09 Thread Stefan Eissing
> Am 09.05.2019 um 11:32 schrieb Yann Ylavic : > > The issue is more that the hooks in eor_bucket_cleanup() will be run > multiple times, rather than a lifetime issue. I read it like this: The cleanup is only registered on the first creation. The copy never registers. But the bucket_destroy

Re: eor bucket

2019-05-09 Thread Yann Ylavic
The issue is more that the hooks in eor_bucket_cleanup() will be run multiple times, rather than a lifetime issue. On Thu, May 9, 2019 at 11:28 AM Yann Ylavic wrote: > > No it's not actually, nevermind. > > On Thu, May 9, 2019 at 11:24 AM Yann Ylavic wrote: > > > > Hmm, if r->pool gets

Re: eor bucket

2019-05-09 Thread Stefan Eissing
> Am 09.05.2019 um 11:28 schrieb Yann Ylavic : > > No it's not actually, nevermind. Yeah, I was going back and forth like that myself. Therefore my question. ;) I am seeing in an uncomitted change a rare occasion where eor_bucket_destroy() seems to destroy a pool twice. If that is related

Re: eor bucket

2019-05-09 Thread Yann Ylavic
No it's not actually, nevermind. On Thu, May 9, 2019 at 11:24 AM Yann Ylavic wrote: > > Hmm, if r->pool gets destroyed by the first eor, the > eor_bucket_cleanup() for the copy should NULLify its b->data at the > same time, so it should be safe no? > > On Thu, May 9, 2019 at 11:22 AM Plüm,

Re: eor bucket

2019-05-09 Thread Yann Ylavic
Hmm, if r->pool gets destroyed by the first eor, the eor_bucket_cleanup() for the copy should NULLify its b->data at the same time, so it should be safe no? On Thu, May 9, 2019 at 11:22 AM Plüm, Rüdiger, Vodafone Group wrote: > > I think your understanding is correct. > > Regards > > Rüdiger > >

AW: eor bucket

2019-05-09 Thread Plüm , Rüdiger , Vodafone Group
I think your understanding is correct. Regards Rüdiger C2 General > -Ursprüngliche Nachricht- > Von: Stefan Eissing > Gesendet: Donnerstag, 9. Mai 2019 11:02 > An: dev@httpd.apache.org > Betreff: eor bucket > > Could someone help me to check my understanding of the eor bucket >

eor bucket

2019-05-09 Thread Stefan Eissing
Could someone help me to check my understanding of the eor bucket implementation? If an eor bucket is ever copied, there are 2 buckets with their b->data pointing to the request_rec. Since this is local to the bucket, destroying these 2 will call apr_pool_destroy() twice on the pool. Correct?