Re: svn commit: r1874775 - /httpd/httpd/trunk/test/README.travis

2020-03-23 Thread Graham Leggett
On 23 Mar 2020, at 14:53, Ruediger Pluem wrote: > To sum it up: > > ap_request_core_filter might setaside an EOR and data before this and return, That’s normal. The core supports pipelining, meaning multiple requests, and therefore multiple EOR buckets can be lined up inside the core network

Re: Use of [skip ci] in commit messages to avoid Travis builds

2020-03-23 Thread Rainer Jung
Am 23.03.2020 um 20:12 schrieb Ruediger Pluem: On 3/23/20 6:22 PM, Rainer Jung wrote: Am 23.03.2020 um 16:56 schrieb Joe Orton: On Sat, Feb 08, 2020 at 12:01:29PM +0100, Luca Toscano wrote: Hi everybody, Travis is able to read commit messages and skip the CI workflow if the "[skip ci]"

Re: Use of [skip ci] in commit messages to avoid Travis builds

2020-03-23 Thread Ruediger Pluem
On 3/23/20 6:22 PM, Rainer Jung wrote: > Am 23.03.2020 um 16:56 schrieb Joe Orton: >> On Sat, Feb 08, 2020 at 12:01:29PM +0100, Luca Toscano wrote: >>> Hi everybody, >>> >>> Travis is able to read commit messages and skip the CI workflow if the >>> "[skip ci]" magic sequence is added somewhere.

Re: [VOTE] Release httpd-2.4.42

2020-03-23 Thread Yann Ylavic
On Mon, Mar 23, 2020 at 5:31 PM Christophe JAILLET wrote: > > Proposal made in r1875516 would also be nice to have in the next release > if a few of us have the knowledge and time to test and vote. Backported now ;) Regards, Yann.

Re: svn commit: r1875544 - /httpd/httpd/trunk/modules/ssl/ssl_engine_kernel.c

2020-03-23 Thread Yann Ylavic
On Mon, Mar 23, 2020 at 4:21 PM Rainer Jung wrote: > > Thanks for the feedback. Proposed for 2.4.x a minute ago. Thanks Rainer, backported now. Regards, Yann.

Re: svn commit: r1875544 - /httpd/httpd/trunk/modules/ssl/ssl_engine_kernel.c

2020-03-23 Thread Yann Ylavic
On Mon, Mar 23, 2020 at 6:11 PM Ruediger Pluem wrote: > > On 3/23/20 2:48 PM, Ruediger Pluem wrote: > > > > > > On 3/23/20 2:44 PM, Rainer Jung wrote: > >> The dependency on SSL_CTX_get_min_proto_version() and > >> SSL_CTX_get_max_proto_version() was introduced in October by Yann's > >>

Re: Use of [skip ci] in commit messages to avoid Travis builds

2020-03-23 Thread Rainer Jung
Am 23.03.2020 um 16:56 schrieb Joe Orton: On Sat, Feb 08, 2020 at 12:01:29PM +0100, Luca Toscano wrote: Hi everybody, Travis is able to read commit messages and skip the CI workflow if the "[skip ci]" magic sequence is added somewhere. I keep forgetting about it too, but it would be nice if we

Re: [VOTE] Release httpd-2.4.42

2020-03-23 Thread Gregg Smith
On 3/23/2020 8:18 AM, Daniel Ruggeri wrote: Hi, all;    Per the issues surfaced/fixed, I'll go ahead and declare this release as dead-on-the vine. I'll target another T later this week, hopefully after the discussion around OpenSSL versioning plays out.    How about Thursday? +1

Re: svn commit: r1875544 - /httpd/httpd/trunk/modules/ssl/ssl_engine_kernel.c

2020-03-23 Thread Ruediger Pluem
On 3/23/20 2:48 PM, Ruediger Pluem wrote: > > > On 3/23/20 2:44 PM, Rainer Jung wrote: >> The dependency on SSL_CTX_get_min_proto_version() and >> SSL_CTX_get_max_proto_version() was introduced in October by Yann's >> "r1868645 mod_ssl: negotiate the TLS protocol version per name based vhost

Re: [VOTE] Release httpd-2.4.42

2020-03-23 Thread Christophe JAILLET
Le 23/03/2020 à 16:18, Daniel Ruggeri a écrit : Hi, all;    Per the issues surfaced/fixed, I'll go ahead and declare this release as dead-on-the vine. I'll target another T later this week, hopefully after the discussion around OpenSSL versioning plays out.    How about Thursday? Hi,

Re: Use of [skip ci] in commit messages to avoid Travis builds

2020-03-23 Thread Joe Orton
On Sat, Feb 08, 2020 at 12:01:29PM +0100, Luca Toscano wrote: > Hi everybody, > > Travis is able to read commit messages and skip the CI workflow if the > "[skip ci]" magic sequence is added somewhere. I keep forgetting about > it too, but it would be nice if we could start using it to avoid

Re: [VOTE] Release httpd-2.4.42

2020-03-23 Thread Rainer Jung
Am 23.03.2020 um 16:18 schrieb Daniel Ruggeri: Hi, all;    Per the issues surfaced/fixed, I'll go ahead and declare this release as dead-on-the vine. I'll target another T later this week, hopefully after the discussion around OpenSSL versioning plays out.    How about Thursday? Works for

Re: svn commit: r1875544 - /httpd/httpd/trunk/modules/ssl/ssl_engine_kernel.c

2020-03-23 Thread Rainer Jung
Thanks for the feedback. Proposed for 2.4.x a minute ago. Am 23.03.2020 um 14:48 schrieb Ruediger Pluem: On 3/23/20 2:44 PM, Rainer Jung wrote: The dependency on SSL_CTX_get_min_proto_version() and SSL_CTX_get_max_proto_version() was introduced in October by Yann's "r1868645 mod_ssl:

Re: [VOTE] Release httpd-2.4.42

2020-03-23 Thread Daniel Ruggeri
Hi, all;    Per the issues surfaced/fixed, I'll go ahead and declare this release as dead-on-the vine. I'll target another T later this week, hopefully after the discussion around OpenSSL versioning plays out.    How about Thursday? -- Daniel Ruggeri On 3/19/2020 9:45 AM, Daniel Ruggeri wrote:

Re: svn commit: r1875544 - /httpd/httpd/trunk/modules/ssl/ssl_engine_kernel.c

2020-03-23 Thread Ruediger Pluem
On 3/23/20 2:44 PM, Rainer Jung wrote: > The dependency on SSL_CTX_get_min_proto_version() and > SSL_CTX_get_max_proto_version() was introduced in October by Yann's > "r1868645 mod_ssl: negotiate the TLS protocol version per name based vhost > configuration". > > Although the set variants

Re: svn commit: r1875544 - /httpd/httpd/trunk/modules/ssl/ssl_engine_kernel.c

2020-03-23 Thread Rainer Jung
The dependency on SSL_CTX_get_min_proto_version() and SSL_CTX_get_max_proto_version() was introduced in October by Yann's "r1868645 mod_ssl: negotiate the TLS protocol version per name based vhost configuration". Although the set variants are available in 1.1.0, the set were added later in

Re: svn commit: r1874775 - /httpd/httpd/trunk/test/README.travis

2020-03-23 Thread Ruediger Pluem
On 3/23/20 11:32 AM, Graham Leggett wrote: > On 23 Mar 2020, at 09:40, Ruediger Pluem > wrote: > >> In short: The async filter code currently corrupts responses in certain >> situations. For the whole story please look here: >> >>

Re: [VOTE] Release httpd-2.4.42

2020-03-23 Thread Jim Jagielski
Based on this, I change my vote to -1 > On Mar 19, 2020, at 11:19 AM, Eric Covener wrote: > > On Thu, Mar 19, 2020 at 10:45 AM Daniel Ruggeri > wrote: >> >> Hi, all; >>Please find below the proposed release tarball and signatures: >>

Re: svn commit: r1874775 - /httpd/httpd/trunk/test/README.travis

2020-03-23 Thread Graham Leggett
On 23 Mar 2020, at 09:40, Ruediger Pluem wrote: > In short: The async filter code currently corrupts responses in certain > situations. For the whole story please look here: > >

Re: worker MPM test failures (was Re: Still Failing: apache/httpd#190 (trunk - 894b6a1))

2020-03-23 Thread Ruediger Pluem
On 3/22/20 6:43 PM, Yann Ylavic wrote: > +APR_BRIGADE_INSERT_TAIL(ctx->tmp_bb, bucket); > +if (do_pass > +|| APR_BRIGADE_EMPTY(ctx->bb) > +|| (bucket->length == (apr_size_t)-1) How can we have a bucket length of -1 here? What about flush buckets?

Re: svn commit: r1874775 - /httpd/httpd/trunk/test/README.travis

2020-03-23 Thread Ruediger Pluem
On 3/23/20 1:49 AM, Graham Leggett wrote: > On 06 Mar 2020, at 10:30, Ruediger Pluem wrote: > >> Anyone found time to check >> >> https://github.com/apache/httpd/pull/88 >> >> regarding the async filter bug? > > Do these PRs come through on a mailing list anywhere? If there is no >