On 12/20/23 21:22, Jim Jagielski wrote:
I'll have to go back through my notes... I do recall adding fields that although
were not being used at the time, were _going to be used_ as some point, and
I didn't want to have to worry about ABI compatibility.
Cool I will wait before implementing
I'll have to go back through my notes... I do recall adding fields that although
were not being used at the time, were _going to be used_ as some point, and
I didn't want to have to worry about ABI compatibility.
> On Dec 14, 2023, at 8:27 AM, jean-frederic clere wrote:
>
> Hi,
>
> Any
On Wed, 20 Dec 2023, 16:30 Yann Ylavic, wrote:
> On Wed, Dec 20, 2023 at 5:20 PM Yann Ylavic wrote:
> >
> > On Wed, Dec 20, 2023 at 4:56 PM wrote:
> > >
> > > Author: jorton
> > > Date: Wed Dec 20 15:56:15 2023
> > > New Revision: 1914804
> > >
> > > URL:
On Wed, Dec 20, 2023 at 5:20 PM Yann Ylavic wrote:
>
> On Wed, Dec 20, 2023 at 4:56 PM wrote:
> >
> > Author: jorton
> > Date: Wed Dec 20 15:56:15 2023
> > New Revision: 1914804
> >
> > URL: http://svn.apache.org/viewvc?rev=1914804=rev
> > Log:
> > * modules/http/chunk_filter.c
On Wed, Dec 20, 2023 at 4:56 PM wrote:
>
> Author: jorton
> Date: Wed Dec 20 15:56:15 2023
> New Revision: 1914804
>
> URL: http://svn.apache.org/viewvc?rev=1914804=rev
> Log:
> * modules/http/chunk_filter.c (ap_http_chunk_filter): For a brigade
> containing [FLUSH EOS], insert the last-chunk
On Wed, Dec 20, 2023 at 10:58 AM Joe Orton wrote:
>
> On Wed, Dec 20, 2023 at 04:24:32PM +0100, Ruediger Pluem wrote:
> > On 12/20/23 4:08 PM, Yann Ylavic wrote:
> > > On Wed, Dec 20, 2023 at 2:40 PM Joe Orton wrote:
> > >> https://github.com/apache/httpd/pull/400
> > >
> > > Thanks, looks good
On Wed, Dec 20, 2023 at 4:57 PM Joe Orton wrote:
>
> On Wed, Dec 20, 2023 at 04:24:32PM +0100, Ruediger Pluem wrote:
> > On 12/20/23 4:08 PM, Yann Ylavic wrote:
> > > On Wed, Dec 20, 2023 at 2:40 PM Joe Orton wrote:
> > >> https://github.com/apache/httpd/pull/400
> > >
> > > Thanks, looks good
On Wed, Dec 20, 2023 at 10:43 AM Joe Orton wrote:
>
> In the repro case you posted, only one brigade is passed by the handler,
> with that I saw the "delayed last chunk" behaviour but not the Zlib
> double-deinit error log. I think the Zlib error would only be triggered
> by passing a second
On Wed, Dec 20, 2023 at 4:45 PM Yann Ylavic wrote:
>
> On Wed, Dec 20, 2023 at 4:18 PM Eric Norris wrote:
> >
> > On Wed, Dec 20, 2023 at 10:09 AM Yann Ylavic wrote:
> > >
> > > So I think what the POC or mod_php should be doing is [FLUSH EOS] or
> > > something might not work in the chain
On Wed, Dec 20, 2023 at 04:24:32PM +0100, Ruediger Pluem wrote:
> On 12/20/23 4:08 PM, Yann Ylavic wrote:
> > On Wed, Dec 20, 2023 at 2:40 PM Joe Orton wrote:
> >> https://github.com/apache/httpd/pull/400
> >
> > Thanks, looks good to me.
>
> +1
Thanks a lot for the quick reviews. Merged in
On Wed, Dec 20, 2023 at 4:18 PM Eric Norris wrote:
>
> On Wed, Dec 20, 2023 at 10:09 AM Yann Ylavic wrote:
> >
> > So I think what the POC or mod_php should be doing is [FLUSH EOS] or
> > something might not work in the chain sooner or later?
>
> I believe that is what the POC was doing here
>
On Wed, Dec 20, 2023 at 10:07:19AM -0500, Eric Norris via dev wrote:
> Thanks Joe, and no need to apologize, that's totally understandable.
>
> I also appreciate you taking a look at the chunk filter behavior as that
> was actually going to be the next patch I proposed. I had written it here:
>
On 12/20/23 4:08 PM, Yann Ylavic wrote:
> On Wed, Dec 20, 2023 at 2:40 PM Joe Orton wrote:
>>
>> I was surprised this made a difference to the behaviour on the wire. It
>> seems like the chunk filter has suboptimal behaviour here. If you take
>> an output brigade like either:
>>
>> a) [HEAP
On Wed, Dec 20, 2023 at 10:09 AM Yann Ylavic wrote:
>
> On Wed, Dec 20, 2023 at 2:40 PM Joe Orton wrote:
> >
> > I was surprised this made a difference to the behaviour on the wire. It
> > seems like the chunk filter has suboptimal behaviour here. If you take
> > an output brigade like either:
>
On Wed, Dec 20, 2023 at 2:40 PM Joe Orton wrote:
>
> I was surprised this made a difference to the behaviour on the wire. It
> seems like the chunk filter has suboptimal behaviour here. If you take
> an output brigade like either:
>
> a) [HEAP FLUSH EOS]
> b) [HEAP FLUSH EOS FLUSH]
>
> in both
Thanks Joe, and no need to apologize, that's totally understandable.
I also appreciate you taking a look at the chunk filter behavior as that
was actually going to be the next patch I proposed. I had written it here:
On Mon, Oct 30, 2023 at 10:47:44AM -0400, Eric Norris via dev wrote:
> Hello again,
>
> I'd like to politely bump this message to see if anyone would mind
> taking a look at this patch, either here or on GitHub.
Apologies, I got quite distracted by the "rapid reset" security stuff
earlier in
17 matches
Mail list logo
