Re: [PATCH] ap_socache.h mod_socache_*

2008-04-08 Thread Graham Leggett
Joe Orton wrote: I think it's appropriate that the smallness is brought out: 1) the fact that some providers (shmcb, memcache at least) have fixed size limits means any consumer must be designed to cope with that, 2) for a cache which could store arbitrarily large objects, you'd want a

Re: [PATCH] ap_socache.h mod_socache_*

2008-03-07 Thread Chris Darroch
Hi -- With those thoughts in mind, some other possible names presented themselves -- perhaps grouped under modules/foo, where foo is the name of choice? I thought of map, dict, store, table, and hash, possibly with a d (data, distributed) or s (shared) prefix, e.g., mod_dtable,

Re: [PATCH] ap_socache.h mod_socache_*

2008-03-06 Thread Chris Darroch
Hi -- This looks great! Some semi-random thoughts, dealing just with the main header file. I was a little puzzled by the name socache because I assumed so meant shared object, like mod_so, until I read the code comments. I wondered if it was true that people would only use this kind of

Re: [PATCH] ap_socache.h mod_socache_*

2008-03-06 Thread Vincent Bray
On 06/03/2008, Chris Darroch [EMAIL PROTECTED] wrote: I was a little puzzled by the name socache because I assumed so meant shared object, like mod_so, until I read the code comments. I wondered if it was true that people would only use this kind of interface to store small objects -- I

Re: [PATCH] ap_socache.h mod_socache_*

2008-03-05 Thread Plüm , Rüdiger , VF-Group
-Ursprüngliche Nachricht- Von: Paul Querna Gesendet: Mittwoch, 5. März 2008 04:39 An: dev@httpd.apache.org Betreff: Re: [PATCH] ap_socache.h mod_socache_* [Patch shows diffs relative to original ssl_scache_* for the providers] Does it make sense to do

Re: [PATCH] ap_socache.h mod_socache_*

2008-03-05 Thread Joe Orton
On Wed, Mar 05, 2008 at 09:32:54AM +0100, Plüm, Rüdiger, VF-Group wrote: [Patch shows diffs relative to original ssl_scache_* for the providers] Does it make sense to do this in a branch in subversion? Not sure if this is needed as Joe has already done a lot of the redesign work in

[PATCH] ap_socache.h mod_socache_*

2008-03-04 Thread Joe Orton
The cleanest and simplest way to extract the session cache providers from mod_ssl seems to be like this: 1) define the provider vtable structure in a header, ap_socache.h 2) implement all the provider backends in separate modules, mod_socache_* There's no central registration of new backends

Re: [PATCH] ap_socache.h mod_socache_*

2008-03-04 Thread Paul Querna
Joe Orton wrote: The cleanest and simplest way to extract the session cache providers from mod_ssl seems to be like this: 1) define the provider vtable structure in a header, ap_socache.h 2) implement all the provider backends in separate modules, mod_socache_* There's no central