[mod_lua] bytecode caching

2009-02-05 Thread Brian McCallister
It looks like fields were added to apl_vm_spec to allow for bytecode caching on the actual spec. I think this is a bad idea. Specs are short-lived, typically stack-allocated, structs which exist to group a bunch of arguments together. If we choose to re-enable bytecode caching in mod_lua, it

Re: [mod_lua] bytecode caching

2009-02-05 Thread Brian McCallister
On Thu, Feb 5, 2009 at 9:21 PM, Brian McCallister bri...@skife.org wrote: It looks like fields were added to apl_vm_spec to allow for bytecode caching on the actual spec. I think this is a bad idea. Specs are short-lived, typically stack-allocated, structs which exist to group a bunch of

Re: [mod_lua] bytecode caching

2009-02-05 Thread Brian McCallister
On Thu, Feb 5, 2009 at 9:39 PM, Brian McCallister bri...@skife.org wrote: I can see how this fits with the spec, but I'd still prefer to find a different way to pass that information. One way, though I do not like it much more, is to pass the bytecode in as the filename and look for lua