Re: Behaviour of mod_proxy_ajp if CPING/CPONG fails

2008-09-08 Thread Jim Jagielski
IMO, the suggested patch does what it's supposed to do and doesn't cause any regressions. As such, +1 for folding into trunk.

Re: Behaviour of mod_proxy_ajp if CPING/CPONG fails

2008-09-07 Thread Rainer Jung
Ruediger Pluem schrieb: On 09/06/2008 10:54 PM, Rainer Jung wrote: Rüdiger Plüm schrieb: On 09/05/2008 06:21 PM, Mladen Turk wrote: Plüm, Rüdiger, VF-Group wrote: while (apr_proxy_acguire_connection) { fresh = 0 if (conn-sock == NULL) { fresh = 1 }

Re: Behaviour of mod_proxy_ajp if CPING/CPONG fails

2008-09-06 Thread Rainer Jung
Rüdiger Plüm schrieb: On 09/05/2008 06:21 PM, Mladen Turk wrote: Plüm, Rüdiger, VF-Group wrote: +1 for the concept. However for threaded servers you should call ap_proxy_acquire_connection inside retry loop, cause there might be available connections inside the pool. I don't think

Re: Behaviour of mod_proxy_ajp if CPING/CPONG fails

2008-09-06 Thread Ruediger Pluem
On 09/06/2008 10:54 PM, Rainer Jung wrote: Rüdiger Plüm schrieb: On 09/05/2008 06:21 PM, Mladen Turk wrote: Plüm, Rüdiger, VF-Group wrote: while (apr_proxy_acguire_connection) { fresh = 0 if (conn-sock == NULL) { fresh = 1 } ap_proxy_determine_connection

Behaviour of mod_proxy_ajp if CPING/CPONG fails

2008-09-05 Thread Plüm, Rüdiger, VF-Group
IMHO the current behaviour of mod_proxy_ajp is not correct if a CPING/CPONG fails on a backend connection. In this case the status is set to HTTP_SERVICE_UNAVAILABLE and the scheme handler returns. In the case of an unbalanced backend this results in a HTTP_SERVICE_UNAVAILABLE (503) to be

Re: Behaviour of mod_proxy_ajp if CPING/CPONG fails

2008-09-05 Thread Mladen Turk
Plüm, Rüdiger, VF-Group wrote: So after the first failed CPING/CPONG we should try again with a new TCP connection and should only return HTTP_SERVICE_UNAVAILABLE if this fails as well. The following (and attached patch) does exactly that. Thoughs to the above and/or to the patch before I

Re: Behaviour of mod_proxy_ajp if CPING/CPONG fails

2008-09-05 Thread Plüm, Rüdiger, VF-Group
-Ursprüngliche Nachricht- Von: Mladen Turk Gesendet: Freitag, 5. September 2008 17:07 An: dev@httpd.apache.org Betreff: Re: Behaviour of mod_proxy_ajp if CPING/CPONG fails Plüm, Rüdiger, VF-Group wrote: So after the first failed CPING/CPONG we should try again with a new

Re: Behaviour of mod_proxy_ajp if CPING/CPONG fails

2008-09-05 Thread Mladen Turk
Plüm, Rüdiger, VF-Group wrote: +1 for the concept. However for threaded servers you should call ap_proxy_acquire_connection inside retry loop, cause there might be available connections inside the pool. I don't think that this does what you want. If I simply continue to acquire connections

Re: Behaviour of mod_proxy_ajp if CPING/CPONG fails

2008-09-05 Thread Jim Jagielski
On Sep 5, 2008, at 10:21 AM, Plüm, Rüdiger, VF-Group wrote: IMHO the current behaviour of mod_proxy_ajp is not correct if a CPING/CPONG fails on a backend connection. In this case the status is set to HTTP_SERVICE_UNAVAILABLE and the scheme handler returns. In the case of an unbalanced

Re: Behaviour of mod_proxy_ajp if CPING/CPONG fails

2008-09-05 Thread Rüdiger Plüm
On 09/05/2008 06:21 PM, Mladen Turk wrote: Plüm, Rüdiger, VF-Group wrote: +1 for the concept. However for threaded servers you should call ap_proxy_acquire_connection inside retry loop, cause there might be available connections inside the pool. I don't think that this does what you