Re: PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-25 Thread Jim Jagielski
: PR 58267: Regression in 2.2.31 caused by r1680920 Thanks for the pointer. It is missing because I removed it by accident when excluding some debug code I setup locally for analysing the issue from the patch I posted. I will post a proper version and if you agree put it in STATUS for 2.2.x

RE: PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-25 Thread Plüm , Rüdiger , Vodafone Group
, 25. August 2015 10:23 To: dev@httpd.apache.org Subject: Re: PR 58267: Regression in 2.2.31 caused by r1680920 On 08/24/2015 11:12 PM, Yann Ylavic wrote: On Mon, Aug 24, 2015 at 5:51 PM, Yann Ylavic ylavic@gmail.com wrote: On Mon, Aug 24, 2015 at 4:47 PM, Jan Kaluža jkal...@redhat.com

Re: PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-25 Thread Jan Kaluža
On 08/24/2015 11:12 PM, Yann Ylavic wrote: On Mon, Aug 24, 2015 at 5:51 PM, Yann Ylavic ylavic@gmail.com wrote: On Mon, Aug 24, 2015 at 4:47 PM, Jan Kaluža jkal...@redhat.com wrote: 2) Increment proxy_lb_workers according to number of workers in balancer when using ProxyPass /foobar/

Re: PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-25 Thread Yann Ylavic
On Tue, Aug 25, 2015 at 10:22 AM, Jan Kaluža jkal...@redhat.com wrote: On 08/24/2015 11:12 PM, Yann Ylavic wrote: I tested the below which seems to work. Hm, this reserves the slots in scoreboard even when the balancers are not used in the virtualhost, or am I wrong? Correct, but there

RE: PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-25 Thread Plüm , Rüdiger , Vodafone Group
Of course it requires a minor bump. Regards Rüdiger -Original Message- From: Plüm, Rüdiger, Vodafone Group Sent: Dienstag, 25. August 2015 11:39 To: dev@httpd.apache.org Subject: RE: PR 58267: Regression in 2.2.31 caused by r1680920 How about the following patch? It uses

RE: PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-25 Thread Plüm , Rüdiger , Vodafone Group
;/* The server_rec where this configuration was created in */ }; /* Regards Rüdiger -Original Message- From: Plüm, Rüdiger, Vodafone Group Sent: Dienstag, 25. August 2015 10:48 To: dev@httpd.apache.org Subject: RE: PR 58267: Regression in 2.2.31 caused by r1680920 I think

RE: PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-25 Thread Plüm , Rüdiger , Vodafone Group
-Original Message- From: Plüm, Rüdiger, Vodafone Group Sent: Dienstag, 25. August 2015 14:58 To: dev@httpd.apache.org Subject: RE: PR 58267: Regression in 2.2.31 caused by r1680920 Now the more complete patch (including bump): Index: modules/proxy/proxy_util.c

Re: PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-25 Thread Jan Kaluža
...@redhat.com] Sent: Dienstag, 25. August 2015 10:23 To: dev@httpd.apache.org Subject: Re: PR 58267: Regression in 2.2.31 caused by r1680920 On 08/24/2015 11:12 PM, Yann Ylavic wrote: On Mon, Aug 24, 2015 at 5:51 PM, Yann Ylavic ylavic@gmail.com wrote: On Mon, Aug 24, 2015 at 4:47 PM, Jan

Re: PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-25 Thread Yann Ylavic
On Tue, Aug 25, 2015 at 2:15 PM, Jan Kaluža jkal...@redhat.com wrote: On 08/25/2015 11:39 AM, Plüm, Rüdiger, Vodafone Group wrote: How about the following patch? It uses the server_rec of the server that originally created the configuration item. This looks like good strategy. I've verified

Re: PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-25 Thread Jan Kaluža
To: dev@httpd.apache.org Subject: Re: PR 58267: Regression in 2.2.31 caused by r1680920 On 08/25/2015 11:39 AM, Plüm, Rüdiger, Vodafone Group wrote: How about the following patch? It uses the server_rec of the server that originally created the configuration item. This looks like good strategy

Re: PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-25 Thread Jim Jagielski
, Vodafone Group Sent: Dienstag, 25. August 2015 11:39 To: dev@httpd.apache.org Subject: RE: PR 58267: Regression in 2.2.31 caused by r1680920 How about the following patch? It uses the server_rec of the server that originally created the configuration item. Index: modules/proxy/proxy_util.c

RE: PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-25 Thread Plüm , Rüdiger , Vodafone Group
this configuration was created in */ }; /* Regards Rüdiger -Original Message- From: Plüm, Rüdiger, Vodafone Group Sent: Dienstag, 25. August 2015 10:48 To: dev@httpd.apache.org Subject: RE: PR 58267: Regression in 2.2.31 caused by r1680920 I think the current

RE: PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-25 Thread Plüm , Rüdiger , Vodafone Group
-Original Message- From: Plüm, Rüdiger, Vodafone Group Sent: Dienstag, 25. August 2015 14:41 To: dev@httpd.apache.org Subject: RE: PR 58267: Regression in 2.2.31 caused by r1680920 Thanks for the pointer. It is missing because I removed it by accident when excluding some debug code I setup

Re: PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-25 Thread Yann Ylavic
On Tue, Aug 25, 2015 at 10:48 AM, Plüm, Rüdiger, Vodafone Group ruediger.pl...@vodafone.com wrote: I think the current state of 2.2.31 breaks existing 2.2.x configuration prior to 2.2.31. Prior to 2.2.31 you could do the following: Proxy Balancer://proxy1 BalancerMember ajp://127.0.0.1:7001

PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-24 Thread Jan Kaluža
Hi, unfortunately, the r1680920 brought undesired behavior described in PR 58267 to 2.2.x. The bug is well described in the PR, so I won't describe it in this email. I have tried to debug it and I think the problem is that we use also server-server_hostname to compute the hash in the

Re: PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-24 Thread Jan Kaluža
On 08/24/2015 04:47 PM, Jan Kaluža wrote: Hi, unfortunately, the r1680920 brought undesired behavior described in PR 58267 to 2.2.x. The bug is well described in the PR, so I won't describe it in this email. I have tried to debug it and I think the problem is that we use also

Re: PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-24 Thread Yann Ylavic
Hi Jan, I was working on the same issue... and was going to implement 2) :) On Mon, Aug 24, 2015 at 4:47 PM, Jan Kaluža jkal...@redhat.com wrote: Now, the root of the error is that the scoreboard size is static (set to proxy_lb_workers + PROXY_DYNAMIC_BALANCER_LIMIT), but it is not

Re: PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-24 Thread Yann Ylavic
On Mon, Aug 24, 2015 at 5:51 PM, Yann Ylavic ylavic@gmail.com wrote: On Mon, Aug 24, 2015 at 4:47 PM, Jan Kaluža jkal...@redhat.com wrote: 2) Increment proxy_lb_workers according to number of workers in balancer when using ProxyPass /foobar/ Balancer://foobar/ in the VirtualHost. The