On Thu, Mar 04, 2004 at 07:41:54AM +0100, André Malo wrote:
I'd prefer the %{SSL:...} variant and using ssl_var_lookup_ssl. All other
Agreed. It makes sense to me to make a specific point out of where those
variables came from.
vh
Mads Toftum
--
`Darn it, who spiked my coffee with water?!' -
On Thu, Mar 04, 2004 at 07:41:54AM +0100, André Malo wrote:
* Mathihalli, Madhusudan [EMAIL PROTECTED] wrote:
Here's a slightly modified version of Joe's patch to
- not segfault if rewrite_ssl_var_lookup is not available (mod_ssl not
loaded)- use SSL environment variables as
* Joe Orton [EMAIL PROTECTED] wrote:
I'm not really convinced about using ssl_var_lookup_ssl: that function
does not handle the HTTPS variable, and it would be potentially
confusing to users and hard to document since only some subset of the
SSL variables could be used. (it would also need a
On Thu, Mar 04, 2004 at 11:08:25AM +0100, André Malo wrote:
* Joe Orton [EMAIL PROTECTED] wrote:
I'm not really convinced about using ssl_var_lookup_ssl: that function
does not handle the HTTPS variable, and it would be potentially
confusing to users and hard to document since only some
Maybe
we should put the HTTPS check into an own function (we could use %{HTTPS} in
mod_rewrite then). That way, other modules, that want to check (only) HTTPS,
also don't need to run though all the mess of ssl_var_lookup.
I'm not familiar with mod_ssl internals, but is there any reason we
-Original Message-
From: Geoffrey Young [mailto:[EMAIL PROTECTED]
[SNIP]
I'm not familiar with mod_ssl internals, but is there any
reason we can't
move subprocess_env population to something early like
post-read-request?
as a per-connection thingy, HTTPS ought to be know before
Mathihalli, Madhusudan wrote:
Here's a slightly modified version of Joe's patch to
- not segfault if rewrite_ssl_var_lookup is not available (mod_ssl not loaded)
- use SSL environment variables as %{ENV:HTTPS} or %{ENV:SSL_PROTOCOL}
I tested the patch with the following rules, and it
--On Wednesday, March 3, 2004 3:04 PM -0800 Mathihalli, Madhusudan
[EMAIL PROTECTED] wrote:
+/* support for ssl_var_lookup() */
+APR_DECLARE_OPTIONAL_FN(char *, ssl_var_lookup,
+(apr_pool_t *, server_rec *,
+ conn_rec *, request_rec *,
+
-Original Message-
From: Justin Erenkrantz [mailto:[EMAIL PROTECTED]
[SNIP]
--On Wednesday, March 3, 2004 3:04 PM -0800 Mathihalli, Madhusudan
[EMAIL PROTECTED] wrote:
+/* support for ssl_var_lookup() */
+APR_DECLARE_OPTIONAL_FN(char *, ssl_var_lookup,
+
--On Wednesday, March 3, 2004 4:24 PM -0800 Mathihalli, Madhusudan
[EMAIL PROTECTED] wrote:
I thought it'll be a little too much :) What if I don't compile with
mod_ssl - I'll have a whole bunch of declarations with no definitions
associated with it. Besides, mod_proxy.c follows the same logic.
-Original Message-
From: Justin Erenkrantz [mailto:[EMAIL PROTECTED]
[SNIP]
--On Wednesday, March 3, 2004 4:24 PM -0800 Mathihalli, Madhusudan
[EMAIL PROTECTED] wrote:
I thought it'll be a little too much :) What if I don't compile with
mod_ssl - I'll have a whole bunch of
* Mathihalli, Madhusudan [EMAIL PROTECTED] wrote:
Here's a slightly modified version of Joe's patch to
- not segfault if rewrite_ssl_var_lookup is not available (mod_ssl not
loaded)- use SSL environment variables as %{ENV:HTTPS} or
%{ENV:SSL_PROTOCOL}
I'd prefer the %{SSL:...} variant and
12 matches
Mail list logo