On Mon, Mar 11, 2002 at 03:03:02PM +0100, Sander Striker wrote:
Hi,
server/protocol.c:136
if (ap_strcasestr(type, charset=) != NULL) {
/* already has parameter, do nothing */
/* XXX we don't check the validity */
;
}
Validity checking seems like a good
server/protocol.c:1290
AP_DECLARE(size_t) ap_send_mmap(apr_mmap_t *mm, request_rec *r,
size_t
offset,
size_t length)
I reckon the size_t's are left here intentional, weren't forgotten
when
switching to apr_size_t?
Does anything use this? I can't
Can this be turned into a feature macro?
Bill
Hi,
server/mpm_common.c:363
#if defined(QNX) || defined(MPE) || defined(BEOS) || defined(_OSD_POSIX) ||
defined(TPF)
|| defined(__TANDEM) || defined(OS2) ||
defined(WIN32) || defined(NETWARE)
Can I break this line into smaller chunks? If
Sander Striker [EMAIL PROTECTED] writes:
Hi,
server/mpm_common.c:363
#if defined(QNX) || defined(MPE) || defined(BEOS) || defined(_OSD_POSIX) ||
defined(TPF) || defined(__TANDEM) || defined(OS2) ||
defined(WIN32) || defined(NETWARE)
Can I break this line into smaller chunks? If so,
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED]]On Behalf Of Jeff Trawick
Sent: 11 March 2002 15:17
Sander Striker [EMAIL PROTECTED] writes:
Hi,
server/mpm_common.c:363
#if defined(QNX) || defined(MPE) || defined(BEOS) || defined(_OSD_POSIX) ||
defined(TPF) || defined(__TANDEM) ||
Sander Striker [EMAIL PROTECTED] writes:
plenty of ways to skin a cat, all of them good
As a cat owner I sincerely how this is a figure of speech... :)
if only you knew our cat :)
--
Jeff Trawick | [EMAIL PROTECTED] | PGP public key at web site:
On Mon, Mar 11, 2002 at 03:33:55PM +0100, Sander Striker wrote:
...
server/mpm_common.c:442
rv = apr_file_close(pod-pod_in);
if (rv != APR_SUCCESS) {
return rv;
}
return rv;
}
If we are going to waste the if, we might aswell return
APR_SUCCESS, no?
server/config.c:396
return !!(cmd-limited (AP_METHOD_BIT methnum));
^^
Is that a typo or intentional?
It's intentional. This line always sparks a VERY large debate. The
reason for it is that it is the only way to ensure that you have a 1 or
0 result. By negating twice,
From: Ryan Bloom [mailto:[EMAIL PROTECTED]]
Sent: 07 March 2002 19:58
server/config.c:396
return !!(cmd-limited (AP_METHOD_BIT methnum));
^^
Is that a typo or intentional?
It's intentional. This line always sparks a VERY large debate.
Then why didn't any one leave a
From: Sander Striker [mailto:[EMAIL PROTECTED]]
Sent: 07 March 2002 20:48
server/core.c:661
AP_DECLARE(const char *) ap_document_root(request_rec *r) /* Don't use this! */
If we shouldn't use it, why is it still here?
Because people are lazy and most people didn't realize that
server/core.c:661
AP_DECLARE(const char *) ap_document_root(request_rec *r) /*
Don't
use this! */
If we shouldn't use it, why is it still here?
Because people are lazy and most people didn't realize that comment
existed. If nobody is using that function, remove it.
Okay,
From: Sander Striker [mailto:[EMAIL PROTECTED]]
Sent: 07 March 2002 20:48
server/core.c:691
/* Should probably just get rid of this... the only code that cares is
* part of the core anyway (and in fact, it isn't publicised to other
* modules).
*/
Read the comment.
From: Ryan Bloom [mailto:[EMAIL PROTECTED]]
Sent: 07 March 2002 20:49
server/core.c:661
AP_DECLARE(const char *) ap_document_root(request_rec *r) /*
Don't
use this! */
If we shouldn't use it, why is it still here?
Because people are lazy and most people didn't realize
13 matches
Mail list logo
