Re: [PATCH] Make caching hash more deterministic

2005-08-15 Thread Colm MacCarthaigh
On Sat, Aug 13, 2005 at 10:29:54AM +0200, Graham Leggett wrote: The idea of canonicalising the name is sound, but munging them into an added :80 and an added ? is really ugly - these are not the kind of URLs that an end user would understand at a glance if they had to see them listed. An

Re: [PATCH] Make caching hash more deterministic

2005-08-15 Thread Jim Jagielski
On Aug 15, 2005, at 4:10 AM, Colm MacCarthaigh wrote: On Sat, Aug 13, 2005 at 10:29:54AM +0200, Graham Leggett wrote: The idea of canonicalising the name is sound, but munging them into an added :80 and an added ? is really ugly - these are not the kind of URLs that an end user would

Re: [PATCH] Make caching hash more deterministic

2005-08-15 Thread Graham Leggett
Colm MacCarthaigh wrote: An end-user should never see these keys, the only place they are visible to any user is the semi-binary mod_disk_cache files. An administrator would have to really know what they're doing to find them, or be using htcacheadmin - once I finish that, and if it gets

Re: [PATCH] Make caching hash more deterministic

2005-08-14 Thread Graham Leggett
Colm MacCarthaigh wrote: Currently; GET / HTTP/1.1 Host: ftp.heanet.ie GET http://ftp.heanet.ie/ HTTP/1.0 GET HTTP://Ftp.Heanet.Ie/ HTTP/1.0 are all mapped to different hashes by mod_cache; despite being the same content, this is an inefficient waste of disk

Re: [PATCH] Make caching hash more deterministic

2005-08-13 Thread Colm MacCarthaigh
On Fri, Aug 12, 2005 at 01:34:50PM -0400, Jim Jagielski wrote: Here's a more involved patch that gets the logic right. It's 6pm on a Friday for me, so I have only tested it a little, but thought I'd share for comment before the weekend. +1 on inspection... testing to be done over the

Re: [PATCH] Make caching hash more deterministic

2005-08-12 Thread Brian Akins
Should this honor usecanonicalname? If so, could just use ap_get_servername(r) in stead of r-hostname. This may further compact the number of entries. -- Brian Akins Lead Systems Engineer CNN Internet Technologies

Re: [PATCH] Make caching hash more deterministic

2005-08-12 Thread Colm MacCarthaigh
On Fri, Aug 12, 2005 at 11:54:44AM -0400, Brian Akins wrote: Should this honor usecanonicalname? If so, could just use ap_get_servername(r) in stead of r-hostname. This may further compact the number of entries. Yes, but I think there'd have to be additional code to detect the proxy cases.

Re: [PATCH] Make caching hash more deterministic

2005-08-12 Thread Colm MacCarthaigh
On Fri, Aug 12, 2005 at 04:59:20PM +0100, Colm MacCarthaigh wrote: On Fri, Aug 12, 2005 at 11:54:44AM -0400, Brian Akins wrote: Should this honor usecanonicalname? If so, could just use ap_get_servername(r) in stead of r-hostname. This may further compact the number of entries. Yes,

Re: [PATCH] Make caching hash more deterministic

2005-08-12 Thread Jim Jagielski
On Aug 12, 2005, at 1:10 PM, Colm MacCarthaigh wrote: On Fri, Aug 12, 2005 at 04:59:20PM +0100, Colm MacCarthaigh wrote: On Fri, Aug 12, 2005 at 11:54:44AM -0400, Brian Akins wrote: Should this honor usecanonicalname? If so, could just use ap_get_servername(r) in stead of r-hostname.