Re: http://svn.apache.org/r1850745

2019-03-13 Thread William A Rowe Jr
To take this discussion all the way back to APR project's potential concerns... On Wed, Mar 13, 2019 at 8:03 AM Jim Jagielski wrote: > > > On Mar 13, 2019, at 8:56 AM, Nick Kew wrote: > > > >> On 13 Mar 2019, at 12:43, Jim Jagielski wrote: > >> > >> Is there anyone else building 2.4 on macOS

Re: http://svn.apache.org/r1850745

2019-03-13 Thread Jim Jagielski
> On Mar 13, 2019, at 11:04 AM, William A Rowe Jr wrote: > > > As you can see, you didn't modify only modules/filters/ ... Maybe you > meant to modify MOD_CPPFLAGS, as modules/http2/modules.mak does? > If that will solve the issue I'm all for it! Thx.

Re: http://svn.apache.org/r1850745

2019-03-13 Thread William A Rowe Jr
Just as a reminder of what r1850745 actually did, from an old discussion; On Wed, Jan 16, 2019 at 5:09 PM William A Rowe Jr wrote: > On Wed, Jan 16, 2019 at 3:54 PM Jim Jagielski wrote: > >> I'm sorry but I'm confused. The patch is as specific as you can get. It >> just adds the minimal option

Re: http://svn.apache.org/r1850745

2019-03-13 Thread William A Rowe Jr
On Wed, Mar 13, 2019 at 8:04 AM Jim Jagielski wrote: > > Yeah, I also think it depends on the version of clang... previous versions > did not flag > > /usr/local/include/unicode/uenum.h:1:1: error: // comments are not > allowed in this language [-Werror,-Wcomment] > > as fatal errors. Just

Re: http://svn.apache.org/r1850745

2019-03-13 Thread Jim Jagielski
> On Mar 13, 2019, at 8:51 AM, Yann Ylavic wrote: > > On Wed, Mar 13, 2019 at 1:45 PM Eric Covener wrote: >> >> On Wed, Mar 13, 2019 at 8:43 AM Jim Jagielski wrote: >>> >>> Is there anyone else building 2.4 on macOS under maintainer-mode >>> who is also being affected by the above? The

Re: http://svn.apache.org/r1850745

2019-03-13 Thread Jim Jagielski
It's libxml2 from MacPorts... which is basically vanilla libxml2. APR is 1.6.x > On Mar 13, 2019, at 8:56 AM, Nick Kew wrote: > > > >> On 13 Mar 2019, at 12:43, Jim Jagielski wrote: >> >> Is there anyone else building 2.4 on macOS under maintainer-mode >> who is also being affected by the

Re: http://svn.apache.org/r1850745

2019-03-13 Thread Nick Kew
> On 13 Mar 2019, at 12:43, Jim Jagielski wrote: > > Is there anyone else building 2.4 on macOS under maintainer-mode > who is also being affected by the above? The fact that I seem to > be the anyone "complaining" :) seems weird... > > Thx! Just out of interest, is that with a

Re: http://svn.apache.org/r1850745

2019-03-13 Thread Yann Ylavic
On Wed, Mar 13, 2019 at 1:45 PM Eric Covener wrote: > > On Wed, Mar 13, 2019 at 8:43 AM Jim Jagielski wrote: > > > > Is there anyone else building 2.4 on macOS under maintainer-mode > > who is also being affected by the above? The fact that I seem to > > be the anyone "complaining" :) seems

Re: http://svn.apache.org/r1850745

2019-03-13 Thread Eric Covener
On Wed, Mar 13, 2019 at 8:43 AM Jim Jagielski wrote: > > Is there anyone else building 2.4 on macOS under maintainer-mode > who is also being affected by the above? The fact that I seem to > be the anyone "complaining" :) seems weird... FWIW Looks like I have maintainer mode but not libxml2