Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-05-05 Thread Ruediger Pluem
On 5/5/23 2:37 AM, Greg Stein wrote: > Down-thread, Giovanni asks about security patch handling. We can continue to > use repos/private/pmc/httpd/ for that. That area will > not go away. If people want to go "all git", then Infra can provide projects > with a single, private repository that

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-05-04 Thread Greg Stein
On Tue, Apr 25, 2023 at 1:45 AM Ruediger Pluem wrote: >... > 2. Switching from Subversion to Git is mostly an emotional problem for me. > We have some closer ties to Subversion by some >overlaps in the community and via mod_dav_svn we kind of partially eat > our very own dogfood here by

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-05-04 Thread Joe Orton
On Wed, May 03, 2023 at 02:31:35PM -0500, Daniel Gruno wrote: > I am +1 on moving. I do not have any particular love for git or svn on their > own, and I realize that the proposed change does make outside contributions > and certain workflows easier. +1 for the same reasons here. Might be better

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-05-04 Thread giovanni
On 5/3/23 23:03, Christophe JAILLET wrote: Le 03/05/2023 à 21:12, Eric Covener a écrit : On Tue, Apr 25, 2023 at 2:45 PM Graham Leggett via dev wrote: On 25 Apr 2023, at 07:45, Ruediger Pluem wrote: 2. Switching from Subversion to Git is mostly an emotional problem for me. We have some

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-05-04 Thread Nilgün Belma Bugüner
4.05.2023 10:25 tarihinde Stefan Eissing via dev yazdı: Am 03.05.2023 um 23:03 schrieb Christophe JAILLET : Le 03/05/2023 à 21:12, Eric Covener a écrit : On Tue, Apr 25, 2023 at 2:45 PM Graham Leggett via dev wrote: On 25 Apr 2023, at 07:45, Ruediger Pluem wrote: 2. Switching from

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-05-04 Thread Stefan Eissing via dev
> Am 03.05.2023 um 23:03 schrieb Christophe JAILLET > : > > Le 03/05/2023 à 21:12, Eric Covener a écrit : >> On Tue, Apr 25, 2023 at 2:45 PM Graham Leggett via dev >> wrote: >>> >>> On 25 Apr 2023, at 07:45, Ruediger Pluem wrote: >>> >>> 2. Switching from Subversion to Git is mostly an

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-05-03 Thread Christophe JAILLET
Le 03/05/2023 à 21:12, Eric Covener a écrit : On Tue, Apr 25, 2023 at 2:45 PM Graham Leggett via dev wrote: On 25 Apr 2023, at 07:45, Ruediger Pluem wrote: 2. Switching from Subversion to Git is mostly an emotional problem for me. We have some closer ties to Subversion by some overlaps

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-05-03 Thread Daniel Gruno
On 2023-05-03 14:12, Eric Covener wrote: On Tue, Apr 25, 2023 at 2:45 PM Graham Leggett via dev wrote: On 25 Apr 2023, at 07:45, Ruediger Pluem wrote: 2. Switching from Subversion to Git is mostly an emotional problem for me. We have some closer ties to Subversion by some overlaps in

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-05-03 Thread Eric Covener
On Tue, Apr 25, 2023 at 2:45 PM Graham Leggett via dev wrote: > > On 25 Apr 2023, at 07:45, Ruediger Pluem wrote: > > 2. Switching from Subversion to Git is mostly an emotional problem for me. We > have some closer ties to Subversion by some > overlaps in the community and via mod_dav_svn we

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-04-25 Thread Graham Leggett via dev
On 25 Apr 2023, at 07:45, Ruediger Pluem wrote: > 2. Switching from Subversion to Git is mostly an emotional problem for me. We > have some closer ties to Subversion by some > overlaps in the community and via mod_dav_svn we kind of partially eat our > very own dogfood here by using

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-04-25 Thread Joe Schaefer
Get over the heartache and brand loyalty and get on rw git. Github isn't the only game in town anymore for git hosting, so don't feel trapped by infra just because it's all they've got in the tank. On Tue, Apr 25, 2023 at 2:07 PM Eric Covener wrote: > On Tue, Apr 25, 2023 at 2:45 AM Ruediger

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-04-25 Thread Eric Covener
On Tue, Apr 25, 2023 at 2:45 AM Ruediger Pluem wrote: > > > > On 4/12/23 2:02 PM, Yann Ylavic wrote: > > On Wed, Apr 12, 2023 at 1:31 PM Eric Covener wrote: > >> > >> On Wed, Apr 12, 2023 at 6:36 AM Yann Ylavic wrote: > >>> > >>> On Wed, Apr 12, 2023 at 12:26 PM Yann Ylavic wrote: > >

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-04-25 Thread Ruediger Pluem
On 4/12/23 2:02 PM, Yann Ylavic wrote: > On Wed, Apr 12, 2023 at 1:31 PM Eric Covener wrote: >> >> On Wed, Apr 12, 2023 at 6:36 AM Yann Ylavic wrote: >>> >>> On Wed, Apr 12, 2023 at 12:26 PM Yann Ylavic wrote: On Wed, Apr 12, 2023 at 12:18 PM ylavic wrote: > > @ylavic

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-04-12 Thread Yann Ylavic
On Wed, Apr 12, 2023 at 1:31 PM Eric Covener wrote: > > On Wed, Apr 12, 2023 at 6:36 AM Yann Ylavic wrote: > > > > On Wed, Apr 12, 2023 at 12:26 PM Yann Ylavic wrote: > > > > > > On Wed, Apr 12, 2023 at 12:18 PM ylavic wrote: > > > > > > > > @ylavic approved this pull request. > > > > > > > >

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-04-12 Thread Eric Covener
On Wed, Apr 12, 2023 at 6:36 AM Yann Ylavic wrote: > > On Wed, Apr 12, 2023 at 12:26 PM Yann Ylavic wrote: > > > > On Wed, Apr 12, 2023 at 12:18 PM ylavic wrote: > > > > > > @ylavic approved this pull request. > > > > > > Three approvals to get ci started? > > > > Nope.. It seems that gh

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-04-12 Thread Ruediger Pluem
On 4/12/23 12:35 PM, Yann Ylavic wrote: > On Wed, Apr 12, 2023 at 12:26 PM Yann Ylavic wrote: >> >> On Wed, Apr 12, 2023 at 12:18 PM ylavic wrote: >>> >>> @ylavic approved this pull request. >>> >>> Three approvals to get ci started? >> >> Nope.. It seems that gh actions don't run for PRs

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-04-12 Thread Yann Ylavic
On Wed, Apr 12, 2023 at 12:26 PM Yann Ylavic wrote: > > On Wed, Apr 12, 2023 at 12:18 PM ylavic wrote: > > > > @ylavic approved this pull request. > > > > Three approvals to get ci started? > > Nope.. It seems that gh actions don't run for PRs whatever we do. > The docs[1] say that there should

ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-04-12 Thread Yann Ylavic
On Wed, Apr 12, 2023 at 12:18 PM ylavic wrote: > > @ylavic approved this pull request. > > Three approvals to get ci started? Nope.. It seems that gh actions don't run for PRs whatever we do. The docs[1] say that there should be an "Approve and run" button near the "workflow awaiting approval"