Re: mod_ssl: inline SSL_X509_INFO_load_path(); please review

2015-05-02 Thread Kaspar Brand
On 01.05.2015 17:11, Stefan Sperling wrote: I believe SSL_X509_INFO_load_path() should be inlined into its only caller. I'm +1 for this. The Low-Level CA Certificate Loading part in ssl_util_ssl.c is / was only used by ssl_init_proxy_certs, so I would be in favor of also moving

mod_ssl: inline SSL_X509_INFO_load_path(); please review

2015-05-01 Thread Stefan Sperling
I believe SSL_X509_INFO_load_path() should be inlined into its only caller. I'd like some eyes on this change since it's not just mechanical. The desired behaviour seems to be load as many certs as possible from a directory, looping over its file entries. Ignore errors, e.g. in case the file is