Re: svn commit: 1573360 - SSLPassPhraseDialog arguments changed in 2.4.x

2014-04-27 Thread Kaspar Brand
On 16.04.2014 10:17, Kaspar Brand wrote: There's another backwards-compatibility fix I consider necessary for 2.4.x (see https://issues.apache.org/bugzilla/show_bug.cgi?id=56306#c8), so I think I'll wait a few days for feedback on that one before combining them into a single proposal for 2.4.x

Re: svn commit: 1573360 - SSLPassPhraseDialog arguments changed in 2.4.x

2014-04-16 Thread Kaspar Brand
On 14.04.2014 10:47, Jan Kaluža wrote: On 04/12/2014 12:37 PM, Kaspar Brand wrote: We can partly restore the argument structure for exec-type programs, but effectively, lifting the limit of 2 (or 3) certs per SSL host means that there's no longer a reliable way of determining if we are

Re: svn commit: 1573360 - SSLPassPhraseDialog arguments changed in 2.4.x

2014-04-16 Thread Jan Kaluža
On 04/16/2014 08:45 AM, Kaspar Brand wrote: On 14.04.2014 10:47, Jan Kaluža wrote: On 04/12/2014 12:37 PM, Kaspar Brand wrote: We can partly restore the argument structure for exec-type programs, but effectively, lifting the limit of 2 (or 3) certs per SSL host means that there's no longer a

RE: svn commit: 1573360 - SSLPassPhraseDialog arguments changed in 2.4.x

2014-04-16 Thread Plüm , Rüdiger , Vodafone Group
-Original Message- From: Jan Kaluža [mailto:jkal...@redhat.com] Sent: Mittwoch, 16. April 2014 09:32 To: dev@httpd.apache.org Subject: Re: svn commit: 1573360 - SSLPassPhraseDialog arguments changed in 2.4.x On 04/16/2014 08:45 AM, Kaspar Brand wrote: On 14.04.2014 10:47, Jan

Re: svn commit: 1573360 - SSLPassPhraseDialog arguments changed in 2.4.x

2014-04-16 Thread Jan Kaluža
On 04/16/2014 09:35 AM, Plüm, Rüdiger, Vodafone Group wrote: -Original Message- From: Jan Kaluža [mailto:jkal...@redhat.com] Sent: Mittwoch, 16. April 2014 09:32 To: dev@httpd.apache.org Subject: Re: svn commit: 1573360 - SSLPassPhraseDialog arguments changed in 2.4.x On 04/16/2014

Re: svn commit: 1573360 - SSLPassPhraseDialog arguments changed in 2.4.x

2014-04-16 Thread Kaspar Brand
On 16.04.2014 09:45, Jan Kaluža wrote: On 04/16/2014 09:35 AM, Plüm, Rüdiger, Vodafone Group wrote: Are we sure that ppcb_arg-key_id always contains a ':'? I've checked that part of patch and if I'm right, the key_id is only created by asn1_table_vhost_key(...) like this: char *key =

Re: svn commit: 1573360 - SSLPassPhraseDialog arguments changed in 2.4.x

2014-04-14 Thread Jan Kaluža
On 04/12/2014 12:37 PM, Kaspar Brand wrote: [picking this up from the comment in Re: svn commit: r1585902 - ...] On 09.04.2014 21:56, Jeff Trawick wrote: IMO this needs to be reworked to restore compatibility for 2.x up through 2.4.7, with the new interface used if some new keyword is added on

Re: svn commit: 1573360 - SSLPassPhraseDialog arguments changed in 2.4.x

2014-04-12 Thread Kaspar Brand
[picking this up from the comment in Re: svn commit: r1585902 - ...] On 09.04.2014 21:56, Jeff Trawick wrote: IMO this needs to be reworked to restore compatibility for 2.x up through 2.4.7, with the new interface used if some new keyword is added on the directive. Yeah, some people who

Re: svn commit: 1573360 - SSLPassPhraseDialog arguments changed in 2.4.x

2014-04-05 Thread Kaspar Brand
On 04.04.2014 12:22, Jan Kaluža wrote: commit 1553824 (1573360 in 2.4.x) breaks the compatibility in arguments passed to exec:/path/to/program pass phrase program. This should be clear from the following part of mentioned commit(s): -argv[1] = cpVHostID; -argv[2] =

svn commit: 1573360 - SSLPassPhraseDialog arguments changed in 2.4.x

2014-04-04 Thread Jan Kaluža
Hi, commit 1553824 (1573360 in 2.4.x) breaks the compatibility in arguments passed to exec:/path/to/program pass phrase program. This should be clear from the following part of mentioned commit(s): -argv[1] = cpVHostID; -argv[2] = cpAlgoType; -argv[3] = NULL; +