Re: svn commit: r1533810 - in /httpd/httpd/trunk: docs/man/rotatelogs.8 docs/manual/programs/rotatelogs.html.en support/rotatelogs.c

2013-10-22 Thread Ben Reser
On 10/20/13 5:31 AM, Ruediger Pluem wrote: Can't we use apr_psprintf with %pm instead of the constant length buffer char [120]? Done in r1534895, r1534896 and r1534914.

Re: svn commit: r1533810 - in /httpd/httpd/trunk: docs/man/rotatelogs.8 docs/manual/programs/rotatelogs.html.en support/rotatelogs.c

2013-10-20 Thread Ruediger Pluem
bre...@apache.org wrote: Author: breser Date: Sat Oct 19 19:10:33 2013 New Revision: 1533810 URL: http://svn.apache.org/r1533810 Log: Add an option to autocreate directories to rotatelogs. * support/rotatelogs.c (rotate_config): Remove const from szLogRoot since we'll be passing it

Re: svn commit: r1533810 - in /httpd/httpd/trunk: docs/man/rotatelogs.8 docs/manual/programs/rotatelogs.html.en support/rotatelogs.c

2013-10-20 Thread André Malo
* bre...@apache.org wrote: Author: breser Date: Sat Oct 19 19:10:33 2013 New Revision: 1533810 * docs/man/rotatelogs.8, docs/manual/programs/rotatelogs.html.en: Update for -d option. Huh. These files are both generated (or should be). Please update rotatelogs.xml instead. nd -- Die

Re: svn commit: r1533810 - in /httpd/httpd/trunk: docs/man/rotatelogs.8 docs/manual/programs/rotatelogs.html.en support/rotatelogs.c

2013-10-20 Thread Ben Reser
On 10/20/13 5:31 AM, Ruediger Pluem wrote: apr_pool_create(newlog.pool, status-pool); +if (config-create_path) { +char *ptr = strrchr(newlog.name, '/'); +if (ptr ptr newlog.name) { +char *path = apr_pstrmemdup(newlog.pool, newlog.name, ptr -

Re: svn commit: r1533810 - in /httpd/httpd/trunk: docs/man/rotatelogs.8 docs/manual/programs/rotatelogs.html.en support/rotatelogs.c

2013-10-20 Thread Ben Reser
On 10/20/13 5:37 AM, André Malo wrote: * bre...@apache.org wrote: Author: breser Date: Sat Oct 19 19:10:33 2013 New Revision: 1533810 * docs/man/rotatelogs.8, docs/manual/programs/rotatelogs.html.en: Update for -d option. Huh. These files are both generated (or should be). Please

Re: svn commit: r1533810 - in /httpd/httpd/trunk: docs/man/rotatelogs.8 docs/manual/programs/rotatelogs.html.en support/rotatelogs.c

2013-10-20 Thread Jeff Trawick
On Sun, Oct 20, 2013 at 1:54 PM, Ben Reser b...@reser.org wrote: On 10/20/13 5:31 AM, Ruediger Pluem wrote: apr_pool_create(newlog.pool, status-pool); +if (config-create_path) { +char *ptr = strrchr(newlog.name, '/'); +if (ptr ptr newlog.name) { +

Re: svn commit: r1533810 - in /httpd/httpd/trunk: docs/man/rotatelogs.8 docs/manual/programs/rotatelogs.html.en support/rotatelogs.c

2013-10-20 Thread André Malo
* Ben Reser wrote: On 10/20/13 5:37 AM, André Malo wrote: * bre...@apache.org wrote: Author: breser Date: Sat Oct 19 19:10:33 2013 New Revision: 1533810 * docs/man/rotatelogs.8, docs/manual/programs/rotatelogs.html.en: Update for -d option. Huh. These files are both generated

Re: svn commit: r1533810 - in /httpd/httpd/trunk: docs/man/rotatelogs.8 docs/manual/programs/rotatelogs.html.en support/rotatelogs.c

2013-10-20 Thread Ben Reser
On 10/20/13 11:23 AM, Jeff Trawick wrote: trunk and 2.4.x branch: checking for APR... configure: WARNING: APR version 1.4.0 or later is required, found 1.3.13 configure: WARNING: Found APR in /home/trawick/inst/apr13-64/bin/apr-1-config, but we think it is considered unacceptable