Re: AW: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

On Mon, Dec 19, 2016 at 9:00 PM, Ruediger Pluem wrote: > > > This doesn't seem to be in trunk yet. Care to commit? Done in r1775195, thanks Rüdiger for your great suggestions. Regards, Yann.

Re: AW: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

On 12/15/2016 11:13 AM, Plüm, Rüdiger, Vodafone Group wrote: > > >> -Ursprüngliche Nachricht- >> Von: Yann Ylavic [mailto:ylavic@gmail.com] >> Gesendet: Mittwoch, 14. Dezember 2016 19:58 >> An: httpd-dev <dev@httpd.apache.org> >> Betreff:

Re: AW: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

2016-12-14 18:53 GMT+01:00 Jacob Champion : > On 12/14/2016 09:33 AM, Jacob Champion wrote: > >> The current public filter documentation at [1] (which is old, but still >> the only overall documentation I'm aware of) says >> > > Forgot the link, sorry. > > [1]

AW: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

> -Ursprüngliche Nachricht- > Von: Yann Ylavic [mailto:ylavic@gmail.com] > Gesendet: Mittwoch, 14. Dezember 2016 19:58 > An: httpd-dev <dev@httpd.apache.org> > Betreff: Re: svn commit: r1773865 - > /httpd/httpd/trunk/modules/http/http_filters.c > > O

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

On Wed, Dec 14, 2016 at 9:45 AM, Plüm, Rüdiger, Vodafone Group wrote: > >> -Ursprüngliche Nachricht- >> Von: Yann Ylavic [mailto:ylavic@gmail.com] >> Gesendet: Mittwoch, 14. Dezember 2016 01:42 >> >> It is actually, we could eventually avoid

Re: AW: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

On 12/14/2016 09:33 AM, Jacob Champion wrote: The current public filter documentation at [1] (which is old, but still the only overall documentation I'm aware of) says Forgot the link, sorry. [1] https://httpd.apache.org/docs/trunk/developer/output-filters.html --Jacob

Re: AW: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

On 12/14/2016 12:45 AM, Plüm, Rüdiger, Vodafone Group wrote: -Ursprüngliche Nachricht- Von: Yann Ylavic [mailto:ylavic@gmail.com] > @@ -1227,13 +1224,6 @@ AP_CORE_DECLARE_NONSTD(apr_status_t) ap_http_heade e != APR_BRIGADE_SENTINEL(b); e = APR_BUCKET_NEXT(e))

AW: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

> -Ursprüngliche Nachricht- > Von: Yann Ylavic [mailto:ylavic@gmail.com] > Gesendet: Mittwoch, 14. Dezember 2016 01:42 > An: httpd-dev <dev@httpd.apache.org> > Betreff: Re: svn commit: r1773865 - > /httpd/httpd/trunk/modules/http/http_filters.c > > O

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

On Tue, Dec 13, 2016 at 6:42 PM, Yann Ylavic wrote: > On Tue, Dec 13, 2016 at 8:37 PM, Ruediger Pluem wrote: > > > > This change is also unrelated to the bad header issue and I think > > if there is interest to address this it should be done in a

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

On Tue, Dec 13, 2016 at 8:37 PM, Ruediger Pluem wrote: > > On 12/13/2016 02:49 PM, Yann Ylavic wrote: >> >> The pros with this is indeed the reduced complexity (though the loop >> to walk the brigade already existed), the cons are that we rely on the >> caller/handler to not

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

On 12/13/2016 12:18 PM, Ruediger Pluem wrote: Have a look at line 1334 of mod_proxy_http.c: Okay, that's starting to make some more sense. Thanks! On 12/13/2016 11:37 AM, Ruediger Pluem wrote: After this patch we do the wrong thing with an EOC bucket. The current contract is that an EOC

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

On 12/13/2016 08:57 PM, Jacob Champion wrote: > On 12/13/2016 11:37 AM, Ruediger Pluem wrote: >> On 12/13/2016 02:49 PM, Yann Ylavic wrote: >>> I don't find the change too complex after all, and that's a quite >>> critical filter for doing the right/safe thing... >>> >>> I'm even inclined to do

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

On 12/13/2016 11:37 AM, Ruediger Pluem wrote: On 12/13/2016 02:49 PM, Yann Ylavic wrote: I don't find the change too complex after all, and that's a quite critical filter for doing the right/safe thing... I'm even inclined to do the below changes, so that we are really safe (i.e. ignore any

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

On 12/13/2016 02:49 PM, Yann Ylavic wrote: > On Tue, Dec 13, 2016 at 10:48 AM, Plüm, Rüdiger, Vodafone Group > wrote: >> Another aspect of all these patches that I don't get is why we need >> to eat the contents of the original brigade? IMHO we don't need to do >>

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

On Tue, Dec 13, 2016 at 10:48 AM, Plüm, Rüdiger, Vodafone Group wrote: >> >> To clarify: I can't reproduce any problems with r1773861 in the first >> place, even with ErrorDocument. I agree that r1773862 (and r1773865) >> work for me; I just don't know what makes them

AW: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

> -Ursprüngliche Nachricht- > Von: Jacob Champion [mailto:champio...@gmail.com] > Gesendet: Dienstag, 13. Dezember 2016 00:01 > An: dev@httpd.apache.org > Betreff: Re: svn commit: r1773865 - > /httpd/httpd/trunk/modules/http/http_filters.c > > On 12/12/2016 01:

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

On Dec 12, 2016 6:07 PM, "Yann Ylavic" wrote: On Tue, Dec 13, 2016 at 12:17 AM, Jacob Champion wrote: > On 12/12/2016 03:10 PM, William A Rowe Jr wrote: >> >> On Mon, Dec 12, 2016 at 5:00 PM, Jacob Champion >

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

On Tue, Dec 13, 2016 at 12:17 AM, Jacob Champion wrote: > On 12/12/2016 03:10 PM, William A Rowe Jr wrote: >> >> On Mon, Dec 12, 2016 at 5:00 PM, Jacob Champion > > wrote: >> >> On 12/12/2016 01:23 PM, Yann Ylavic

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

On Tue, Dec 13, 2016 at 12:20 AM, Yann Ylavic wrote: > > So I guess r1773861 is OK already, though the below may be simpler/cleaner > now: > > Index: modules/http/http_filters.c > === > ---

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

On 12/12/2016 03:20 PM, Yann Ylavic wrote: On Tue, Dec 13, 2016 at 12:00 AM, Jacob Champion wrote: On 12/12/2016 01:23 PM, Yann Ylavic wrote: On Mon, Dec 12, 2016 at 10:07 PM, Jacob Champion wrote: What's the case where this catches recursion

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

On Tue, Dec 13, 2016 at 12:00 AM, Jacob Champion wrote: > On 12/12/2016 01:23 PM, Yann Ylavic wrote: >> >> On Mon, Dec 12, 2016 at 10:07 PM, Jacob Champion >> wrote: >> >>> >>> What's the case where this catches recursion that the previous logic in >>>

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

On 12/12/2016 03:10 PM, William A Rowe Jr wrote: On Mon, Dec 12, 2016 at 5:00 PM, Jacob Champion > wrote: On 12/12/2016 01:23 PM, Yann Ylavic wrote: On Mon, Dec 12, 2016 at 10:07 PM, Jacob Champion

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

On Mon, Dec 12, 2016 at 5:00 PM, Jacob Champion wrote: > On 12/12/2016 01:23 PM, Yann Ylavic wrote: > >> On Mon, Dec 12, 2016 at 10:07 PM, Jacob Champion >> wrote: >> >> >>> What's the case where this catches recursion that the previous logic in >>>

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

On 12/12/2016 01:23 PM, Yann Ylavic wrote: On Mon, Dec 12, 2016 at 10:07 PM, Jacob Champion wrote: What's the case where this catches recursion that the previous logic in r1773861 did not handle? I'm trying to write a test that fails on r1773861 and succeeds on

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

On Mon, Dec 12, 2016 at 3:32 PM, Yann Ylavic wrote: > On Mon, Dec 12, 2016 at 10:16 PM, William A Rowe Jr > wrote: > > On Mon, Dec 12, 2016 at 3:07 PM, Jacob Champion > > wrote:+ > >> > >> > >> What's the case where this catches

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

On Mon, Dec 12, 2016 at 10:16 PM, William A Rowe Jr wrote: > On Mon, Dec 12, 2016 at 3:07 PM, Jacob Champion > wrote:+ >> >> >> What's the case where this catches recursion that the previous logic in >> r1773861 did not handle? I'm trying to write a

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

On Mon, Dec 12, 2016 at 10:07 PM, Jacob Champion wrote: > > What's the case where this catches recursion that the previous logic in > r1773861 did not handle? I'm trying to write a test that fails on r1773861 > and succeeds on r1773865, but I haven't figured it out yet. I

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

On Mon, Dec 12, 2016 at 3:07 PM, Jacob Champion wrote:+ > > > What's the case where this catches recursion that the previous logic in > r1773861 did not handle? I'm trying to write a test that fails on r1773861 > and succeeds on r1773865, but I haven't figured it out yet.

Re: svn commit: r1773865 - /httpd/httpd/trunk/modules/http/http_filters.c

On 12/12/2016 12:31 PM, yla...@apache.org wrote: Author: ylavic Date: Mon Dec 12 20:31:44 2016 New Revision: 1773865 URL: http://svn.apache.org/viewvc?rev=1773865=rev Log: Follow up to r1773761: improved recursion detection. Modified: httpd/httpd/trunk/modules/http/http_filters.c