Re: svn commit: r1840265 - in /httpd/httpd/trunk: include/ap_mmn.h include/util_filter.h modules/http/http_request.c server/core_filters.c server/util_filter.c

2018-09-07 Thread William A Rowe Jr
On Fri, Sep 7, 2018 at 4:52 AM Yann Ylavic wrote: > > There probably are other "includes/" candidates, like: > ap_expr_init (ap_expr.h) > ap_open_logs (http_log.h) > ap_logs_child_init (http_log.h) > ap_add_output_filters_by_type (http_core.h) > ap_core_reorder_directories

Re: svn commit: r1840265 - in /httpd/httpd/trunk: include/ap_mmn.h include/util_filter.h modules/http/http_request.c server/core_filters.c server/util_filter.c

2018-09-07 Thread Yann Ylavic
On Fri, Sep 7, 2018 at 2:21 AM William A Rowe Jr wrote: > > I'd suggest you did a better job in the commit log explaning this than in the > doxygen where it really is needed. OK, I can do this when moving the declaration to a more private location. > > Private declares don't belong in

Re: svn commit: r1840265 - in /httpd/httpd/trunk: include/ap_mmn.h include/util_filter.h modules/http/http_request.c server/core_filters.c server/util_filter.c

2018-09-06 Thread William A Rowe Jr
I'd suggest you did a better job in the commit log explaning this than in the doxygen where it really is needed. Private declares don't belong in util_filter.h IMO. On Thu, Sep 6, 2018, 17:48 wrote: > Author: ylavic > Date: Thu Sep 6 22:48:28 2018 > New Revision: 1840265 > > URL: