Re: svn commit: r1879285 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/core.xml include/ap_mmn.h include/http_core.h include/http_protocol.h include/httpd.h modules/dav/fs/repos.c modules/test/mod_

On 03 Jul 2020, at 11:19, Ruediger Pluem wrote: > Thanks for the pointer. Is Content-MD5 really used? And given that it has > been removed in the RFC my approach would be as follows: > > 1. Continue with your new additions as is. Do not try to merge any of this > code with Content-MD5 related

Re: svn commit: r1879285 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/core.xml include/ap_mmn.h include/http_core.h include/http_protocol.h include/httpd.h modules/dav/fs/repos.c modules/test/mod_

On 7/3/20 10:54 AM, Graham Leggett wrote: > On 29 Jun 2020, at 16:37, Ruediger Pluem wrote: > >> Makes sense. >> Do you see a possibility to merge this code and the one of ap_md5digest to a >> more generic procedure that >> allows to choose the digest algorithm while using 'MMAPED' reads? >>

Re: svn commit: r1879285 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/core.xml include/ap_mmn.h include/http_core.h include/http_protocol.h include/httpd.h modules/dav/fs/repos.c modules/test/mod_

On 29 Jun 2020, at 16:37, Ruediger Pluem wrote: > Makes sense. > Do you see a possibility to merge this code and the one of ap_md5digest to a > more generic procedure that > allows to choose the digest algorithm while using 'MMAPED' reads? > BTW: Is sha1 mandatory for strong etags? If not

Re: svn commit: r1879285 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/core.xml include/ap_mmn.h include/http_core.h include/http_protocol.h include/httpd.h modules/dav/fs/repos.c modules/test/mod_

> On Jun 29, 2020, at 10:27 AM, Graham Leggett wrote: > > On 29 Jun 2020, at 14:49, Yann Ylavic > wrote: > >>> Yes we can and should (but in separate commits). >>> >>> I have my eye on the r->proxyreq flag, we can pack this into the binary >>> notes too, values

Re: svn commit: r1879285 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/core.xml include/ap_mmn.h include/http_core.h include/http_protocol.h include/httpd.h modules/dav/fs/repos.c modules/test/mod_

On 6/29/20 4:08 PM, Graham Leggett wrote: > On 29 Jun 2020, at 11:41, Ruediger Pluem > wrote: > >>> +    etag = apr_palloc(r->pool, weak_len + sizeof("\"\"") + >>> +    4*(APR_SHA1_DIGESTSIZE/3) + vlv_len + 4); >> >> Using apr_base64_encode_len in the

Re: svn commit: r1879285 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/core.xml include/ap_mmn.h include/http_core.h include/http_protocol.h include/httpd.h modules/dav/fs/repos.c modules/test/mod_

On 29 Jun 2020, at 14:49, Yann Ylavic wrote: >> Yes we can and should (but in separate commits). >> >> I have my eye on the r->proxyreq flag, we can pack this into the binary >> notes too, values don’t need to be one bit wide. > > Actually I was thinking the other way around, have the new

Re: svn commit: r1879285 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/core.xml include/ap_mmn.h include/http_core.h include/http_protocol.h include/httpd.h modules/dav/fs/repos.c modules/test/mod_

On 29 Jun 2020, at 11:41, Ruediger Pluem wrote: >> +etag = apr_palloc(r->pool, weak_len + sizeof("\"\"") + >> +4*(APR_SHA1_DIGESTSIZE/3) + vlv_len + 4); > > Using apr_base64_encode_len in the formula above would make it easier to > understand and read IMHO. It would

Re: svn commit: r1879285 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/core.xml include/ap_mmn.h include/http_core.h include/http_protocol.h include/httpd.h modules/dav/fs/repos.c modules/test/mod_

On Mon, Jun 29, 2020 at 1:59 PM Graham Leggett wrote: > > On 29 Jun 2020, at 13:08, Yann Ylavic wrote: > > >> /** > >> * @defgroup module_magic Module Magic mime types > >> @@ -1097,6 +1138,11 @@ struct request_rec { > >> * TODO: compact elsewhere > >> */ > >> unsigned int

Re: svn commit: r1879285 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/core.xml include/ap_mmn.h include/http_core.h include/http_protocol.h include/httpd.h modules/dav/fs/repos.c modules/test/mod_

On 29 Jun 2020, at 13:08, Yann Ylavic wrote: >> /** >> * @defgroup module_magic Module Magic mime types >> @@ -1097,6 +1138,11 @@ struct request_rec { >> * TODO: compact elsewhere >> */ >> unsigned int flushed:1; >> +/** Request flags associated with this request. Use >> +

Re: svn commit: r1879285 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/core.xml include/ap_mmn.h include/http_core.h include/http_protocol.h include/httpd.h modules/dav/fs/repos.c modules/test/mod_

On Sun, Jun 28, 2020 at 1:41 AM wrote: > > Author: minfrin > Date: Sat Jun 27 23:41:00 2020 > New Revision: 1879285 > > URL: http://svn.apache.org/viewvc?rev=1879285=rev [] > --- httpd/httpd/trunk/include/httpd.h (original) > +++ httpd/httpd/trunk/include/httpd.h Sat Jun 27 23:41:00 2020 [] >

Re: svn commit: r1879285 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/core.xml include/ap_mmn.h include/http_core.h include/http_protocol.h include/httpd.h modules/dav/fs/repos.c modules/test/mod_

On 6/28/20 1:41 AM, minf...@apache.org wrote: > Author: minfrin > Date: Sat Jun 27 23:41:00 2020 > New Revision: 1879285 > > URL: http://svn.apache.org/viewvc?rev=1879285=rev > Log: > "[mod_dav_fs etag handling] should really honor the FileETag setting". > - It now does. > - Add "Digest" to