Re: svn commit: r642971 - in /httpd/httpd/trunk: include/ap_expr.h include/ap_mmn.h server/main.c server/util_expr.c

2008-03-31 Thread Ruediger Pluem
On 03/31/2008 02:17 PM, [EMAIL PROTECTED] wrote: Author: niq Date: Mon Mar 31 05:16:58 2008 New Revision: 642971 URL: http://svn.apache.org/viewvc?rev=642971view=rev Log: Flesh out ap_expr with: * Re-usable parse trees * Canonical string parser function (candidate) Modified:

Re: svn commit: r642971 - in /httpd/httpd/trunk: include/ap_expr.h include/ap_mmn.h server/main.c server/util_expr.c

2008-03-31 Thread Nick Kew
On Mon, 31 Mar 2008 22:24:50 +0200 Ruediger Pluem [EMAIL PROTECTED] wrote: I don't like exposing internals to a public API. If the API user always calls it with NULL we should hide this from the API users by using a thin wrapper. Indeed, I think clone needs to be hidden altogether, and plan

Re: svn commit: r642971 - in /httpd/httpd/trunk: include/ap_expr.h include/ap_mmn.h server/main.c server/util_expr.c

2008-03-31 Thread André Malo
* Nick Kew wrote: On Mon, 31 Mar 2008 22:24:50 +0200 Ruediger Pluem [EMAIL PROTECTED] wrote: #define CREATE_NODE(pool,name) do { \ -(name) = apr_palloc(pool, sizeof(*(name))); \ -(name)-parent = (name)-left = (name)-right = NULL; \ -