Hi --
I wrote:
What we had before was:
if (apr_atomic_casptr((volatile void**)(queue_info-recycled_pools),
new_recycle, next) == next) {
but also:
if (apr_atomic_cas32((queue_info-idlers), prev_idlers + 1,
prev_idlers) ==
Basant Kumar kukreja wrote:
Yes, unless until we clearly understand that volatile is not useful here, we
should keep it.
The thing that makes me reasonably sure this is OK (and this is for
trunk/2.4 only) is that there are other apr_atomic_*() functions used
in fdqueue.c without any
Yes, unless until we clearly understand that volatile is not useful here, we
should keep it.
Regards,
Basant.
On Fri, Dec 12, 2008 at 02:57:03PM -0800, Chris Darroch wrote:
Ruediger Pluem wrote:
Not quite sure if this is really correct because apr_atomic_casptr
wants to have a (volatile
On 12/12/2008 09:31 PM, chr...@apache.org wrote:
Author: chrisd
Date: Fri Dec 12 12:31:09 2008
New Revision: 726113
URL: http://svn.apache.org/viewvc?rev=726113view=rev
Log:
I'm not 100% sure about this, but it seems to silence the
compiler warnings generated by r101236 (which was, in
Ruediger Pluem wrote:
Not quite sure if this is really correct because apr_atomic_casptr
wants to have a (volatile void**) as first parameter.
That's what made me less than sure ... but my gcc 4.1.2 -Wall
definitely doesn't like that void** (dereferencing type-punned pointer ...).
I
