Here is the full patch.
Note there are 2 missing defines for z/OS that are added to apr_ldap.h.in.
As there is some intersection with the IBM Tivoli hits from Eric Covener's
Jan 11th post in the m4 file, I have
restricted the grep of ldap.h for the IBM string to only if host=os390.
Tivoli does
Brad Nicholes wrote:
Maybe I missed this before, but what platform or LDAP SDK does this fail on?
The Novell LDAP SDK obviously supports LDAP_DEFAULT_SIZELIMIT (-1) and
according to the OpenLDAP source code, it also supports the same functionality
if the value of sizelimit is -1 even though
Please submit a complete patch against trunk for the apr-util code that
includes the ZOS define. This should include the makefile magic that defines
APR_HAS_ZOS_LDAPSDK as well. Also include a patch for util_ldap.c that will
define APR_LDAP_SIZELIMIT if the version of apr-util does not
Patch to commit if no further comments.
Note that it does not have the ZOS define yet, and does not synch apr-util
with httpd.
to avoid synch problems i could add to util_ldap:
#ifndef APR_LDAP_SIZELIMIT
#define APR_LDAP_SIZELIMIT -1
#endif
Index: modules/ldap/util_ldap.c
Looks good, I think I like your first suggestion better, putting the #ifdef in
apr_ldap.h.in. This seems a little more straight forward rather than hiding
the value in configure.
Brad
On 3/1/2007 at 7:07 PM, in message
[EMAIL PROTECTED], David Jones
[EMAIL PROTECTED] wrote:
How about:
How about:
changes to apr_ldap.h.in:
#define APR_HAS_ZOS_LDAPSDK @apu_has_ldap_zos@
#if APR_LDAP_HAS_ZOS_LDAPSDK
#define APR_LDAP_SIZELIMIT LDAP_NO_LIMIT
#else
#ifdef LDAP_DEFAULT_LIMIT
#define APR_LDAP_SIZELIMIT LDAP_DEFAULT_LIMIT
#else
#define APR_LDAP_SIZELIMIT -1 /* equivalent to
Sorry for the delay.
We use our own z/OS specific SDK. There is also a Tivoli SDK , [see Eric
Covener's appends and
http://issues.apache.org/bugzilla/attachment.cgi?id=19394 waiting for
input], which shares some commonality with z/OS (Tivoli can accept the -1
without a problem, but it acts like
LDAP SDK differences should really be pushed down into APR-Util. In fact your
option #1 would probably be the way to go as long as it was implemented in
apr_ldap.h.in and you implemented APR_HAS_ZOS_LDAPSDK that is determined during
configure time just like the other SDKs. The #define should
What LDAP client SDK does z/OS use? (Novell, OpenLDAP, Netscape, Other???)
Brad
On 2/22/2007 at 12:52 PM, in message
[EMAIL PROTECTED], David Jones
[EMAIL PROTECTED] wrote:
Its the z/OS, has LDAP_NO_SIZELIMIT defined. Does not have nor support
LDAP_DEFAULT_SIZELIMIT
On 2/22/07, Brad
How about something alone these lines? It assumes there is nobody with
LDAP_DEFAULT_LIMIT undefined AND LDAP_NO_LIMIT defined, but still supports
and wishes to use the -1 value.
--- util_ldap.c.defaultlimitWed Feb 21 16:08:51 2007
+++ util_ldap.c.nolimit Thu Feb 15 12:50:09 2007
@@ -52,15
On 2/22/2007 at 7:12 AM, in message
[EMAIL PROTECTED], David Jones
[EMAIL PROTECTED] wrote:
How about something alone these lines? It assumes there is nobody with
LDAP_DEFAULT_LIMIT undefined AND LDAP_NO_LIMIT defined, but still supports
and wishes to use the -1 value.
---
Its the z/OS, has LDAP_NO_SIZELIMIT defined. Does not have nor support
LDAP_DEFAULT_SIZELIMIT
On 2/22/07, Brad Nicholes [EMAIL PROTECTED] wrote:
On 2/22/2007 at 7:12 AM, in message
[EMAIL PROTECTED], David
Jones
[EMAIL PROTECTED] wrote:
How about something alone these lines? It assumes there
On 2/19/2007 at 9:29 AM, in message
[EMAIL PROTECTED], Jeff Trawick
[EMAIL PROTECTED] wrote:
On 2/15/07, David Jones [EMAIL PROTECTED] wrote:
Currently util_ldap.c has a hard coded -1 as the search limit value (meaning
infinite/no limit) on ldap_search_ext_s() calls. Some platforms cannot
On 2/15/07, David Jones [EMAIL PROTECTED] wrote:
Currently util_ldap.c has a hard coded -1 as the search limit value (meaning
infinite/no limit) on ldap_search_ext_s() calls. Some platforms cannot
handle the -1, but need a 0. Linux, zoS (and others) have a LDAP_NO_LIMIT
value in ldap.h.
Below
Currently util_ldap.c has a hard coded -1 as the search limit value (meaning
infinite/no limit) on ldap_search_ext_s() calls. Some platforms cannot
handle the -1, but need a 0. Linux, zoS (and others) have a LDAP_NO_LIMIT
value in ldap.h.
Below is a patch, allows those who have LDAP_NO_LIMIT
15 matches
Mail list logo
