Re: walk caching to avoid extra authnz

2006-12-29 Thread Chris Darroch
Hi -- Chris Darroch wrote: Much appreciated, but alas, Justin pointed out a serious conflict in mod_authz_svn, and more generally, various modules may exist out there that are also expecting authnz functions to be called for every sub-request that has a different URI/filepath. [snip]

Re: walk caching to avoid extra authnz

2006-12-29 Thread Justin Erenkrantz
On 12/29/06, Chris Darroch [EMAIL PROTECTED] wrote: The main trick here is that instead of the hard-coded version string 0 for authn/z providers, AUTHN/Z_PROVIDER_VERSION_ALL_REQ and AUTHN/Z_PROVIDER_VERSION_INITIAL_REQ are defined. Without looking at the code, I'd hope that means that they

Re: walk caching to avoid extra authnz

2006-12-29 Thread Chris Darroch
Justin Erenkrantz wrote: Without looking at the code, I'd hope that means that they are version 1 providers. =) -- justin Yes, that's what I used, although I wondered if that was ideal, or whether it should be something like 0-initial-req-only ... but 1 seemed less ugly to me. :-)

Re: walk caching to avoid extra authnz

2006-12-07 Thread Chris Darroch
Hi -- William A. Rowe, Jr. wrote: It so happens I'm starting one of those cycles again right now with the changes to the mis-handling of file matches that Nick(?) corrected in trunk, and I'll study your patch in tandem. Thanks for your work!!! Much appreciated, but alas, Justin pointed

Re: walk caching to avoid extra authnz

2006-12-06 Thread Nick Kew
On Tue, 05 Dec 2006 17:06:16 -0800 Chris Darroch [EMAIL PROTECTED] wrote: Hi -- The short version of this email is, please, can people review this patch for server/request.c and see if it breaks anything? There are versions for trunk and 2.2.x. Thanks in advance!

Re: walk caching to avoid extra authnz

2006-12-06 Thread Plüm , Rüdiger , VF EITO
-Ursprüngliche Nachricht- Von: Nick Kew Gesendet: Mittwoch, 6. Dezember 2006 14:34 An: dev@httpd.apache.org In this instance, we need to work through how this relates to relevant updates leading to the CHANGES file entry: core: Do not allow internal redirects like the

Re: walk caching to avoid extra authnz

2006-12-06 Thread Nick Kew
On Wed, 6 Dec 2006 14:41:39 +0100 Plüm, Rüdiger, VF EITO [EMAIL PROTECTED] wrote: In this instance, we need to work through how this relates to relevant updates leading to the CHANGES file entry: core: Do not allow internal redirects like the DirectoryIndex of mod_dir to

Re: walk caching to avoid extra authnz

2006-12-06 Thread Justin Erenkrantz
On 12/6/06, Chris Darroch [EMAIL PROTECTED] wrote: Hi -- The short version of this email is, please, can people review this patch for server/request.c and see if it breaks anything? There are versions for trunk and 2.2.x. Thanks in advance!

Workaround (Re: walk caching to avoid extra authnz)

2006-12-06 Thread Nick Kew
On Tue, 05 Dec 2006 17:06:16 -0800 Chris Darroch [EMAIL PROTECTED] wrote: What surprised me was discovering that each sub-request (or, equally, internal redirect) went through the authnz steps despite the fact that I just had a single blanket authnz configuration for the entire directory

Re: Workaround (Re: walk caching to avoid extra authnz)

2006-12-06 Thread Justin Erenkrantz
On 12/6/06, Nick Kew [EMAIL PROTECTED] wrote: A corresponding authz hook will implement a Require inherit to enable subrequests with inherited set to be authorized, and will run ahead of normal authz hooks. Would that be a good solution here? I think you mean that if they have 'require

Re: walk caching to avoid extra authnz

2006-12-06 Thread Chris Darroch
Hi -- Thanks for taking an initial look at these patches; I reviewed them a bit more as well and did some testing this morning which resulted in a pair of small changes. One of those changes is important; it catches the condition where the current walk finds additional matches beyond those

walk caching to avoid extra authnz

2006-12-05 Thread Chris Darroch
Hi -- The short version of this email is, please, can people review this patch for server/request.c and see if it breaks anything? There are versions for trunk and 2.2.x. Thanks in advance! http://people.apache.org/~chrisd/patches/walk_cache/ I recently finished setting up mod_dav