Re: svn commit: r1753263 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_protocol.c

2016-07-18 Thread Jim Jagielski
+1. Plan for the future. > On Jul 18, 2016, at 12:32 PM, William A Rowe Jr wrote: > > Worse, in http 2.4, the first two registered methods collide with BREW and > WHEN. That said, the 'fix', if we wanted to resolve it, is to use M_INVALID > +3 as the first value. > > I

Re: svn commit: r1753263 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_protocol.c

2016-07-18 Thread William A Rowe Jr
Worse, in http 2.4, the first two registered methods collide with BREW and WHEN. That said, the 'fix', if we wanted to resolve it, is to use M_INVALID +3 as the first value. I suggest on trunk we use a value outside the bitmask range of 0-63 as INVALID and consider turning this into an array of

Re: svn commit: r1753263 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_protocol.c

2016-07-18 Thread Jim Jagielski
Doesn't this make this unsuitable for backport for 2.4? > On Jul 18, 2016, at 12:20 PM, wr...@apache.org wrote: > > Author: wrowe > Date: Mon Jul 18 16:20:27 2016 > New Revision: 1753263 > > URL: http://svn.apache.org/viewvc?rev=1753263=rev > Log: > A whole lotta nope, if you implement HTCPCP

Re: Multiple test framework errors on trunk

2016-07-18 Thread William A Rowe Jr
See http://svn.apache.org/viewvc/httpd/httpd/trunk/server/util_script.c?r1=1747469=1751138_format=h On Mon, Jul 18, 2016 at 10:17 AM, Jim Jagielski wrote: > On OSX 10.11.5 (Xcode 7.3.x), I am getting multiple errors on trunk, > with clear sailing on httpd-2.4 > > Test errors

Re: svn commit: r1753223 - /httpd/httpd/trunk/modules/http/http_protocol.c

2016-07-18 Thread Jim Jagielski
Beat me to the patch... :) > On Jul 18, 2016, at 12:02 PM, William A Rowe Jr wrote: > > On Mon, Jul 18, 2016 at 11:00 AM, Jim Jagielski wrote: > Hrm. ap_method_registry_init lacks HEAD > > And has no M_HEAD, it's M_GET. Resolved, reviewing the zany

Re: svn commit: r1753223 - /httpd/httpd/trunk/modules/http/http_protocol.c

2016-07-18 Thread William A Rowe Jr
On Mon, Jul 18, 2016 at 11:00 AM, Jim Jagielski wrote: > Hrm. ap_method_registry_init lacks HEAD And has no M_HEAD, it's M_GET. Resolved, reviewing the zany bytewise logic for any other missing identifiers. Thanks for the catch.

Re: svn commit: r1753223 - /httpd/httpd/trunk/modules/http/http_protocol.c

2016-07-18 Thread Jim Jagielski
I am getting NUMEROUS errors on trunk... HEAD is returning 501. The only test where this does NOT occur is: "HEAD /modules/cgi/perl.pl HTTP/1.1" 200 8 Looks suspicious to me... > On Jul 18, 2016, at 11:44 AM, Rüdiger Plüm wrote: > > > > On 07/18/2016 05:28 PM, William A

Re: svn commit: r1753223 - /httpd/httpd/trunk/modules/http/http_protocol.c

2016-07-18 Thread Jim Jagielski
Hrm. ap_method_registry_init lacks HEAD. > On Jul 18, 2016, at 11:57 AM, William A Rowe Jr wrote: > > Investigating, should have it clearer w/in 1/2 an hr > > > On Jul 18, 2016 10:54 AM, "Jim Jagielski" wrote: > I am getting NUMEROUS errors on trunk...

Re: Multiple test framework errors on trunk

2016-07-18 Thread Jim Jagielski
[Mon Jul 18 15:57:00.513202 2016] [core:error] [pid 6239:tid 123145317863424] [client 127.0.0.1:60655] AH00135: Invalid method in request HEAD /apache/etags/none/plus-mis/minus-ms/test.txt HTTP/1.1 > On Jul 18, 2016, at 11:55 AM, Jim Jagielski wrote: > > In fact, ALL HEADs

Re: svn commit: r1753223 - /httpd/httpd/trunk/modules/http/http_protocol.c

2016-07-18 Thread Jim Jagielski
[Mon Jul 18 15:57:00.513202 2016] [core:error] [pid 6239:tid 123145317863424] [client 127.0.0.1:60655] AH00135: Invalid method in request HEAD /apache/etags/none/plus-mis/minus-ms/test.txt HTTP/1.1 > On Jul 18, 2016, at 11:57 AM, William A Rowe Jr wrote: > >

Re: svn commit: r1753223 - /httpd/httpd/trunk/modules/http/http_protocol.c

2016-07-18 Thread William A Rowe Jr
Investigating, should have it clearer w/in 1/2 an hr On Jul 18, 2016 10:54 AM, "Jim Jagielski" wrote: > I am getting NUMEROUS errors on trunk... HEAD is returning 501. The > only test where this does NOT occur is: > > "HEAD /modules/cgi/perl.pl HTTP/1.1" 200 8 > > Looks

Re: Multiple test framework errors on trunk

2016-07-18 Thread Jim Jagielski
In fact, ALL HEADs are returning 501, except for this single one: "HEAD /modules/cgi/perl.pl HTTP/1.1" 200 8

Re: svn commit: r1753223 - /httpd/httpd/trunk/modules/http/http_protocol.c

2016-07-18 Thread Rüdiger Plüm
On 07/18/2016 05:28 PM, William A Rowe Jr wrote: > On Mon, Jul 18, 2016 at 10:22 AM, Ruediger Pluem > wrote: > > > On 07/18/2016 03:41 PM, wr...@apache.org wrote: > > Author: wrowe > > Date: Mon Jul 18

Re: Multiple test framework errors on trunk

2016-07-18 Thread Jim Jagielski
For the etags test, fails are due to 501 errors: 127.0.0.1 - - [18/Jul/2016:15:41:37 +] "HEAD /apache/etags/none/plus-mis/minus-s/test.txt HTTP/1.1" 501 235 127.0.0.1 - - [18/Jul/2016:15:41:37 +] "HEAD /apache/etags/none/plus-mis/minus-mi/test.txt HTTP/1.1" 501 236 127.0.0.1 -

Re: Multiple test framework errors on trunk

2016-07-18 Thread Jim Jagielski
On CentOS6 as well. Obviously, either something is hosed on trunk or something has changed and the test framework has not been updated... > On Jul 18, 2016, at 11:17 AM, Jim Jagielski wrote: > > On OSX 10.11.5 (Xcode 7.3.x), I am getting multiple errors on trunk, > with clear

Re: svn commit: r1753223 - /httpd/httpd/trunk/modules/http/http_protocol.c

2016-07-18 Thread William A Rowe Jr
On Mon, Jul 18, 2016 at 10:22 AM, Ruediger Pluem wrote: > > On 07/18/2016 03:41 PM, wr...@apache.org wrote: > > Author: wrowe > > Date: Mon Jul 18 13:41:26 2016 > > New Revision: 1753223 > > > > URL: http://svn.apache.org/viewvc?rev=1753223=rev > > Log: > > Simplify; this code

Multiple test framework errors on trunk

2016-07-18 Thread Jim Jagielski
On OSX 10.11.5 (Xcode 7.3.x), I am getting multiple errors on trunk, with clear sailing on httpd-2.4 Test errors are for t/apache/etags.t, t/modules/expires.t and t/modules/headers.t Sample verbose output below: # --- # ExpiresActive On ExpiresDefault "modification plus 16 days 43 minutes 15

Re: svn commit: r1753223 - /httpd/httpd/trunk/modules/http/http_protocol.c

2016-07-18 Thread Ruediger Pluem
On 07/18/2016 03:41 PM, wr...@apache.org wrote: > Author: wrowe > Date: Mon Jul 18 13:41:26 2016 > New Revision: 1753223 > > URL: http://svn.apache.org/viewvc?rev=1753223=rev > Log: > Simplify; this code is executed one per request processed, saving > an immeasurably small quantum of CPU of a

[Advisory] Apache Software Foundation Projects and "httpoxy" CERT VU#797896

2016-07-18 Thread William A Rowe Jr
Advisory: Apache Software Foundation Projects and "httpoxy" CERT VU#797896 Canonical URL: https://www.apache.org/security/asf-httpoxy-response.txt Publication: v1.0 18 July 2016 Audience This Advisory is directed to HTTP web server administrators and users of the software indicated

Re: svn commit: r1753167 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_fcgi.c

2016-07-18 Thread Luca Toscano
2016-07-18 10:54 GMT+02:00 Ruediger Pluem : Hi Ruediger, > > On 07/18/2016 10:02 AM, elu...@apache.org wrote: > > Author: elukey > > Date: Mon Jul 18 08:02:23 2016 > > New Revision: 1753167 > > > > URL: http://svn.apache.org/viewvc?rev=1753167=rev > > Log: > > mod_proxy_fcgi:

Re: svn commit: r1753167 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_fcgi.c

2016-07-18 Thread Ruediger Pluem
On 07/18/2016 10:02 AM, elu...@apache.org wrote: > Author: elukey > Date: Mon Jul 18 08:02:23 2016 > New Revision: 1753167 > > URL: http://svn.apache.org/viewvc?rev=1753167=rev > Log: > mod_proxy_fcgi: avoid loops serving proxied error documents > > This commit should solve the issue indicated