Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-26 Thread Evgeny Kotkov 
Jim Jagielski  writes:

> BTW, there are also deltas for config.m4 in modules/filters mainly
> around mod_brotli. At present what is in 2.4 seems to work fine, but
> should we consider backporting config.m4 as well?

The difference is caused by these four mentioned changes (r1761824,
r1771789, r1771827, r1779111).  With them applied, this part of the
modules/filters/config.m4 file should be identical between trunk and
2.4.x.

I proposed the whole group for the backport in r1792805 and r1792806.


Regards,
Evgeny Kotkov

Re: HTTP Server Hackathon/BOFs in Miami?

2017-04-26 Thread Rich Bowen 
I will be present, but I expect to be very busy with meetings,
feathercasts, and so on. Between events, I will hang out at a HTTP
hackathon table and work on docs stuff that I have outstanding.

On 04/26/2017 01:05 AM, William A Rowe Jr wrote:
> Reiterating the question... from the absence of any answer - I'm presuming
> our project is not germane to the coming ApacheCon event? As much as
> I enjoy the IoT field, afraid this conference may fall out of scope for me.
> 
> I know Jim registered as 'present' and presenting, Rich is registered as
> both presenting and 'responsible', and noted jfc is presenting - but with
> the TCCon sub-event I'm guessing he to is too over-committed. And
> less than a fistful of other interesting talks, but other than Daniel, not
> contributors specifically.
> 
> If anyone else in this project is either presenting, or attending, or simply
> ghosting, it would be great to know, since I have to make my travel
> decisions yesterday.
> 
> I'll be at PenguiCon Detroit this coming weekend, if anyone wants to
> catch up or toss me OSS-related questions with respect to the ASF
> or in the wider ecosystem.
> 
> 
> On Tue, Apr 18, 2017 at 1:38 PM, William A Rowe Jr  
> wrote:
>> Evaluating whether I will attend ApacheCon, the most specific reason would
>> be hackathon time. Or productive BoF sessions.
>>
>> Who all is planning to spend some time hacking at ACNA '17? Ideas for
>> projects or BoF topics?


-- 
Rich Bowen - rbo...@rcbowen.com - @rbowen
http://apachecon.com/ - @apachecon



signature.asc
Description: OpenPGP digital signature

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-26 Thread Gregg Smith 


On 4/26/2017 7:53 AM, Jim Jagielski wrote:

Thanks! Are these the full diffs for Makefile?

On Apr 26, 2017, at 10:50 AM, Gregg Smith  wrote:


On 4/26/2017 4:51 AM, Jim Jagielski wrote:



On Apr 25, 2017, at 4:34 PM, Evgeny Kotkov  wrote:

Hi all,

I noticed that the version of mod_brotli that has been backported to 2.4.x
lacks a few Makefile changes from trunk.  This results in a failing Unix
build when mod_brotli is not being built.


Hmmm I can't recreate that here on CentOS or macOS.

Nevertheless, I know that the Makefiles were diff, but the
backport didn't include those diffs so I couldn't just apply
them after the fact, so I am +1 for adding them as a "new"
backport.


Tested both IDE and command line builds.
Commited r1792753



Yes, for the legacy build.
Includes the addition to BaseAddr.ref (which conflicts from trunk due to 
the different order in which modules have been added to 2.4).

Addition to the LoadModule section of the Windows httpd.conf.

We should be good to go all the way around.

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-26 Thread Jim Jagielski 
BTW, there are also deltas for config.m4 in modules/filters mainly
around mod_brotli. At present what is in 2.4 seems to work fine, but
should we consider backporting config.m4 as well?

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-26 Thread Jim Jagielski 
Thanks! Are these the full diffs for Makefile?
> On Apr 26, 2017, at 10:50 AM, Gregg Smith  wrote:
> 
> 
> On 4/26/2017 4:51 AM, Jim Jagielski wrote:
>> 
>>> On Apr 25, 2017, at 4:34 PM, Evgeny Kotkov  
>>> wrote:
>>> 
>>> Hi all,
>>> 
>>> I noticed that the version of mod_brotli that has been backported to 2.4.x
>>> lacks a few Makefile changes from trunk.  This results in a failing Unix
>>> build when mod_brotli is not being built.
>> 
>> Hmmm I can't recreate that here on CentOS or macOS.
>> 
>> Nevertheless, I know that the Makefiles were diff, but the
>> backport didn't include those diffs so I couldn't just apply
>> them after the fact, so I am +1 for adding them as a "new"
>> backport.
>> 
> Tested both IDE and command line builds.
> Commited r1792753

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-26 Thread Gregg Smith 


On 4/26/2017 4:51 AM, Jim Jagielski wrote:



On Apr 25, 2017, at 4:34 PM, Evgeny Kotkov  wrote:

Hi all,

I noticed that the version of mod_brotli that has been backported to 2.4.x
lacks a few Makefile changes from trunk.  This results in a failing Unix
build when mod_brotli is not being built.


Hmmm I can't recreate that here on CentOS or macOS.

Nevertheless, I know that the Makefiles were diff, but the
backport didn't include those diffs so I couldn't just apply
them after the fact, so I am +1 for adding them as a "new"
backport.


Tested both IDE and command line builds.
Commited r1792753

Re: mod_brotli on windows custom log

2017-04-26 Thread Eric Covener 
On Wed, Apr 26, 2017 at 8:19 AM, Steffen  wrote:
> BrotliFilterNote ratio
> DeflateFilterNote ratio

You should (must) pick different parameters here.

-- 
Eric Covener
cove...@gmail.com

mod_brotli on windows custom log

2017-04-26 Thread Steffen 


Added mod_brotli  to the 2.4.26-Dev with Apr & Apr-utit 1.6.0 and 
openssl 1.1.0e


See https://www.apachelounge.com/viewtopic.php?p=35266#35266

With the help of Gregg.


Noticed the following:

Have:


SetOutputFilter BROTLI_COMPRESS;DEFLATE
SetEnvIfNoCase Request_URI \.(?:gif|jpg|png|zip|pdf|rar|asc|js|css)$ 
no-gzip no-brotli dont-vary



BrotliFilterNote ratio
LogFormat '"%r" %b (%{ratio}n) "%{User-agent}i"' brotli
CustomLog "d:/log/apache/brotli.log" brotli

DeflateFilterNote ratio
LogFormat '"%r" %b (%{ratio}n) "%{User-agent}i"' deflate
CustomLog "d:/log/apache/deflate.log" deflate

In both logs deflate and brotli the log line are all the same, so we 
cannot see the diff between gzip and br.


Is this by design ?

brotli:
"GET /download/VC11/ HTTP/1.1" 4944 (30) "Mozilla/5.0 (Windows NT 6.1; 
WOW64; rv:47.0) Gecko/20100101 Firefox/47.0"


"GET /robots.txt HTTP/1.1" 156 (47) "ltx71 - (http://ltx71.com/)"
"GET /viewtopic.php?p=3211 HTTP/1.1" 5844 (22) "Mozilla/5.0 
(compatible; YandexBot/3.0; +http://yandex.com/bots)"
"GET /images/ne.gif HTTP/1.1" 890 (-) "Mozilla/5.0 (Windows NT 6.1; 
WOW64; rv:47.0) Gecko/20100101 Firefox/47.0"
"GET /download/win64/ HTTP/1.1" 4481 (29) "Mozilla/5.0 (Windows NT 
10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) 
Chrome/57.0.2987.133 Safari/537.36"


deflate:

"GET /download/VC11/ HTTP/1.1" 4944 (30) "Mozilla/5.0 (Windows NT 6.1; 
WOW64; rv:47.0) Gecko/20100101 Firefox/47.0"

"GET /robots.txt HTTP/1.1" 156 (47) "ltx71 - (http://ltx71.com/)"
"GET /viewtopic.php?p=3211 HTTP/1.1" 5844 (22) "Mozilla/5.0 
(compatible; YandexBot/3.0; +http://yandex.com/bots)"
"GET /images/ne.gif HTTP/1.1" 890 (-) "Mozilla/5.0 (Windows NT 6.1; 
WOW64; rv:47.0) Gecko/20100101 Firefox/47.0"
"GET /download/win64/ HTTP/1.1" 4481 (29) "Mozilla/5.0 (Windows NT 
10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) 
Chrome/57.0.2987.133 Safari/537.36"

Re: HTTP Server Hackathon/BOFs in Miami?

2017-04-26 Thread Jim Jagielski 
I have never been productive at Hackathons. The discussion is great
and all that, but as far as the actual coding is concerned, I am too
accustomed to having a certain environment when coding, including
my desktop cpu, full keyboard and monitor. I just can't do serious
coding/hacking on a laptop. This old dog just can't.

Re: HTTP Server Hackathon/BOFs in Miami?

2017-04-26 Thread Eric Covener 
On Wed, Apr 26, 2017 at 1:05 AM, William A Rowe Jr  wrote:
> Reiterating the question... from the absence of any answer

I'm not able to make it this year.

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-26 Thread Jim Jagielski 

> On Apr 25, 2017, at 4:34 PM, Evgeny Kotkov  
> wrote:
> 
> Hi all,
> 
> I noticed that the version of mod_brotli that has been backported to 2.4.x
> lacks a few Makefile changes from trunk.  This results in a failing Unix
> build when mod_brotli is not being built.

Hmmm I can't recreate that here on CentOS or macOS.

Nevertheless, I know that the Makefiles were diff, but the
backport didn't include those diffs so I couldn't just apply
them after the fact, so I am +1 for adding them as a "new"
backport.

Two questions: Macro conversion tool? Any success with mod_dbd and SQLite3?

2017-04-26 Thread Tom Browder 
I'm running httpd 2.4.25 on Debian 8, 64-bit.  I use macros for my 10 or so
vhosts on one server.

I have not yet been able to get mod_dbd to initialize my sqlite3 db for
authn and am going back to the file method until I know what's wrong.

I posted my macro on the users' list yesterday.

Is there any apache tool to convert the httpd.conf file with its includes
and macros into the final product for visual debugging?

Is there a working httpd.conf file doing successful dbd authn and form
login with sqlite3 that can be seen by the public? (Maybe in testing--going
to look there soon.)

Thanks.

Best regards,

-Tom

Re: svn commit: r1707087 - /httpd/httpd/trunk/modules/debugging/mod_bucketeer.c

2017-04-26 Thread Stefan Eissing 

> Am 26.04.2017 um 11:14 schrieb Plüm, Rüdiger, Vodafone Group 
> :
> 
> 
> 
>> -Ursprüngliche Nachricht-
>> Von: Stefan Eissing [mailto:stefan.eiss...@greenbytes.de]
>> Gesendet: Mittwoch, 26. April 2017 10:55
>> An: dev@httpd.apache.org
>> Betreff: Re: svn commit: r1707087 -
>> /httpd/httpd/trunk/modules/debugging/mod_bucketeer.c
>> 
>> Eh, not really into mod_bucketeer and its use cases, but some
>> observations after a quick scan:
>> 
>> line 99:
>>rv = ap_pass_brigade(f->next, ctx->bb);
>>apr_brigade_cleanup(ctx->bb);
>> 
>> line 146:
>>rv = ap_pass_brigade(f->next, ctx->bb);
>>if (rv) {
>>return rv;
>>}
>>apr_brigade_cleanup(ctx->bb);
>> 
>> such things only work if an EOS always comes *before* an EOR bucket
>> (case 1)
>> or of no DATA bucket of any kind follows an EOR.
> 
> Correct, but with the BUCKETEER filter being a resource filter that should
> not happen.

Because the implementations of everything else in the server do not do it? 
Should we then add a filter that checks exactly that? 

I am not saying this mockingly, but am serious. If we have such contracts 
implicit somewhere (and afaik not documented), would it not be better to make 
that explicit? The performance cost of a filter inspecting bucket orderings 
should be negligible, or?

-Stefan

AW: svn commit: r1707087 - /httpd/httpd/trunk/modules/debugging/mod_bucketeer.c

2017-04-26 Thread Plüm , Rüdiger , Vodafone Group 


> -Ursprüngliche Nachricht-
> Von: Stefan Eissing [mailto:stefan.eiss...@greenbytes.de]
> Gesendet: Mittwoch, 26. April 2017 10:55
> An: dev@httpd.apache.org
> Betreff: Re: svn commit: r1707087 -
> /httpd/httpd/trunk/modules/debugging/mod_bucketeer.c
> 
> Eh, not really into mod_bucketeer and its use cases, but some
> observations after a quick scan:
> 
> line 99:
> rv = ap_pass_brigade(f->next, ctx->bb);
> apr_brigade_cleanup(ctx->bb);
> 
> line 146:
> rv = ap_pass_brigade(f->next, ctx->bb);
> if (rv) {
> return rv;
> }
> apr_brigade_cleanup(ctx->bb);
> 
> such things only work if an EOS always comes *before* an EOR bucket
> (case 1)
> or of no DATA bucket of any kind follows an EOR.

Correct, but with the BUCKETEER filter being a resource filter that should
not happen.

Regards

Rüdiger

Re: svn commit: r1707087 - /httpd/httpd/trunk/modules/debugging/mod_bucketeer.c

2017-04-26 Thread Stefan Eissing 
Eh, not really into mod_bucketeer and its use cases, but some observations 
after a quick scan:

line 99:
rv = ap_pass_brigade(f->next, ctx->bb);
apr_brigade_cleanup(ctx->bb);

line 146:
rv = ap_pass_brigade(f->next, ctx->bb);
if (rv) {
return rv;
}
apr_brigade_cleanup(ctx->bb);
 
such things only work if an EOS always comes *before* an EOR bucket (case 1)
or of no DATA bucket of any kind follows an EOR.

I think, the code should check for EOR specifically and then get also out
of the way *without* a brigade cleanup afterwards.

As to EOR buckets and HTTP/2, the EOR buckets do not get forwarded to the main
connection. Instead there are H2EOS buckets as indicators that all stream data
has been sent. Destruction of those triggers the shutdown and dealloc of 
streams.

This can happen
a) after the request processing has finished and there is an EOR bucket on hold.
b) before the request is done and the EOR has yet to arrive (or the slave 
connection
   used in the request processing is aborted).
c) On a stream answered without ever generating a request_rec

As to crashes in http2: since 1.10.1 there are no crashes in HTTP/2 known to 
me. Stefan Priebe discovered deadlocks which I fixed in 1.10.2 and 1.10.3, but 
no more crashes. There is a reported assertion failure in mod_proxy_http2, but 
that's it.

Cheers,

Stefan

> Am 26.04.2017 um 01:04 schrieb Jacob Champion :
> 
> On 04/25/2017 04:02 PM, Yann Ylavic wrote:
>> Let me remind this a bit, it's been a long time :)
>> Will have a look at it tomorrow hopefully..
> 
> No problem; sorry for springing it on you again after two months of silence. 
> :D
> 
> --Jacob

AW: AW: svn commit: r1707087 - /httpd/httpd/trunk/modules/debugging/mod_bucketeer.c

2017-04-26 Thread Plüm , Rüdiger , Vodafone Group 


> -Ursprüngliche Nachricht-
> Von: Jacob Champion [mailto:champio...@gmail.com]
> Gesendet: Mittwoch, 26. April 2017 00:23
> An: dev@httpd.apache.org; Plüm, Rüdiger, Vodafone Group
> 
> Betreff: Re: AW: svn commit: r1707087 -
> /httpd/httpd/trunk/modules/debugging/mod_bucketeer.c
> 
> On 02/15/2017 10:10 AM, Plüm, Rüdiger, Vodafone Group wrote:
> > How about creating it from c->pool and storing it in c->notes for the
> lifetime
> > of c?
> 
> Would that be unsafe for HTTP/2? Can multiple requests (that use
> ap_request_core_filter) be active on the same connection at once?

IMHO ap_request_core will use different slave connections then.
Stefan may prove me wrong, but we still won't have more than one request
in processing at the same time per slave connection

Regards

Rüdiger