Re: Trunk DEFAULT_REL_STATEDIR undeclared

2020-05-07 Thread Steffen
Current trunk has not this error anymore, thanks. Later I build the rest. Seen already other errors, I have to do some adjustments here because added includes. For example mod_ssl now needs server/core.h. On Thursday 07/05/2020 at 14:35, Steffen wrote: Please fix in trunk. Then I test

Re: [PATCH] mod_ldap: fix apr_ldap_rebind_remove() use

2020-05-07 Thread Eric Covener
On Thu, May 7, 2020 at 9:39 AM Joe Orton wrote: > > On Thu, May 07, 2020 at 08:06:00AM -0400, Eric Covener wrote: > > On Thu, May 7, 2020 at 2:04 AM Ruediger Pluem wrote: > > > Not looked at the problem further, but there is now a PR for this: > > > > > >

Re: [PATCH] mod_ldap: fix apr_ldap_rebind_remove() use

2020-05-07 Thread Joe Orton
On Thu, May 07, 2020 at 08:06:00AM -0400, Eric Covener wrote: > On Thu, May 7, 2020 at 2:04 AM Ruediger Pluem wrote: > > Not looked at the problem further, but there is now a PR for this: > > > > https://bz.apache.org/bugzilla/show_bug.cgi?id=64414 > > > > Maybe this revives the discussion :-) >

Re: [PATCH] mod_ldap: fix apr_ldap_rebind_remove() use

2020-05-07 Thread Eric Covener
> > And can we still do an ldap_unbind_s(ldc->ldap); if we did an > > apr_ldap_rebind_remove(ldc->ldap); before? > > This is a good point. For the IBM/Tivoli SDK the callback can be > called a 2nd time as a cleanup (in the IBM SDK terms, not APR). This > will trigger a full/failing search of

Re: Trunk DEFAULT_REL_STATEDIR undeclared

2020-05-07 Thread Luca Toscano
On Thu, May 7, 2020 at 1:42 PM Joe Orton wrote: > > On Thu, May 07, 2020 at 12:55:03PM +0200, Steffen wrote: > > Tried to build trunk again after 2 years :) > > > > server\core.c(5618,58): error C2065: 'DEFAULT_REL_STATEDIR': undeclared > > identifier > > That was added in r1842929 (October 2018)

Re: Trunk DEFAULT_REL_STATEDIR undeclared

2020-05-07 Thread Steffen
Please fix in trunk. Then I test it further. You say : whatever. I can act in some way like Travis, even running/testing. I do not know Travis and the goal you want. Some points to consider. - Win32 and Win64 - Monthly updates Windows and Visual Studio - To test ? Is there a test

Re: [PATCH] mod_ldap: fix apr_ldap_rebind_remove() use

2020-05-07 Thread Eric Covener
On Wed, Apr 29, 2020 at 2:43 PM Ruediger Pluem wrote: > > > > On 4/29/20 5:02 PM, Eric Covener wrote: > > On Wed, Apr 29, 2020 at 9:29 AM Joe Orton wrote: > >> > >> In uldap_connection_unbind, apr_ldap_rebind_remove() is always passed > >> NULL since ldc->ldap is either NULL on entry or is set

Re: [PATCH] mod_ldap: fix apr_ldap_rebind_remove() use

2020-05-07 Thread Eric Covener
> My hope is that the httpd-only fix will eliminate the leaks and the > locking will not be too much relative to ldap costs, especially w/ the > caching in mod_ldap. Above is wrong since there is really no leak currently as Joe pointed out, the apr_pool_clear is going to remove the entry with its

Re: [PATCH] mod_ldap: fix apr_ldap_rebind_remove() use

2020-05-07 Thread Eric Covener
On Thu, May 7, 2020 at 2:04 AM Ruediger Pluem wrote: > > > > On 4/30/20 11:34 AM, Joe Orton wrote: > > On Wed, Apr 29, 2020 at 03:09:28PM -0400, Eric Covener wrote: > >> On Wed, Apr 29, 2020 at 2:43 PM Ruediger Pluem wrote: > >>> Hm. Don't we need to do the apr_pool_clear(ldc->rebind_pool); in

Re: Trunk DEFAULT_REL_STATEDIR undeclared

2020-05-07 Thread Joe Orton
On Thu, May 07, 2020 at 12:55:03PM +0200, Steffen wrote: > Tried to build trunk again after 2 years :) > > server\core.c(5618,58): error C2065: 'DEFAULT_REL_STATEDIR': undeclared > identifier That was added in r1842929 (October 2018) and nobody has noticed Windows was broken before now?

Trunk DEFAULT_REL_STATEDIR undeclared

2020-05-07 Thread Steffen
Tried to build trunk again after 2 years :) server\core.c(5618,58): error C2065: 'DEFAULT_REL_STATEDIR': undeclared identifier Steffen

Re: [PATCH] mod_ldap: fix apr_ldap_rebind_remove() use

2020-05-07 Thread Ruediger Pluem
On 4/30/20 11:34 AM, Joe Orton wrote: > On Wed, Apr 29, 2020 at 03:09:28PM -0400, Eric Covener wrote: >> On Wed, Apr 29, 2020 at 2:43 PM Ruediger Pluem wrote: >>> Hm. Don't we need to do the apr_pool_clear(ldc->rebind_pool); in any case >>> if ldc->ChaseReferrals == AP_LDAP_CHASEREFERRALS_ON