Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-04-12 Thread Yann Ylavic
On Wed, Apr 12, 2023 at 1:31 PM Eric Covener wrote: > > On Wed, Apr 12, 2023 at 6:36 AM Yann Ylavic wrote: > > > > On Wed, Apr 12, 2023 at 12:26 PM Yann Ylavic wrote: > > > > > > On Wed, Apr 12, 2023 at 12:18 PM ylavic wrote: > > > > > > > > @ylavic approved this pull request. > > > > > > > >

Re: svn commit: r1909073 - in /httpd/httpd/trunk/docs/manual: mod/mod_rewrite.xml rewrite/flags.xml

2023-04-12 Thread Eric Covener
On Wed, Apr 12, 2023 at 2:52 AM Ruediger Pluem wrote: > > > > On 4/11/23 11:36 PM, cove...@apache.org wrote: > > Author: covener > > Date: Tue Apr 11 21:36:55 2023 > > New Revision: 1909073 > > > > URL: http://svn.apache.org/viewvc?rev=1909073=rev > > Log: > > PR66563: escaping of url releated

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-04-12 Thread Eric Covener
On Wed, Apr 12, 2023 at 6:36 AM Yann Ylavic wrote: > > On Wed, Apr 12, 2023 at 12:26 PM Yann Ylavic wrote: > > > > On Wed, Apr 12, 2023 at 12:18 PM ylavic wrote: > > > > > > @ylavic approved this pull request. > > > > > > Three approvals to get ci started? > > > > Nope.. It seems that gh

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-04-12 Thread Ruediger Pluem
On 4/12/23 12:35 PM, Yann Ylavic wrote: > On Wed, Apr 12, 2023 at 12:26 PM Yann Ylavic wrote: >> >> On Wed, Apr 12, 2023 at 12:18 PM ylavic wrote: >>> >>> @ylavic approved this pull request. >>> >>> Three approvals to get ci started? >> >> Nope.. It seems that gh actions don't run for PRs

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-04-12 Thread Yann Ylavic
On Wed, Apr 12, 2023 at 12:26 PM Yann Ylavic wrote: > > On Wed, Apr 12, 2023 at 12:18 PM ylavic wrote: > > > > @ylavic approved this pull request. > > > > Three approvals to get ci started? > > Nope.. It seems that gh actions don't run for PRs whatever we do. > The docs[1] say that there should

ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-04-12 Thread Yann Ylavic
On Wed, Apr 12, 2023 at 12:18 PM ylavic wrote: > > @ylavic approved this pull request. > > Three approvals to get ci started? Nope.. It seems that gh actions don't run for PRs whatever we do. The docs[1] say that there should be an "Approve and run" button near the "workflow awaiting approval"

Re: svn commit: r1909073 - in /httpd/httpd/trunk/docs/manual: mod/mod_rewrite.xml rewrite/flags.xml

2023-04-12 Thread Ruediger Pluem
On 4/11/23 11:36 PM, cove...@apache.org wrote: > Author: covener > Date: Tue Apr 11 21:36:55 2023 > New Revision: 1909073 > > URL: http://svn.apache.org/viewvc?rev=1909073=rev > Log: > PR66563: escaping of url releated server vars > > Modified: >