Re: release roll soon?

2021-09-09 Thread Gregg Smith
Since OpenSSL 3.0.0 GA came out yesterday (Californuts time) I think it would be nice to have r1891138 backported for those wishing to try it out. What you say? Cheers, Gregg

Re: [VOTE] Release httpd-2.4.46

2020-08-03 Thread Gregg Smith
On 8/1/2020 7:13 AM, Daniel Ruggeri wrote: Hi, all;    Third time is a charm! Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ I would like to call a VOTE over the next few days to release this candidate tarball as 2.4.46: [ ] +1:

Re: Trunk errors

2020-05-08 Thread Gregg Smith
Hi Steffen, Assuming your building in the IDE as I know to be your usual; On 5/8/2020 4:59 AM, Steffen wrote: Tried revision 1877505. libhttpd : miss in trunk modules\http\http_etag.c. Moved the one from Branches to include, libhttpd builds then, is that ok ? Yes to get it to build for

Re: [VOTE] Release httpd-2.4.43

2020-03-28 Thread Gregg Smith
On 3/26/2020 7:50 AM, Daniel Ruggeri wrote: Hi, all;    Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ I would like to call a VOTE over the next few days to release this candidate tarball as 2.4.43: [X] +1: It's not just good, it's

Re: [VOTE] Release httpd-2.4.42

2020-03-23 Thread Gregg Smith
On 3/23/2020 8:18 AM, Daniel Ruggeri wrote: Hi, all;    Per the issues surfaced/fixed, I'll go ahead and declare this release as dead-on-the vine. I'll target another T later this week, hopefully after the discussion around OpenSSL versioning plays out.    How about Thursday? +1

Re: [VOTE] Release httpd-2.4.40

2019-08-03 Thread Gregg Smith
On 8/3/2019 6:51 AM, Daniel Ruggeri wrote: Hi, all;    Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ [X] +1: It's good enough! VC14 & 15 x86 & x64 w/ makefiles Opps, looks like the APLOGNO's didn't get filled in. I'm still ok

Re: svn commit: r1855519 - in /httpd/httpd/trunk/modules/http2: NWGNUmod_http2 mod_http2.dsp

2019-03-14 Thread Gregg Smith
Thanks Stefan :) On 3/14/2019 6:39 AM, ic...@apache.org wrote: Author: icing Date: Thu Mar 14 13:39:21 2019 New Revision: 1855519 URL: http://svn.apache.org/viewvc?rev=1855519=rev Log: Uplift of relevante changes of r1855479 in branches/2.4.x, re disappearance of h2_ngn_shed.* sources.

Regression?

2019-02-18 Thread Gregg Smith
When setting a header it used to set the header case-sensitive as configured. Now with 2.4.38 it sets in all lower case. Regression? Header always set X-Xss-Protection "1; mode=block" Result; 2.4.37: X-Xss-Protection: 1; mode=block 2.4.38: x-xss-protection: 1; mode=block If I'm reading the RFC

Re: Apache Win crashes with mod_md with no Applink sim

2018-10-19 Thread Gregg Smith
I objected earlier but am reversing my objection after looking through applink.c and the explanation of what it does below. Worse case there's a very small bit of unused code in httpd.exe. Steffen tried one of my binaries and told me off-list the results so it seems it is needed, even when

Re: [Discussion] Limit the scope of 2.4.x patches until 2.4.next is released?

2018-10-15 Thread Gregg Smith
On 10/15/2018 7:10 AM, William A Rowe Jr wrote: Like my beg for getting us to the 2.4.35 release tag, I'd like to propose we keep patches to branches/2.4.x/ generally within the scope of straightening out the remaining quirks related to the OpenSSL 1.1.1 API and library behavior changes (and

Re: svn commit: r1748461 - in /httpd/httpd/branches/2.2.x: ./ CHANGES support/ab.c

2018-10-13 Thread Gregg Smith
3/2018 11:22 AM, William A Rowe Jr wrote: On Sat, Oct 13, 2018 at 12:00 PM Gregg Smith wrote: On 10/13/2018 8:32 AM, William A Rowe Jr wrote: Sorry, I don't understand. Gregg, can you shed some insight here? For both, applink.c is helpful if the OpenSSL .dll files are created with a differ

Re: svn commit: r1748461 - in /httpd/httpd/branches/2.2.x: ./ CHANGES support/ab.c

2018-10-13 Thread Gregg Smith
7, 2018 at 7:05 PM William A Rowe Jr wrote: So we kind of left this hanging... On Wed, Jun 15, 2016 at 2:35 PM Gregg Smith wrote: On 6/15/2016 9:20 AM, William A Rowe Jr wrote: In building httpd.exe, some users don't build and install openssl. It isn't going to be possible to simply #inc

Re: NOTICE: Intent to T 2.4.36

2018-10-10 Thread Gregg Smith
FWIW, I've been running 2.4.36-dev at revision 1841586 for 19 days 35 minutes as of this writing and I've seen no problems up to this point. Granted I only get a few thousand hits a day and not millions but so far so good. Haven't had many tls/1.3 but I would assume that's to be expected for

Re: [VOTE] Release httpd-2.4.35

2018-09-19 Thread Gregg Smith
On 9/17/2018 5:56 PM, Daniel Ruggeri wrote: Hi, all;    Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ I would like to call a VOTE over the next few days to release this candidate tarball as 2.4.35: [ ] +1: It's not just good, it's

Re: 2.4.35 in Sept?

2018-09-13 Thread Gregg Smith
On 9/12/2018 1:47 PM, Jim Jagielski wrote: What improvements do you have to suggest to improve upon this? Do you recommend a longer vote time? Do you recommend beta and/or release-candidates? Do you recommend that the 1st born of all voters be held in a camp until the release has "proven"

Re: svn commit: r1832716 - /httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy.mak

2018-06-02 Thread Gregg Smith
if not many. On 6/2/2018 10:11 AM, William A Rowe Jr wrote: Then let's put every modules/* directory /I into the list now across all .mak/.dsp and cmakelists, just as the Unix build does? Then this should not come up again until a new modules/Foo tree arrives? WDYT? On Sat, Jun 2, 2018, 12:01 Gregg

Re: svn commit: r1832198 - /httpd/httpd/trunk/support/win32/ApacheMonitor.c

2018-05-25 Thread Gregg Smith
Hi Christophe, This compiles and ApacheMonitor works. Tested on VC14 & 11. Cheers, Gregg On 5/24/2018 1:36 PM, jaillet...@apache.org wrote: Author: jailletc36 Date: Thu May 24 20:36:26 2018 New Revision: 1832198 URL: http://svn.apache.org/viewvc?rev=1832198=rev Log: Success of

Re: TLSv1.3

2018-04-09 Thread Gregg Smith
Fashionably late to the party but I've built it on Windows and it works for me on FF Nightly. Thanks Stefan for getting tls1.3 in and working. Cheers On 4/4/2018 4:24 AM, Stefan Eissing wrote: Thanks for the tip. Unfortunately, my FF 58.0.2 and 59.0.2 still keeps doing TLSv1.2 while the

Re: mod_md : not possible to use Lets-Encrypt-Win-Simple

2018-03-18 Thread Gregg Smith
My read on the original post: First we have stated that "For mod_ssl to work in the vote release, mod_md must also be included..." That is what I honed in on. Apache will not start if there's a module specific directive without that module being loaded. Since the OP states that *mod_ssl*

Re: [VOTE] Release httpd-2.4.32

2018-03-10 Thread Gregg Smith
On 3/9/2018 6:49 PM, Daniel Ruggeri wrote: Hi, all; Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ I would like to call a VOTE over the next few days to release this candidate tarball as 2.4.32: [+1]: So far, so good.

Re: Current branche 2.4.30-dev issues

2018-02-25 Thread Gregg Smith
on nearly every candidate. Thanks for your efforts and enthusiasm Gregg, I'm not about to start ignoring your input, Cheers Bill On Feb 25, 2018 14:17, "Gregg Smith" <g...@gknw.net> wrote: On 2/23/2018 10:24 AM, William A Rowe Jr wrote: On Fri, Feb 23, 2018 at 12:0

Re: Current branche 2.4.30-dev issues

2018-02-25 Thread Gregg Smith
On 2/23/2018 10:24 AM, William A Rowe Jr wrote: On Fri, Feb 23, 2018 at 12:01 PM, Steffen wrote: Op 18 feb. 2018 om 17:57 heeft Eric Covener het volgende geschreven: On Sun, Feb 18, 2018 at 11:53 AM, Steffen wrote: On

Re: svn commit: r1807709 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_ssl.xml modules/ssl/mod_ssl.c modules/ssl/ssl_engine_config.c modules/ssl/ssl_engine_init.c modules/ssl/ssl_private.h

2018-01-22 Thread Gregg Smith
Stefan, Yes, that and vhost.c would. Gregg On 1/22/2018 12:29 AM, Stefan Eissing wrote: Gregg, that'd mean we need an AP_DECLARE on that in http_vhost.h? Would that suffice? Cheers, Stefan Am 20.01.2018 um 03:50 schrieb Gregg Smith <g...@gknw.net>: Hi Stefan, Sp

Re: svn commit: r1807709 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_ssl.xml modules/ssl/mod_ssl.c modules/ssl/ssl_engine_config.c modules/ssl/ssl_engine_init.c modules/ssl/ssl_private.h

2018-01-19 Thread Gregg Smith
Hi Stefan, Specific to ssl_engine_config.c, on Win32 we need to have ap_parse_vhost_addrs() exported from vhost.c. Cheers, G On 9/8/2017 3:29 AM, ic...@apache.org wrote: Author: icing Date: Fri Sep 8 10:29:53 2017 New Revision: 1807709 URL: http://svn.apache.org/viewvc?rev=1807709=rev

Re: Current branche 2.4.x error

2018-01-15 Thread Gregg Smith
Done. trunk r1821195 2.4.x r1821196 On 1/15/2018 8:53 AM, Steffen wrote: Gregg must have a look in the .mak files maybe better he commits (as usual). Added in libhttpd.dsp : SOURCE=.\server\config.c # End Source File +# Begin Source File + +SOURCE=.\server\util_debug.c +# End Source File

Re: svn commit: r1820578 - /httpd/httpd/branches/2.4.x-mod_md/os/win32/BaseAddr.ref

2018-01-09 Thread Gregg Smith
Everything in 2.4 is also in trunk with the exception of the .mak/dep files AFAIK. BaseAddr.ref will not merge/backport to 2.4 w/o conflict is all, like CHANGES. If any module in trunk is not being built then please do share Steffen on which module/s is/are not being built. Yann, your

Re: mod_ssl versions (for mod_md)

2018-01-06 Thread Gregg Smith
On 1/5/2018 2:25 PM, Yann Ylavic wrote: Hi Steffen, On Fri, Jan 5, 2018 at 10:26 PM, Steffen wrote: What is the one we have to test for next 2.4.30, special mod_md 1.1.8 I have just synchonized the 2.4.x-mod_md branch with 2.4.x (resolving only a tiny conflict in a

Re: [VOTE] Release Apache httpd 2.4.29 as GA

2017-10-20 Thread Gregg Smith
Well I got it now thanks mostly to your instructions Steefen, took awhile but once I put the the pieces together I see what needs to be done. On 10/20/2017 1:44 AM, Steffen wrote: Nope, just double clicking Apache.dsw does now not create the xml solution.  And without xml solution  httpd

Re: [VOTE] Release Apache httpd 2.4.29 as GA

2017-10-19 Thread Gregg Smith
On 10/19/2017 5:49 PM, William A Rowe Jr wrote: On Thu, Oct 19, 2017 at 4:15 PM, Steffen wrote: I said before: In Apache.dsw is now project xml removed, it is not building out of the box with current released apr-util. With coming apr-util 1.6.1 it should be possible

Re: [VOTE] Release Apache httpd 2.4.28 as GA

2017-09-28 Thread Gregg Smith
+1 to doing a 2.4.29 next week with these issues fixed. On 9/27/2017 9:21 PM, William A Rowe Jr wrote: The assert() has me concerned, and Steffen's report is problematic. He has a vote but hasn't cast it. At this moment I'm -0 and would spin a 2.4.29 next week to address these issues, unless

Re: [VOTE] Release Apache httpd 2.4.27 as GA

2017-07-08 Thread Gregg Smith
On Jul 6, 2017, at 1:45 PM, Jim Jagielski wrote: The pre-release test tarballs for Apache httpd version 2.4.27 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.27 GA. +1 Windows

Re: [VOTE] Release httpd-2.2.34

2017-07-07 Thread Gregg Smith
On 7/6/2017 12:33 PM, William A Rowe Jr wrote: Your votes on two decisions, please? [+1] Release 2.2.34 as legacy GA [+1] Retire the 2.2.x branch from any further maintenance.

Re: svn commit: r1799731 - in /httpd/httpd/trunk: CHANGES server/request.c

2017-06-26 Thread Gregg Smith
Sorry Bill for the off-list mail now twice but either the list or thunderbird's behavior with this list has changed. I'll assume the former since I do not see the reply-to dev@ header anymore. On 6/24/2017 10:02 AM, William A Rowe Jr wrote: On Sat, Jun 24, 2017 at 12:49 AM,

Re: [VOTE] Release Apache httpd 2.4.26 as GA

2017-06-14 Thread Gregg Smith
On 6/13/2017 10:33 AM, Jim Jagielski wrote: The pre-release test tarballs for Apache httpd version 2.4.26 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.26 GA. [ ] +1: Good to go [ ] +0: meh [ ] -1: Danger

Re: The drive for 2.4.26

2017-05-22 Thread Gregg Smith
Yes it did, thanks for following up. On 5/22/2017 9:23 AM, Jacob Champion wrote: On 04/20/2017 01:06 PM, Gregg Smith wrote: This is ApacheBench, Version 2.3 <$Revision: 1750960 $> Same result with trunk, it just hangs. Glad it's not just Windows! Gregg, did Rainer's patch work f

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-30 Thread Gregg Smith
On 4/30/2017 5:36 AM, Jan Ehrhardt wrote: The problem with CMake is that it does not build all things, that AL and AH put in their distributions. CMake will build Apr 1.6 and Apr-util 1.6, including apr_crypto_openssl-1.dll (1.0.2 or 1.1.0) in one go. Yes Jan I realize this but "recommend"

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-29 Thread Gregg Smith
On 4/29/2017 5:19 PM, Gregg Smith wrote: Bill, viewing the complete thread your reasoning here should have precluded this discussion years ago when pcre went to cmake, so at or before 2.4.0. After all, it's the only way to build pcre which is a hard requirement, not soft like brotli. I

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-29 Thread Gregg Smith
On 4/28/2017 9:35 AM, Jan Ehrhardt wrote: William A Rowe Jr in gmane.comp.apache.devel (Fri, 28 Apr 2017 10:30:03 -0500): You might have missed my thought here... suggesting that the CMake not-so-experimental build become recommended for users who want to build all the modules in one go

Re: The drive for 2.4.26

2017-04-29 Thread Gregg Smith
Yes, and only with the legacy build and then only with the IDE. Those files are static. If you build at the command line it should "just work." When I built with apr 1.5 however apr_crypto_openssl would not build with openssl 1.1.0. I cannot see how that has changed.. On 4/29/2017 1:42 AM,

Re: svn commit: r1792912 - in /httpd/httpd/branches/2.4.x/modules/filters: mod_brotli.dsp mod_brotli.mak

2017-04-29 Thread Gregg Smith
No, libs/exe still land in the source root. On 4/28/2017 8:35 AM, William A Rowe Jr wrote: Wouldn't there be a corresponding change to LIBPATH? On Thu, Apr 27, 2017 at 10:17 AM, wrote: Author: gsmith Date: Thu Apr 27 15:17:57 2017 New Revision: 1792912 URL:

Re: The drive for 2.4.26

2017-04-29 Thread Gregg Smith
APR 1.6 is needed for apr_crypto_openssl, obviously. ABS: Not sure. When I originally tried building w/ APR 1.5 it didn't work, but it didn't work with OpenSSL 1.1 and APR 1.6 either. That has now been fixed by Rainer. Have not tried 1.5/1.1.0 w/ abs yet so I simply don't know. Feel free to

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-26 Thread Gregg Smith
On 4/26/2017 7:53 AM, Jim Jagielski wrote: Thanks! Are these the full diffs for Makefile? On Apr 26, 2017, at 10:50 AM, Gregg Smith <g...@gknw.net> wrote: On 4/26/2017 4:51 AM, Jim Jagielski wrote: On Apr 25, 2017, at 4:34 PM, Evgeny Kotkov <evgeny.kot...@visualsvn.com> wrote:

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-26 Thread Gregg Smith
On 4/26/2017 4:51 AM, Jim Jagielski wrote: On Apr 25, 2017, at 4:34 PM, Evgeny Kotkov wrote: Hi all, I noticed that the version of mod_brotli that has been backported to 2.4.x lacks a few Makefile changes from trunk. This results in a failing Unix build when

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-25 Thread Gregg Smith
Actually, I'll test here in a while and commit tomorrow. On 4/25/2017 6:20 PM, Gregg Smith wrote: I have one, command line makefiles and all. I just haven't had time to run a test build yet though lloking at it looks fine, but I like to test first. On 4/25/2017 2:07 PM, Yann Ylavic wrote

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-25 Thread Gregg Smith
I have one, command line makefiles and all. I just haven't had time to run a test build yet though lloking at it looks fine, but I like to test first. On 4/25/2017 2:07 PM, Yann Ylavic wrote: Hi Evgeny, On Tue, Apr 25, 2017 at 10:34 PM, Evgeny Kotkov wrote:

Re: The drive for 2.4.26

2017-04-20 Thread Gregg Smith
This is ApacheBench, Version 2.3 <$Revision: 1750960 $> Same result with trunk, it just hangs. Glad it's not just Windows! On 4/20/2017 9:48 AM, Rainer Jung wrote: Am 20.04.2017 um 16:31 schrieb Gregg Smith: ABS doesn't work with openssl 1.1.0, on windows anyway. It builds without warni

Re: The drive for 2.4.26

2017-04-20 Thread Gregg Smith
ABS doesn't work with openssl 1.1.0, on windows anyway. It builds without warning yet doesn't work. abs https://www.domain.com just sits there forever and never completes or shows anything. I cannot imagine this being a windows only problem. On 4/20/2017 3:24 AM, Jim Jagielski wrote: We are

Re: svn commit: r1791192 - /httpd/httpd/branches/2.4.x/support/abs.mak

2017-04-13 Thread Gregg Smith
On 4/12/2017 9:12 PM, William A Rowe Jr wrote: On Wed, Apr 12, 2017 at 5:31 PM, wrote: Author: gsmith Date: Wed Apr 12 22:31:15 2017 New Revision: 1791192 URL: http://svn.apache.org/viewvc?rev=1791192=rev Log: Add another include since applink.c has been moved in the

Re: svn commit: r1790999 - in /httpd/httpd/branches/2.4.x: Makefile.win docs/manual/platform/win_compiling.xml modules/ssl/mod_ssl.mak support/ab.c support/abs.mak

2017-04-11 Thread Gregg Smith
On 4/11/2017 5:19 PM, William A Rowe Jr wrote: On Tue, Apr 11, 2017 at 5:49 PM, Gregg Smith <g...@gknw.net> wrote: They will say fix ours. Bottom line, it's been moved from include/openssl/applink.c to ms/applink.c So, ok, will have to add /ms to the includes or do you have a

Re: svn commit: r1790999 - in /httpd/httpd/branches/2.4.x: Makefile.win docs/manual/platform/win_compiling.xml modules/ssl/mod_ssl.mak support/ab.c support/abs.mak

2017-04-11 Thread Gregg Smith
On 4/11/2017 3:16 PM, William A Rowe Jr wrote: On Tue, Apr 11, 2017 at 11:36 AM, wrote: Author: gsmith Date: Tue Apr 11 16:36:25 2017 New Revision: 1790999 URL: http://svn.apache.org/viewvc?rev=1790999=rev Log: Retro win32 command-line build allow building with OpenSSL

Re: [VOTE] Release httpd-2.2.32

2017-01-11 Thread Gregg Smith
On 1/9/2017 10:21 AM, William A Rowe Jr wrote: The pre-release candidate tarballs of Apache legacy httpd 2.2.32 can be found in; http://httpd.apache.org/dev/dist/ Thanks to all for patches and reviews to get us to this point. STATUS file is updated to reflect end of maintenance Jul 1 '17.

Re: Mod_brotli, C89 & NetWare - finale

2016-11-28 Thread Gregg Smith
Hi Norm, Actually, log2 is not needed. It's cmake that forces it on us. Look at fast_log.h line 131 #if (defined(_MSC_VER) && _MSC_VER <= 1700) || \ (defined(__ANDROID_API__) && __ANDROID_API__ < 18) /* Visual Studio 2012 and Android API levels < 18 do not have the log2() * function

Re: Fwd: svn commit: r1748461 - in /httpd/httpd/branches/2.2.x: ./ CHANGES support/ab.c

2016-06-15 Thread Gregg Smith
On 6/15/2016 9:20 AM, William A Rowe Jr wrote: In building httpd.exe, some users don't build and install openssl. It isn't going to be possible to simply #include without some conditional test. OpenSSL itself is partly the culprit, for not having an APPLINK_REQUIRED style macro conditional. But

Re: svn commit: r1748461 - in /httpd/httpd/branches/2.2.x: ./ CHANGES support/ab.c

2016-06-15 Thread Gregg Smith
On 6/14/2016 6:33 PM, William A Rowe Jr wrote: Gregg, if you would vet the patch as applied to trunk/2.4/2.2, I'd appreciate it. On Jun 14, 2016 3:37 PM, wrote: I built 2.4 and 2.2 in VC14 and tested with VC11 Openssl dlls. Being down a machine (with all VC runtimes from 9-14

Re: h2_proxy_util.c, is this going make 2.4.21?

2016-06-14 Thread Gregg Smith
sorry, that was not supposed to go to list. On 6/14/2016 4:01 PM, Gregg Smith wrote: Hi Steffen, Attached is a svn pull from about 1 hour after I committed my changes. No need to wait for tag if you would rather get a jump on testing. To maybe hit the 3 or 4 days after when you find bugs

Re: h2_proxy_util.c, is this going make 2.4.21?

2016-06-14 Thread Gregg Smith
6 um 22:40 schrieb William A Rowe Jr<wr...@rowe-clan.net>: On Mon, Jun 13, 2016 at 1:59 PM, Gregg Smith<g...@gknw.net> wrote: I have the to connect this module in the traditional windows build but as of right now it's using h2_util.c which Bill had an objection to. See his comments ht

Re: h2_proxy_util.c, is this going make 2.4.21?

2016-06-13 Thread Gregg Smith
in 2.4.21 on Windows. If this gets in overnight and you tag in the morning, I may not be out of bed yet due to the time difference. That's where my concern is. Make sense? On 6/13/2016 11:43 AM, Jim Jagielski wrote: What needs to be done? On Jun 13, 2016, at 2:20 PM, Gregg Smith<g...@gknw.

h2_proxy_util.c, is this going make 2.4.21?

2016-06-13 Thread Gregg Smith
Hi Stefan, Any plans to backport this before Jim tags 2.4.21 tomorrow? Thanks, Gregg

Re: [POLL] Commitment to 2.2.x lifecycle? (Was: End of the road of 2.2.x maintenance?)

2016-05-26 Thread Gregg Smith
On 5/25/2016 8:11 AM, William A Rowe Jr wrote: *) I intend to help maintain/test 2.2.x releases over the next [_6__] mos *) I intend to backport/review 2.2.x security patches over the next [_0__] mos

Re: svn commit: r1745517 - /httpd/httpd/branches/2.4.x/support/win32/ApacheMonitor.c

2016-05-25 Thread Gregg Smith
On 5/25/2016 11:14 AM, William A Rowe Jr wrote: Your comment doesn't match the code, and I think you have the condition inverted, _setargv() worked for decades, and only was broken in the more recent MSVC's. Typo, should be 1800 in log, I'll change it. I may revert it now that I dug & found

mod_proxy_hcheck and Windows

2016-05-23 Thread Gregg Smith
I got to playing around with trunk over the weekend and ran into this; .\mod_proxy_hcheck.c(925) : error C2440: 'function' : cannot convert from 'void *(__cdecl *)(apr_thread_t *,void *)' to 'apr_thread_start_t' .\mod_proxy_hcheck.c(925) : warning C4022: 'apr_thread_pool_push' : pointer

Re: End of the road of 2.2.x maintenance?

2016-05-16 Thread Gregg Smith
On 5/16/2016 11:03 AM, Eric Covener wrote: On Tue, May 10, 2016 at 1:38 PM, William A Rowe Jr wrote: Are we ready to start the 12 month countdown as of the next/final bug fix release of 2.2, and highlight this in both the 2.2 and 2.4 announce broadcasts? One shortcoming

mod_proxy_hcheck ouch in Windows

2016-04-28 Thread Gregg Smith
This one I cannot figure out .\mod_proxy_hcheck.c(925) : error C2440: 'function' : cannot convert from 'void *(__cdecl *)(apr_thread_t *,void *)' to 'apr_thread_start_t' - Gregg -

Re: svn commit: r1741419 [1/4] - in /httpd/httpd/branches/2.4.x: ./ modules/http2/

2016-04-28 Thread Gregg Smith
Oops, one more. h2_request.c(452) : warning C4003: not enough actual parameters for macro 'APLOGNO' On 4/28/2016 10:17 AM, Stefan Eissing wrote: Ah, will alloc a new one tomorrow. Should be one left. Thanks. Am 28.04.2016 um 18:57 schrieb Gregg Smith<g...@gknw.net>: On 4/28/2016 5

Re: svn commit: r1741419 [1/4] - in /httpd/httpd/branches/2.4.x: ./ modules/http2/

2016-04-28 Thread Gregg Smith
On 4/28/2016 5:43 AM, ic...@apache.org wrote: Author: icing Date: Thu Apr 28 12:43:02 2016 New Revision: 1741419 URL: http://svn.apache.org/viewvc?rev=1741419=rev Log: mod_http2: backport of 1.5.2 to 2.4.x Added: httpd/httpd/branches/2.4.x/modules/http2/h2_bucket_beam.c - copied,

Re: [VOTE] Release Apache httpd 2.4.20 as GA

2016-04-05 Thread Gregg Smith
On 4/4/2016 9:20 AM, Jim Jagielski wrote: The pre-release test tarballs for Apache httpd 2.4.20 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.20 GA. [ ] +1: Good to go [ ] +0: meh [ ] -1: Danger Will

Re: state of h2 (long)

2016-02-28 Thread Gregg Smith
Hi Stefan, I've had a real lack of time lately to do much on trunk's mod_http2 on the windows side. The new mod_proxy_http2 requires a few functions from mod_http2 and with what time I have had I have been unsuccessful figuring out how to get these functions exported. So if you (or anyone

Re: h2_conn.c r1727604 crashing on windows

2016-02-17 Thread Gregg Smith
Hi Stefan, It works! Thanks! On 2/17/2016 1:04 AM, Stefan Eissing wrote: Hi Gregg, could you check if r1730798 works for you? Thanks! //Stefan Am 17.02.2016 um 06:08 schrieb Gregg Smith<g...@gknw.net>: Hi Stefan, Windows doesn't seems to like this. Short call stack and

h2_conn.c r1727604 crashing on windows

2016-02-16 Thread Gregg Smith
Hi Stefan, Windows doesn't seems to like this. Short call stack and locals in attached. Regards, Gregg httpd-trunk at r1727604 APR 1.5.2 APR-UTIL 1.5.4 PCRE 8.38 SSL 1.0.2f NGHTTP2 1.7.0 Call Stack -- > mod_http2.so!h2_slave_create(conn_rec *

Re: mod_proxy_http2

2016-02-08 Thread Gregg Smith
On 2/8/2016 9:07 AM, Stefan Eissing wrote: PS. I did not update Windows Makefiles. I feel bad. Don't, I need to play catch-up anyway :) Should this be in modules/proxy like all the rest of the mod_proxy_* modules? I personally do not care, I was just thinking (which in itself can be

Re: [VOTE] Release Apache httpd 2.4.18 as GA

2015-12-11 Thread Gregg Smith
+1 Various flavors of VC/Windows On 12/8/2015 12:38 PM, Jim Jagielski wrote: The pre-release test tarballs for Apache httpd 2.4.18 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.18 GA. [ ] +1: Good to go [

Re: svn commit: r1712300 [1/2] - /httpd/httpd/trunk/modules/http2/

2015-11-03 Thread Gregg Smith
On 11/3/2015 6:33 AM, ic...@apache.org wrote: Author: icing Date: Tue Nov 3 14:33:11 2015 New Revision: 1712300 URL: http://svn.apache.org/viewvc?rev=1712300=rev Log: rework of output handling on stream/session close, rework of cleartext (http:) output to pass buckets to core filters,

Re: No luck with `Protocols h2`

2015-10-09 Thread Gregg Smith
Hi Jacob, On 10/9/2015 4:47 PM, Jacob Champion wrote: Stefan, I'm trying to test mod_http2 for the 2.4.17 release, but I cannot for the life of me get ALPN and the h2 protocol working together. h2c seems to work, as does http/1.1 over TLS. My hope is that I'm just missing a config directive

Re: [VOTE] Release Apache httpd 2.4.17 as GA

2015-10-09 Thread Gregg Smith
On 10/9/2015 10:40 AM, Jim Jagielski wrote: The pre-release test tarballs for Apache httpd 2.4.17 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.17 GA. Not a vote, I haven't gotten that far yet. It's been

Re: T of 2.4.17 this week

2015-10-08 Thread Gregg Smith
On 10/8/2015 3:57 AM, Steffen wrote: Jus curious, why is e.g. LUA there ? Probably because when mod_lua was added it got added and not the case when mod_proxy_html and mod_xml2enc got added nor did I think about it when adding mod_h2. My fault. This is beyond the scope of httpd's source

Re: AW: mod_h2 CTR (Was: Re: svn commit: r1705257 - /httpd/httpd/trunk/modules/http2/config.m4)

2015-09-25 Thread Gregg Smith
On 9/25/2015 8:56 AM, Plüm, Rüdiger, Vodafone Group wrote: -Ursprüngliche Nachricht- Von: Plüm, Rüdiger, Vodafone Group Gesendet: Freitag, 25. September 2015 17:51 An: dev@httpd.apache.org Betreff: AW: mod_h2 CTR (Was: Re: svn commit: r1705257 -

Re: svn move modules/http2 modules/h2 ?

2015-09-22 Thread Gregg Smith
http2 is more descriptive for the module's purpose, even if the name is mod_h2. I like it where it is. - 0 On 9/22/2015 5:08 AM, Stefan Eissing wrote: +0.5 h2 ftw! (but there is also a mod_mime in the http dir, so I do not really feel strongly about this) Am 22.09.2015 um 14:05 schrieb

Re: proposed backport of mod_h2 - v4

2015-09-05 Thread Gregg Smith
05.09.2015 um 06:12 schrieb Gregg Smith<g...@gknw.net>: Shouldn't this be ap_array_str_contains now in h2_switch.c? +while (*protos) { +/* Add all protocols we know (tls or clear) and that + * are part of the offerings (if there have been any). + */ -->+if

Re: proposed backport of mod_h2 - v4

2015-09-04 Thread Gregg Smith
Shouldn't this be ap_array_str_contains now in h2_switch.c? +while (*protos) { +/* Add all protocols we know (tls or clear) and that + * are part of the offerings (if there have been any). + */ -->+if (!offers || ap_array_contains(offers, *protos)) { +

Re: r1701005 httpd-trunk\server\protocols.c

2015-09-04 Thread Gregg Smith
On 9/3/2015 9:23 PM, NormW wrote: On 4/09/2015 9:05 AM, Yann Ylavic wrote: On Fri, Sep 4, 2015 at 12:52 AM, NormW wrote: Hi again, Pushing passed previous problem, now arrive at: D:\Projects\svn\httpd-trunk\server>svn diff Index: protocol.c

Re: r1700777 - h2_stream.c

2015-09-02 Thread Gregg Smith
Hi Norm, I need it too. done in r1700917 Gregg On 9/2/2015 5:07 PM, NormW wrote: hi, If not mistaken, on the latest httpd-trunk\modules\http2 update: D:\Projects\svn\httpd-trunk\modules\http2>svn diff Index: h2_session.c ===

Re: proposed backport of mod_h2

2015-09-02 Thread Gregg Smith
Hi Stefan, core patch: needs r1694950 and may require a minor mmn bump, at least that is what I took away from the discussion about it over this commit. h2 patch: needs r1700917 Thanks, Gregg On 9/2/2015 7:10 AM, Stefan Eissing wrote: As in r1700829. Regression tests run (after small

Re: proposed backport, mod_h2 github release

2015-08-26 Thread Gregg Smith
On 8/26/2015 6:44 AM, Stefan Eissing wrote: I just submitted my first backport STATUS update. Hope I did everything ok, otherwise please let me know. For backporting mod_h2 to 2.4.x, I decided to make it in two parts: one is the patch to core/mod_ssl that introduces Protocols. That is now in

Re: protocols and mod_h2 consolidation

2015-08-25 Thread Gregg Smith
Stefan, Changes worked great. Thanks. Gregg On 8/25/2015 3:43 AM, Stefan Eissing wrote: Gregg, I just checked in changes that should fix the warnings you mentioned. Thanks for reviewing this. As to the SERVER_PROTOCOL, I have no idea yet what may cause this. //Stefan Am 25.08.2015 um

Re: protocols and mod_h2 consolidation

2015-08-25 Thread Gregg Smith
On 8/25/2015 5:57 PM, William A Rowe Jr wrote: On Aug 24, 2015 11:43 PM, Gregg Smithg...@gknw.net wrote: On 8/24/2015 9:29 AM, Stefan Eissing wrote: I hope this works for everyone. The next weeks might be a good time to think about it and propose any changes and correct my mistakes. There

Re: protocols and mod_h2 consolidation

2015-08-24 Thread Gregg Smith
Hi, On 8/24/2015 9:29 AM, Stefan Eissing wrote: I hope this works for everyone. The next weeks might be a good time to think about it and propose any changes and correct my mistakes. There are two things that go bump on my lowest non-eol version of MSVC. h2_worker.c .\h2_worker.c(113) :

Re: svn commit: r1694950 - in /httpd/httpd/trunk: include/http_request.h modules/http/http_request.c

2015-08-10 Thread Gregg Smith
On 8/10/2015 11:44 AM, William A Rowe Jr wrote: On Mon, Aug 10, 2015 at 12:31 PM, Gregg Smithg...@gknw.net wrote: Hi, I guess a minor at least. I did not add, remove or change the structure of the function, I simply made it available to modules. Does that warrant a major bump? Never a

Re: svn commit: r1694950 - in /httpd/httpd/trunk: include/http_request.h modules/http/http_request.c

2015-08-10 Thread Gregg Smith
Hi, I guess a minor at least. I did not add, remove or change the structure of the function, I simply made it available to modules. Does that warrant a major bump? On 8/9/2015 10:40 PM, Marion Christophe JAILLET wrote: Hi, doesn't it require a minor ap_mmn.h bump ? cj Le 10/08/2015

Re: Building for NetWare /1 - For Your Consideration

2015-08-07 Thread Gregg Smith
Argh! Hi Norm, Can you attach this patch to the emain, not just paste it into the body of the message? I'll assume this is for trunk and 2.4. Cheers, Gregg On 7/24/2015 5:22 PM, NormW wrote: Hi, The NetWare Gurus seem to be on holidays. For your consideration: Index:

Re: Building for NetWare /1 - For Your Consideration

2015-08-07 Thread Gregg Smith
On 7/24/2015 5:22 PM, NormW wrote: Hi, The NetWare Gurus seem to be on holidays. For your consideration: Index: modules/cache/NWGNUsocachshmcb === --- modules/cache/NWGNUsocachshmcb(revision 1692595) +++

Re: [VOTE] [24 hr] Release 2.2.31 as GA?

2015-07-15 Thread Gregg Smith
On 7/15/2015 9:44 AM, William A Rowe Jr wrote: The pre-release candidate tarballs of Apache httpd 2.2.31, can be found in; [+1] Release 2.2.31 GA (apr 1.5.2, apr-util 1.5.4) Thanks for the quick turnaround RM!

Re: building httpd 2.2 on windows automation question.

2015-07-14 Thread Gregg Smith
On 7/14/2015 12:09 PM, Andy Wang wrote: link.exe -lib @C:\Users\runtime\AppData\Local\Temp\nm9E02.tmp c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\BIN\nmake.exe - nologo -f libaprutil.mak CFG=libaprutil - Win32 Release RECURSE=0 if not exist .\Release/

Re: building httpd 2.2 on windows automation question.

2015-07-14 Thread Gregg Smith
You know 2.2 has .mak files in the source. They've been given no love in a long time but nothing major has changed for them to need it AFAIK. Those should make your automating life simple. nmake /f makefile.win [options] installr On 7/14/2015 9:03 AM, Andy Wang wrote: On 07/14/2015 10:53

Re: [VOTE] Release Apache httpd 2.4.16 as GA

2015-07-13 Thread Gregg Smith
On 7/10/2015 1:33 PM, Jim Jagielski wrote: The pre-release test tarballs for Apache httpd 2.4.16 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.16 GA. [X] +1: Good to go PS: Hopefully, 4th time's the

Re: minor APR 1.5.2 build error on Windows

2015-06-27 Thread Gregg Smith
On 6/26/2015 1:54 AM, Stefan Hett wrote: On 6/26/2015 4:55 AM, Gregg Smith wrote: On 6/25/2015 10:51 AM, Stefan Hett wrote: Hi Gregg, On 6/22/2015 3:58 AM, Stefan Hett wrote: Hi Gregg, On 6/22/2015 2:49 AM, Stefan Hett wrote: Hi, I just tested building APR 1.5.2 from source on windows

Re: [VOTE] Release Apache httpd 2.4.15 as GA

2015-06-21 Thread Gregg Smith
On 6/19/2015 9:50 AM, Jim Jagielski wrote: The pre-release test tarballs for Apache httpd 2.4.15 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.15 GA. [X] +1: Good to go VC9/12 and various Windows flavors.

Re: SSLCertificateChainFile deprecation, still (was: svn commit: r1685371 - /httpd/httpd/branches/2.4.x/STATUS)

2015-06-14 Thread Gregg Smith
On 6/14/2015 2:54 AM, Yann Ylavic wrote: On Sun, Jun 14, 2015 at 11:29 AM,gsm...@apache.org wrote: Author: gsmith Date: Sun Jun 14 09:29:50 2015 New Revision: 1685371 URL: http://svn.apache.org/r1685371 Log: -1 vote w/ comment Modified: httpd/httpd/branches/2.4.x/STATUS Modified:

Re: SSLCertificateChainFile deprecation, still (was: svn commit: r1685371 - /httpd/httpd/branches/2.4.x/STATUS)

2015-06-14 Thread Gregg Smith
On 6/14/2015 6:14 PM, Gregg Smith wrote: On 6/14/2015 2:56 PM, Yann Ylavic wrote: On Sun, Jun 14, 2015 at 1:31 PM, Gregg Smithg...@gknw.net wrote: http://people.apache.org/~gsmith/proposal/sslcertificatechainfile_compromise.diff I'm fine with this approach too. We have to decide whether

Re: SSLCertificateChainFile deprecation, still (was: svn commit: r1685371 - /httpd/httpd/branches/2.4.x/STATUS)

2015-06-14 Thread Gregg Smith
On 6/14/2015 2:56 PM, Yann Ylavic wrote: On Sun, Jun 14, 2015 at 1:31 PM, Gregg Smithg...@gknw.net wrote: http://people.apache.org/~gsmith/proposal/sslcertificatechainfile_compromise.diff I'm fine with this approach too. We have to decide whether a single [warn] is acceptable or not since it

Re: mod_deflate was Re: [VOTE] Release Apache httpd 2.4.13 as GA

2015-06-04 Thread Gregg Smith
On 6/4/2015 10:01 PM, William A Rowe Jr wrote: On Thu, Jun 4, 2015 at 10:47 PM, Gregg Smithg...@gknw.net wrote: This is new, not quite sure how I didn't see it a few weeks ago as it's 9 weeks old. Who forgot to fill in the number? mod_deflate.c(1283) : warning C4003: not enough actual

  1   2   3   >