Re: Configuration error handling after httpd restart

2014-04-14 Thread Mike Rumph
Hello Jim, Thanks for taking a look at this and providing a patch for case 2 (duplicate Listen directives). I will need to evaluate this patch in more detail. Your approach of simply ignoring duplicate Listen directives with a warning seems reasonable. At least in the simple case that I

Re: Configuration error handling after httpd restart

2014-04-14 Thread Eric Covener
On Thu, Mar 27, 2014 at 4:16 PM, Mike Rumph mike.ru...@oracle.com wrote: - And the logs/httpd.pid file remains intact. I noticed this once, IIRC if the 2nd pass of post-config returns an error, the pidfile is not cleaned up. Modules like to cheat and only do their work in the 2nd pass. --

Re: Configuration error handling after httpd restart

2014-04-14 Thread Eric Covener
On Mon, Apr 14, 2014 at 11:15 AM, Mike Rumph mike.ru...@oracle.com wrote: If there is an unknown directive in the config file, simply ignore it with a warning. You can't do that. What if it was Reqiure?

Re: Configuration error handling after httpd restart

2014-04-14 Thread Jim Riggs
On 14 Apr 2014, at 10:38, Eric Covener cove...@gmail.com wrote: On Mon, Apr 14, 2014 at 11:15 AM, Mike Rumph mike.ru...@oracle.com wrote: If there is an unknown directive in the config file, simply ignore it with a warning. You can't do that. What if it was Reqiure? I agree with Eric. I

Re: Configuration error handling after httpd restart

2014-04-14 Thread Yehuda Katz
Since this is up for discussion anyway, what if there was an option to set a directive as ignore-able. For example, PHP allows you to preface a function with `@` to ignore errors (http://www.php.net/manual/en/language.operators.errorcontrol.php). That way, if you restart and the error is Invalid

Re: Configuration error handling after httpd restart

2014-04-11 Thread Jim Riggs
On 27 Mar 2014, at 14:16, Mike Rumph mike.ru...@oracle.com wrote: Hello all, I have been doing some testing on the results of httpd restart with configuration errors. This gave me some interesting results. For these tests I build httpd trunk with APR trunk on Linux using the following

Configuration error handling after httpd restart

2014-03-27 Thread Mike Rumph
Hello all, I have been doing some testing on the results of httpd restart with configuration errors. This gave me some interesting results. For these tests I build httpd trunk with APR trunk on Linux using the following configure: $ ./configure --prefix=/home/mrumph/apache25