Fwd: svn commit: r1377475 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_lua.xml docs/manual/style/scripts/prettify.js modules/lua/lua_vmprep.h modules/lua/mod_lua.c modules/lua/mod_lua.h

2012-08-27 Thread Rüdiger Plüm
Original Message Subject:svn commit: r1377475 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_lua.xml docs/manual/style/scripts/prettify.js modules/lua/lua_vmprep.h modules/lua/mod_lua.c modules/lua/mod_lua.h Date: Sun, 26 Aug 2012 18:39:59 GMT From:

Re: Fwd: svn commit: r1377475 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_lua.xml docs/manual/style/scripts/prettify.js modules/lua/lua_vmprep.h modules/lua/mod_lua.c modules/lua/mod_lua.h

2012-08-27 Thread Daniel Gruno
On 08/27/2012 09:41 AM, Rüdiger Plüm wrote: +/* Clean up and pass on the brigade to the next filter in the chain */ Where do we do a cleanup here? +return APR_SUCCESS; +} + snip Regards Rüdiger Heh, I believe that's what is called a copypasto. Both cleanups and passing

RE: Fwd: svn commit: r1377475 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_lua.xml docs/manual/style/scripts/prettify.js modules/lua/lua_vmprep.h modules/lua/mod_lua.c modules/lua/mod_lua.h

2012-08-27 Thread Plüm , Rüdiger , Vodafone Group
-Original Message- From: Daniel Gruno [mailto:rum...@cord.dk] Sent: Montag, 27. August 2012 10:45 To: dev@httpd.apache.org Subject: Re: Fwd: svn commit: r1377475 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_lua.xml docs/manual/style/scripts/prettify.js modules/lua

Re: Fwd: svn commit: r1377475 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_lua.xml docs/manual/style/scripts/prettify.js modules/lua/lua_vmprep.h modules/lua/mod_lua.c modules/lua/mod_lua.h

2012-08-27 Thread Daniel Gruno
On 08/27/2012 11:59 AM, Plüm, Rüdiger, Vodafone Group wrote: Thanks. I guess you noticed that I found more important issues with the code than this comment :-) Regards Rüdiger Haha, yeah, but that's a big mess to clean up (I'm not a programmer by trade, so I'm a bit slow in that

Re: Fwd: svn commit: r1377475 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_lua.xml docs/manual/style/scripts/prettify.js modules/lua/lua_vmprep.h modules/lua/mod_lua.c modules/lua/mod_lua.h

2012-08-27 Thread Daniel Gruno
On 08/27/2012 11:59 AM, Plüm, Rüdiger, Vodafone Group wrote: Thanks. I guess you noticed that I found more important issues with the code than this comment :-) Regards Rüdiger I've tried my best to correct the errors you mentioned, but I'm having some trouble figuring out how the

RE: Fwd: svn commit: r1377475 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_lua.xml docs/manual/style/scripts/prettify.js modules/lua/lua_vmprep.h modules/lua/mod_lua.c modules/lua/mod_lua.h

2012-08-27 Thread Plüm , Rüdiger , Vodafone Group
-Original Message- From: Daniel Gruno [mailto:rum...@cord.dk] Sent: Montag, 27. August 2012 14:06 To: dev@httpd.apache.org Subject: Re: Fwd: svn commit: r1377475 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_lua.xml docs/manual/style/scripts/prettify.js modules/lua