Re: New mod_smtpd release

2005-08-16 Thread Nick Kew
Rian Hunter wrote: Well not exactly. A module that parses headers can register itself as an input_filter for mod_smtpd. It can parse the headers and the headers can be accessed by a get_smtpd_headers(request_rec*) function or similar exported by the parsing module, and modules that rely on

Re: New mod_smtpd release

2005-08-16 Thread Nick Kew
Rian Hunter wrote: [chop] I think I should have looked harder before replying ... looks like you've done more than I realised. I guess what I was asking about slots easily in to data_post ? -- Nick Kew

Re: New mod_smtpd release

2005-08-16 Thread Rian Hunter
On Aug 16, 2005, at 6:37 AM, Nick Kew wrote: Spooling and dealing with multiple recipients are things I'd like to think about now. ISTR posting about this before: I think each recipient needs a separate request processing cycle, because each recipient may have completely different processing

Re: New mod_smtpd release

2005-08-16 Thread Rian Hunter
On Aug 16, 2005, at 6:47 AM, Nick Kew wrote: Rian Hunter wrote: [chop] I think I should have looked harder before replying ... looks like you've done more than I realised. I guess what I was asking about slots easily in to data_post ? Which question exactly? -rian

Re: New mod_smtpd release

2005-08-15 Thread Jem Berkes
Well there's also another problem. RFC 2821 (SMTP) doesn't define a particular message format for SMTP (in wide use there the RFC 822 and MIME message formats). I don't think that mod_smtpd should assume a RFC 822 or MIME message format since its strictly a SMTP module, that's why I agree

Re: New mod_smtpd release

2005-08-15 Thread Joe Schaefer
Jem Berkes [EMAIL PROTECTED] writes: Well there's also another problem. RFC 2821 (SMTP) doesn't define a particular message format for SMTP (in wide use there the RFC 822 and MIME message formats). I don't think that mod_smtpd should assume a RFC 822 or MIME message format since its strictly

Re: New mod_smtpd release

2005-08-15 Thread Rian Hunter
On Aug 15, 2005, at 10:22 AM, Joe Schaefer wrote: Jem Berkes [EMAIL PROTECTED] writes: Well there's also another problem. RFC 2821 (SMTP) doesn't define a particular message format for SMTP (in wide use there the RFC 822 and MIME message formats). I don't think that mod_smtpd should

Re: New mod_smtpd release

2005-08-15 Thread Joe Schaefer
Rian Hunter [EMAIL PROTECTED] writes: Either way, lacking header parsing in mod_smtpd is being impractically pedant since probably 99% of SMTP transfers involve messages in the RFC 2822/MIME formats. Although I think that maybe there will be a plugin that wants data from the DATA

Re: New mod_smtpd release

2005-08-15 Thread Garrett Rooney
Joe Schaefer wrote: Rian Hunter [EMAIL PROTECTED] writes: Either way, lacking header parsing in mod_smtpd is being impractically pedant since probably 99% of SMTP transfers involve messages in the RFC 2822/MIME formats. Although I think that maybe there will be a plugin that wants data

Re: New mod_smtpd release

2005-08-15 Thread Joe Schaefer
Branko Čibej [EMAIL PROTECTED] writes: May I suggest you resend this patch, using svn diff instead of diff -pur to create it? You're diffing the SVN administrative directory... OK, here's a patch against mod_smtpd trunk that replaces the // comments with /**/: Property changes on:

Re: New mod_smtpd release

2005-08-14 Thread Branko Čibej
Joe Schaefer wrote: Rian Hunter [EMAIL PROTECTED] writes: You can checkout this code out from: http://svn.apache.org/repos/asf/httpd/mod_smtpd/trunk/ Very cool, thanks! I had some trouble compiling it, and I noticed you're using // comments alot. Here are two patches for that.

Re: New mod_smtpd release

2005-08-14 Thread Joe Schaefer
Branko Čibej [EMAIL PROTECTED] writes: May I suggest you resend this patch, using svn diff instead of diff -pur to create it? You're diffing the SVN administrative directory... Thanks. Here's another patch to add a skeleton STATUS file, using svn diff this time. Index: STATUS

Re: New mod_smtpd release

2005-08-14 Thread Rian Hunter
On Aug 14, 2005, at 1:22 PM, Joe Schaefer wrote: snip... +CURRENT RELEASE NOTES: + + Virtual hosts a'la mod_ftpd don't work. It does work like this: Listen 80 Listen 25 NameVirtualHost *:80 NameVirtualHost *:25 VirtualHost *:80 ServerName localhost DocumentRoot htdocs

Re: New mod_smtpd release

2005-08-14 Thread Joe Schaefer
Rian Hunter [EMAIL PROTECTED] writes: On Aug 14, 2005, at 1:22 PM, Joe Schaefer wrote: +RELEASE SHOWSTOPPERS: + + + smtp_process_connection_internal should take a smtp_proto_rec + argument (which is what the current smtp_request_rec struct + should be renamed to). I can easily rename

Re: New mod_smtpd release

2005-08-14 Thread Rian Hunter
On Aug 14, 2005, at 8:12 PM, Joe Schaefer wrote: Rian Hunter [EMAIL PROTECTED] writes: On Aug 14, 2005, at 1:22 PM, Joe Schaefer wrote: +RELEASE SHOWSTOPPERS: + + + smtp_process_connection_internal should take a smtp_proto_rec + argument (which is what the current smtp_request_rec

Re: New mod_smtpd release

2005-08-14 Thread Joe Schaefer
Rian Hunter [EMAIL PROTECTED] writes: The request_rec slot can be NULL for connection-level filters. But I'd create a request_rec sometime before I added an smtp protocol filter, which would just do the .-decoding, similar to how http_in deals with TE. Yeah I agree. I'd be more than happy

Re: New mod_smtpd release

2005-08-14 Thread Ask Bjørn Hansen
On Aug 12, 2005, at 5:57 PM, Rian Hunter wrote: This version of mod_smtpd is callback based, very similar to Qpsmtpd. Here is a list of all the hooks you can register: That's a beautiful cycle. When I added the plugin/extension/hook system to qpsmtpd way back when I borrowed many

New mod_smtpd release

2005-08-12 Thread Rian Hunter
Hi, I've checked in mod_smtpd 0.9 and its API should be completely frozen by now. This version of mod_smtpd is heavily based on Qpsmtpd, so the same extensibility you expect from Qpsmtpd can be achieved with this version of mod_smtpd. I haven't written any documentation yet but here is a