Joscorbe commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1511417455
##
oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java:
##
@@ -23,6 +23,11 @@
import java.io.IOException;
import java.util.List;
Joscorbe commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1511389602
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleaner.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to the
rishabhdaim commented on PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#issuecomment-1976901217
Could you please revert `VersionGarbageCollectorIT` from your PR, it looks
like you haven't made any changes in this file.
--
This is an automated message from the Apache
Joscorbe commented on PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#issuecomment-1976895834
I have squashed the WIP commits, sorry for the forced-PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
rishabhdaim commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1511357714
##
oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java:
##
@@ -32,6 +37,7 @@
import java.util.concurrent.TimeUnit;
import
Joscorbe commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1511344989
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleaner.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to the
Joscorbe commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1511343772
##
oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java:
##
@@ -460,6 +494,97 @@ private void sweep(RevisionsOptions options, Closer
Joscorbe commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1511343112
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleaner.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to the
Joscorbe commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1511333001
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollectorIT.java:
##
Review Comment:
I haven't done any
+1 with
[INFO]
[INFO] Apache Maven 3.9.5 (57804ffe001d7215b5e7bcb531cf83df38f93546)
[INFO] OS name: "mac os x", version: "14.3.1", arch: "aarch64", family:
"mac"
[INFO] Java version: 17.0.3, vendor: Eclipse Adoptium,
Joscorbe commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1511258728
##
oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java:
##
@@ -82,6 +97,7 @@ public class RevisionsCommand implements Command {
fabriziofortino commented on code in PR #1340:
URL: https://github.com/apache/jackrabbit-oak/pull/1340#discussion_r1511168284
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/PipelinedMongoDownloadTask.java:
##
@@ -126,6
Joscorbe closed pull request #1191: OAK-10535: Clean up old revisions in a
document
URL: https://github.com/apache/jackrabbit-oak/pull/1191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
reschke merged PR #1339:
URL: https://github.com/apache/jackrabbit-oak/pull/1339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke commented on PR #1213:
URL: https://github.com/apache/jackrabbit-oak/pull/1213#issuecomment-1976495050
I agree these are wrong, but they *are* used as names in the generated OSGi
metadata. We need to fix them, butI'm not sure we can simply remove (thus
rename) them.
--
This is
mbaedke commented on PR #1213:
URL: https://github.com/apache/jackrabbit-oak/pull/1213#issuecomment-1976441288
@reschke that is very likely
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
reschke commented on PR #1318:
URL: https://github.com/apache/jackrabbit-oak/pull/1318#issuecomment-1976399507
I *believe* these are created by the ancient Felix SCR plugin (see
[OAK-6741](https://issues.apache.org/jira/browse/OAK-6741))
--
This is an automated message from the Apache
nfsantos opened a new pull request, #1340:
URL: https://github.com/apache/jackrabbit-oak/pull/1340
Add property to specify list of paths to be excluded from Mongo download:
`oak.indexer.pipelined.mongoCustomExcludedPaths`.
Custom path filtering will only be applied if the index
smiroslav merged PR #1329:
URL: https://github.com/apache/jackrabbit-oak/pull/1329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Hi,
The draft for the January 2024 board report is available here:
https://jackrabbit.apache.org/jcr/status/board-report-2024-03.html
Please review and let me know if something is missing or incorrect.
I will submit the report tomorrow Tuesday EOD.
Regards
Marcel
reschke opened a new pull request, #1339:
URL: https://github.com/apache/jackrabbit-oak/pull/1339
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
[X] +1 Release this package as Apache Jackrabbit 2.20.15
with
[INFO] Apache Maven 3.6.3
[INFO] OS name: "linux", version: "6.1.0-1035-oem", arch: "amd64", family:
"unix"
[INFO] Java version: 11.0.22, vendor: Ubuntu, runtime:
/usr/lib/jvm/java-11-openjdk-amd64
[INFO] MAVEN_OPTS:
[INFO]
reschke merged PR #1338:
URL: https://github.com/apache/jackrabbit-oak/pull/1338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/JCR-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823099#comment-17823099
]
Julian Reschke commented on JCR-5011:
-
trunk: (2.21.23)
[X] +1 Release this package as Apache Jackrabbit 2.20.15
...where...
> [INFO] Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> [INFO] OS name: "windows 10", version: "10.0", arch: "amd64", family:
"windows"
> [INFO] Java version: 11.0.20, vendor: Oracle Corporation, runtime:
mbaedke commented on PR #1336:
URL: https://github.com/apache/jackrabbit-oak/pull/1336#issuecomment-1976026683
@reschke,
> we really do not want to introduce shaded Guava into 1.22
Yes, obviously. That one sneaked in with the cherry-pick. I'll remove it.
--
This is an
26 matches
Mail list logo
