Re: [PR] OAK-10558: ensure index name uniqueness in ElasticReliabilityTest [jackrabbit-oak]

2023-11-23 Thread via GitHub
fabriziofortino merged PR #1228: URL: https://github.com/apache/jackrabbit-oak/pull/1228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10558: ensure index name uniqueness in ElasticReliabilityTest [jackrabbit-oak]

2023-11-23 Thread via GitHub
fabriziofortino commented on code in PR #1228: URL: https://github.com/apache/jackrabbit-oak/pull/1228#discussion_r1403096502 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticReliabilityTest.java: ## @@ -86,9 +74,9 @@ protected

Re: [PR] OAK-10558: ensure index name uniqueness in ElasticReliabilityTest [jackrabbit-oak]

2023-11-23 Thread via GitHub
nfsantos commented on code in PR #1228: URL: https://github.com/apache/jackrabbit-oak/pull/1228#discussion_r1403093446 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticReliabilityTest.java: ## @@ -86,9 +74,9 @@ protected

Re: [PR] OAK-10558: ensure index name uniqueness in ElasticReliabilityTest [jackrabbit-oak]

2023-11-23 Thread via GitHub
steffenvan commented on PR #1228: URL: https://github.com/apache/jackrabbit-oak/pull/1228#issuecomment-1823954547 LGTM. Can't approve yet though -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] OAK-10558: ensure index name uniqueness in ElasticReliabilityTest [jackrabbit-oak]

2023-11-22 Thread via GitHub
fabriziofortino opened a new pull request, #1228: URL: https://github.com/apache/jackrabbit-oak/pull/1228 This test is using a fixed index name also used in other tests (`test1`). While this might not be a problem in most cases, for this test the index name uniqueness is important. The