Re: [PR] OAK-10542 : getLiveRevision must inspect split docs if local deleted … [jackrabbit-oak]

stefan-egli merged PR #1198: URL: https://github.com/apache/jackrabbit-oak/pull/1198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10542 : getLiveRevision must inspect split docs if local deleted … [jackrabbit-oak]

Joscorbe commented on code in PR #1198: URL: https://github.com/apache/jackrabbit-oak/pull/1198#discussion_r1399401213 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocument.java: ## @@ -2181,6 +2171,34 @@ private String

Re: [PR] OAK-10542 : getLiveRevision must inspect split docs if local deleted … [jackrabbit-oak]

sonarcloud[bot] commented on PR #1198: URL: https://github.com/apache/jackrabbit-oak/pull/1198#issuecomment-1819175882 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] OAK-10542 : getLiveRevision must inspect split docs if local deleted … [jackrabbit-oak]

stefan-egli commented on code in PR #1198: URL: https://github.com/apache/jackrabbit-oak/pull/1198#discussion_r1399222471 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocument.java: ## @@ -2181,6 +2171,34 @@ private String

Re: [PR] OAK-10542 : getLiveRevision must inspect split docs if local deleted … [jackrabbit-oak]

Joscorbe commented on code in PR #1198: URL: https://github.com/apache/jackrabbit-oak/pull/1198#discussion_r1399192247 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocument.java: ## @@ -2181,6 +2171,34 @@ private String

Re: [PR] OAK-10542 : getLiveRevision must inspect split docs if local deleted … [jackrabbit-oak]

sonarcloud[bot] commented on PR #1198: URL: https://github.com/apache/jackrabbit-oak/pull/1198#issuecomment-1812448797 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] OAK-10542 : getLiveRevision must inspect split docs if local deleted … [jackrabbit-oak]

sonarcloud[bot] commented on PR #1198: URL: https://github.com/apache/jackrabbit-oak/pull/1198#issuecomment-1812366237 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] OAK-10542 : getLiveRevision must inspect split docs if local deleted … [jackrabbit-oak]

sonarcloud[bot] commented on PR #1198: URL: https://github.com/apache/jackrabbit-oak/pull/1198#issuecomment-1810337817 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] OAK-10542 : getLiveRevision must inspect split docs if local deleted … [jackrabbit-oak]

sonarcloud[bot] commented on PR #1198: URL: https://github.com/apache/jackrabbit-oak/pull/1198#issuecomment-1810238763 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] OAK-10542 : getLiveRevision must inspect split docs if local deleted … [jackrabbit-oak]

stefan-egli commented on PR #1198: URL: https://github.com/apache/jackrabbit-oak/pull/1198#issuecomment-1810226385 change of plan : refactored the code duplication. /cc @reschke -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] OAK-10542 : getLiveRevision must inspect split docs if local deleted … [jackrabbit-oak]

stefan-egli commented on PR #1198: URL: https://github.com/apache/jackrabbit-oak/pull/1198#issuecomment-1810157356 yes I was considering a refactoring actually. there's a few subtleties and non-straight-forwards, so I opted out for now. Will add a TODO -- This is an automated message

Re: [PR] OAK-10542 : getLiveRevision must inspect split docs if local deleted … [jackrabbit-oak]

reschke commented on PR #1198: URL: https://github.com/apache/jackrabbit-oak/pull/1198#issuecomment-1810153975 Oh, good point. Maybe open a TODO ticket to refactor this later into a single utility method? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] OAK-10542 : getLiveRevision must inspect split docs if local deleted … [jackrabbit-oak]

stefan-egli commented on PR #1198: URL: https://github.com/apache/jackrabbit-oak/pull/1198#issuecomment-1810151449 > it disables an optimization that avoids looking at split docs; so in the worst case, we'd see a performance degradation, right? right. * in most of the cases there

Re: [PR] OAK-10542 : getLiveRevision must inspect split docs if local deleted … [jackrabbit-oak]

sonarcloud[bot] commented on PR #1198: URL: https://github.com/apache/jackrabbit-oak/pull/1198#issuecomment-1802399454 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png