[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #863: OAK-10127 - Log warn message when MongoDB document is big

2023-05-05 Thread via GitHub
mreutegg commented on code in PR #863: URL: https://github.com/apache/jackrabbit-oak/pull/863#discussion_r1185993139 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java: ## @@ -1470,8 +1487,18 @@ public boolean

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #863: OAK-10127 - Log warn message when MongoDB document is big

2023-05-05 Thread via GitHub
mreutegg commented on code in PR #863: URL: https://github.com/apache/jackrabbit-oak/pull/863#discussion_r1185989489 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDBExceptionTest.java: ## @@ -31,11 +31,13 @@ import

[jira] [Assigned] (OCM-72) Remove dependency to cglib

2023-05-05 Thread Jira
[ https://issues.apache.org/jira/browse/OCM-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Dürig reassigned OCM-72: Assignee: Michael Dürig > Remove dependency to cglib > -- > >

[jira] [Created] (OCM-72) Remove dependency to cglib

2023-05-05 Thread Jira
Michael Dürig created OCM-72: Summary: Remove dependency to cglib Key: OCM-72 URL: https://issues.apache.org/jira/browse/OCM-72 Project: Jackrabbit OCM Issue Type: Improvement Affects

Re: Guava Migration (yes, a must read)

2023-05-05 Thread Julian Reschke
On 06.04.2023 13:56, Julian Reschke wrote: Hi everybody, as some have noticed, we have begun the migration away from Guava 15.0 to a *shaded* version of Guava (latest and greatest). A new subproject has been added (oak-shaded-guava), which repackages Guava 31 under the package name

[GitHub] [jackrabbit-oak] reschke merged pull request #927: OAK-10231: switch oak-exercise to shaded guava

2023-05-05 Thread via GitHub
reschke merged PR #927: URL: https://github.com/apache/jackrabbit-oak/pull/927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] steffenvan commented on a diff in pull request #914: OAK-10214: Expose node counter value as a metric in Oak

2023-05-05 Thread via GitHub
steffenvan commented on code in PR #914: URL: https://github.com/apache/jackrabbit-oak/pull/914#discussion_r1185814049 ## oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/counter/NodeCounterEditor.java: ## @@ -41,15 +44,20 @@ public class NodeCounterEditor

[jira] [Commented] (JCRVLT-683) Import of Authorizable node with acHandling=IGNORE should preserve existing rep:principalPolicy child node

2023-05-05 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719725#comment-17719725 ] Thomas Mueller commented on JCRVLT-683: --- > Well in this case I don't think it is necessary but if

[jira] [Comment Edited] (JCRVLT-683) Import of Authorizable node with acHandling=IGNORE should preserve existing rep:principalPolicy child node

2023-05-05 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719721#comment-17719721 ] Konrad Windszus edited comment on JCRVLT-683 at 5/5/23 7:59 AM: bq.

[jira] [Comment Edited] (JCRVLT-683) Import of Authorizable node with acHandling=IGNORE should preserve existing rep:principalPolicy child node

2023-05-05 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719721#comment-17719721 ] Konrad Windszus edited comment on JCRVLT-683 at 5/5/23 7:59 AM: bq.

[jira] [Commented] (JCRVLT-683) Import of Authorizable node with acHandling=IGNORE should preserve existing rep:principalPolicy child node

2023-05-05 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719721#comment-17719721 ] Konrad Windszus commented on JCRVLT-683: bq.

[jira] [Comment Edited] (JCRVLT-683) Import of Authorizable node with acHandling=IGNORE should preserve existing rep:principalPolicy child node

2023-05-05 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719719#comment-17719719 ] Thomas Mueller edited comment on JCRVLT-683 at 5/5/23 7:49 AM: --- > Every

[jira] [Commented] (JCRVLT-683) Import of Authorizable node with acHandling=IGNORE should preserve existing rep:principalPolicy child node

2023-05-05 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719719#comment-17719719 ] Thomas Mueller commented on JCRVLT-683: --- > Every code relying on that bug can be easily fixed by

[GitHub] [jackrabbit-oak] reschke merged pull request #926: OAK-10230: switch oak-authorization-principalbased to shaded guava

2023-05-05 Thread via GitHub
reschke merged PR #926: URL: https://github.com/apache/jackrabbit-oak/pull/926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] reschke commented on a diff in pull request #926: OAK-10230: switch oak-authorization-principalbased to shaded guava

2023-05-05 Thread via GitHub
reschke commented on code in PR #926: URL: https://github.com/apache/jackrabbit-oak/pull/926#discussion_r1185746647 ## oak-authorization-principalbased/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/principalbased/impl/AbstractEntry.java: ## @@ -16,7 +16,7

[GitHub] [jackrabbit-oak] anchela commented on a diff in pull request #926: OAK-10230: switch oak-authorization-principalbased to shaded guava

2023-05-05 Thread via GitHub
anchela commented on code in PR #926: URL: https://github.com/apache/jackrabbit-oak/pull/926#discussion_r1185745561 ## oak-authorization-principalbased/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/principalbased/impl/ImmutablePrincipalPolicy.java: ## @@

[jira] [Comment Edited] (JCRVLT-700) package creation fails for node names that are valid in Oak, but invalid in Jackrabbit

2023-05-05 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706381#comment-17706381 ] Julian Reschke edited comment on JCRVLT-700 at 5/5/23 6:26 AM: --- Added test