Re: [jclouds-labs-openstack] JCLOUDS-215 - Adds Webhook and Execution support to autoscale (#48)

2013-11-08 Thread Ignasi Barrera
+ assertEquals(webhook.getLinks().size(), 2); + } + + public void testGetWebhookFail() { + URI endpoint = URI.create(https://dfw.autoscale.api.rackspacecloud.com/v1.0/88/groups/1234567890/policies/321456/webhooks/;); + WebhookApi api = requestsSendResponses( +

Re: [jclouds-labs-openstack] JCLOUDS-215 - Adds Webhook and Execution support to autoscale (#48)

2013-11-08 Thread Ignasi Barrera
+ assertEquals(webhook.getLinks().size(), 2); + } + + public void testGetWebhookFail() { + URI endpoint = URI.create(https://dfw.autoscale.api.rackspacecloud.com/v1.0/88/groups/1234567890/policies/321456/webhooks/;); + WebhookApi api = requestsSendResponses( +

Re: [jclouds-site] Remove remaining incubator logos (#30)

2013-11-08 Thread Ignasi Barrera
Merged and published! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/30#issuecomment-28045200

Re: [jclouds-site] Move the feather to the bottom of the page (#31)

2013-11-08 Thread Ignasi Barrera
Merged and published! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/31#issuecomment-28045219

Re: [jclouds-labs] JCLOUDS-367: GCE nodes n1 ignoring inboundPort (#33)

2013-11-08 Thread Richard Downer
return input.get() != null; } }, operationCompleteCheckTimeout, operationCompleteCheckInterval, MILLISECONDS).apply(instance); } - InstanceInZone instanceInZone = new InstanceInZone(instance.get(), template.getLocation().getId()); +

Re: [jclouds-labs-google] fix JCLOUDS-362 inferring project-id from identity when there is a hyphen (#9)

2013-11-08 Thread ahgittin
thanks @demobox - can this also be merged into jclouds-labs 1.6.x branch ? (should i open a separate pull request for that?) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/9#issuecomment-28058878

Re: Fwd: projects graduated need to tidy up

2013-11-08 Thread Andrew Phillips
It seems that jclouds has stuff to clean up in the incubator. Does anyone know what needs be cleaned up (and how to do it)? I can help with that. I'm assuming the tasks are as described here: http://incubator.apache.org/guides/graduation.html#life-after-graduation I haven't looked in detail

Re: [jclouds-labs] JCLOUDS-367: GCE nodes n1 ignoring inboundPort (#33)

2013-11-08 Thread Richard Downer
+ */ +package org.jclouds.googlecomputeengine.compute.functions; + +import com.google.common.base.Predicate; +import org.jclouds.compute.functions.GroupNamingConvention; + +import javax.inject.Inject; + +/** + * The convention for naming instance tags that firewall rules recognise. + *

Re: Fwd: projects graduated need to tidy up

2013-11-08 Thread Ignasi
I checked the site, and jclouds is already added as a TLP, and the commitee-info.txt has already been filled with the appropriate information (thx, Andrew B.!). I'm not sure what can be remaining, as those two points are the ones sebb commented in another thread... On 8 November 2013 14:11,

Re: [jclouds-labs] JCLOUDS-367: GCE nodes n1 ignoring inboundPort (#33)

2013-11-08 Thread Richard Downer
- retry(operationDonePredicate, operationCompleteCheckTimeout, operationCompleteCheckInterval, - MILLISECONDS).apply(operation); - - checkState(!operation.get().getHttpError().isPresent(), Could not create firewall, operation failed + operation); +

Re: [jclouds-labs] JCLOUDS-367: GCE nodes n1 ignoring inboundPort (#33)

2013-11-08 Thread Richard Downer
Thanks @demobox, I think I've gone through all of your review comments, with the exception of the failure-cleanup question. Any more comments at this stage? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/33#issuecomment-28069473

Re: [jclouds-labs] JCLOUDS-367: GCE nodes n1 ignoring inboundPort (#33)

2013-11-08 Thread CloudBees pull request builder plugin
[jclouds-labs-pull-requests #84](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/84/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/33#issuecomment-28069826

Re: [jclouds-labs-openstack] JCLOUDS-215 - Adds Webhook and Execution support to autoscale (#48)

2013-11-08 Thread Zack Shoylev
+ assertEquals(webhook.getLinks().size(), 2); + } + + public void testGetWebhookFail() { + URI endpoint = URI.create(https://dfw.autoscale.api.rackspacecloud.com/v1.0/88/groups/1234567890/policies/321456/webhooks/;); + WebhookApi api = requestsSendResponses( +

Basic authentication did not work

2013-11-08 Thread Udara Liyanage
Hi, I am using JCloud to statup instances in vcloud setup. When I did it using curl it worked fine. echo -n udarasampath@udarasampath:admin321 | openssl enc -base64 curl -i -k -H Accept:application/*+xml;version=1.5 -X POST https://mycloud.stratogen.sg/api/sessions; -H Authorization: Basic

Re: [jclouds-labs] JCLOUDS-367: GCE nodes n1 ignoring inboundPort (#33)

2013-11-08 Thread Andrew Phillips
return input.get() != null; } }, operationCompleteCheckTimeout, operationCompleteCheckInterval, MILLISECONDS).apply(instance); } - InstanceInZone instanceInZone = new InstanceInZone(instance.get(), template.getLocation().getId()); +

Re: [jclouds-labs] JCLOUDS-367: GCE nodes n1 ignoring inboundPort (#33)

2013-11-08 Thread Andrew Phillips
- retry(operationDonePredicate, operationCompleteCheckTimeout, operationCompleteCheckInterval, - MILLISECONDS).apply(operation); - - checkState(!operation.get().getHttpError().isPresent(), Could not create firewall, operation failed + operation); +

Re: [jclouds-labs] JCLOUDS-367: GCE nodes n1 ignoring inboundPort (#33)

2013-11-08 Thread Andrew Phillips
@@ -266,6 +266,12 @@ public static IPProtocol fromValue(String protocol) { private final IPProtocol ipProtocol; private final RangeSetInteger ports; + /* Some handy shortcuts */ + public static Rule permitTcpRule(Integer start, Integer end) { return

Re: Git/JIRA integration broken?

2013-11-08 Thread David Nalley
Wilderness - (file a ticket in infra with Wilderness as the component) --David On Fri, Nov 8, 2013 at 1:54 PM, Andrew Bayer andrew.ba...@gmail.com wrote: Where is this configured? A. On Thu, Nov 7, 2013 at 12:10 AM, Ignasi ignasi.barr...@gmail.com wrote: I think the members of the PMC

Re: [jclouds-labs-google] fix JCLOUDS-362 inferring project-id from identity when there is a hyphen (#9)

2013-11-08 Thread Andrew Phillips
@@ -101,10 +101,20 @@ protected void bindErrorHandlers() { return MemoizedRetryOnTimeOutButNotOnAuthorizationExceptionSupplier.create(authException, compose(new FunctionCredentials, String() { public String apply(Credentials in) { -

Re: [jclouds-labs-google] Enforcing identity format '...@developer.gserviceaccount.com' correctly (#12)

2013-11-08 Thread Andrew Phillips
Dropping following comments by @abayer and in the [related PR](https://github.com/jclouds/jclouds-labs-google/pull/9#discussion_r7443403). The parsing will not break or do weird things if the `@project.gserviceaccount.com` suffix is missing, so the check is not really needed. --- Reply to

Re: Git/JIRA integration broken?

2013-11-08 Thread Andrew Bayer
Where is this configured? A. On Thu, Nov 7, 2013 at 12:10 AM, Ignasi ignasi.barr...@gmail.com wrote: I think the members of the PMC group don't have permissions to do that; only the Administrators (but I'm not sure). I've had a look, and the notification address should also be changed, as

Re: Git/JIRA integration broken?

2013-11-08 Thread Andrew Phillips
Where is this configured? I'm guessing, in Git? I hope it's a push whenever Git receives a commit, rather than polling happening from JIRA..? ap

Re: [jclouds-labs-openstack] JCLOUDS-215 - Adds Webhook and Execution support to autoscale (#48)

2013-11-08 Thread Zack Shoylev
+ HttpURLConnection connection = (HttpURLConnection) url.openConnection(); + connection.setDoOutput(true); + connection.setDoInput(true); + connection.setInstanceFollowRedirects(false); + connection.setRequestMethod(POST); +

Re: [jclouds] JCLOUDS-365: ChefSolo should not depend on InstallChefGems (#196)

2013-11-08 Thread Andrew Phillips
Should we have some kind of prerequisite check here, or will things fail with an obvious error message if we try to run Solo _without_ Chef now? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/196#issuecomment-28088996

Re: [jclouds-labs-openstack] JCLOUDS-215 - Adds Webhook and Execution support to autoscale (#48)

2013-11-08 Thread Zack Shoylev
Updated with fixes --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/48#issuecomment-28089430

Re: Git/JIRA integration broken?

2013-11-08 Thread David Nalley
On Fri, Nov 8, 2013 at 2:03 PM, Andrew Phillips aphill...@qrmedia.com wrote: Where is this configured? I'm guessing, in Git? I hope it's a push whenever Git receives a commit, rather than polling happening from JIRA..? ap It's gitpubsub: http://www.apache.org/dev/gitpubsub.html See also:

Re: [jclouds-labs-openstack] JCLOUDS-215 - Adds Webhook and Execution support to autoscale (#48)

2013-11-08 Thread CloudBees pull request builder plugin
[jclouds-labs-openstack-pull-requests #90](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/90/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/48#issuecomment-28089587

Re: [jclouds] Implement a poor-mans rollback if static nat creation fails (#184)

2013-11-08 Thread Andrew Phillips
Thanks for the prod, @spark404. I'd still like to see some input from somebody else before making any decisions here. It might be worth hopping on #jclouds at Freenode to see if someone can have a look - good time, too, since the next couple of releases are coming up. --- Reply to this email

Re: [jclouds] JCLOUDS-365: ChefSolo should not depend on InstallChefGems (#196)

2013-11-08 Thread Ignasi Barrera
This is something that will fail when running the bootstrap script with a `Command not found: chef-solo`. The prerequisite is to have Chef installed (via the gem or the Omnibus installer), but I think that should not be a precondition of the script, as the image being deployed could already

Re: [jclouds] JCLOUDS-365: ChefSolo should not depend on InstallChefGems (#196)

2013-11-08 Thread Noorul Islam K M
I see a positive use case here https://gist.github.com/nacx/7317938 I think the purpose of the patch is to make ChefSolo statement independent of Chef installation. If ChefSolo statement is already being consumed by someone and assumes that it takes care of installing Chef then that will be

Re: [jclouds] JCLOUDS-365: ChefSolo should not depend on InstallChefGems (#196)

2013-11-08 Thread Ignasi Barrera
If ChefSolo statement is already being consumed by someone and assumes that it takes care of installing Chef then that will be broken now. Apart from that I don't see a problem. The workaround is trivial, just adding declare the InstallChefGems to the script, so I think we can just ignore

Re: [jclouds-labs-openstack] JCLOUDS-215 - Adds Webhook and Execution support to autoscale (#48)

2013-11-08 Thread Ignasi Barrera
+ * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an AS IS BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the

Re: [jclouds-labs-openstack] JCLOUDS-215 - Adds Webhook and Execution support to autoscale (#48)

2013-11-08 Thread Ignasi Barrera
+ HttpURLConnection connection = (HttpURLConnection) url.openConnection(); + connection.setDoOutput(true); + connection.setDoInput(true); + connection.setInstanceFollowRedirects(false); + connection.setRequestMethod(POST); +

Re: [jclouds-labs-openstack] JCLOUDS-215 - Adds Webhook and Execution support to autoscale (#48)

2013-11-08 Thread Ignasi Barrera
+ assertEquals(webhook.getLinks().size(), 2); + } + + public void testGetWebhookFail() { + URI endpoint = URI.create(https://dfw.autoscale.api.rackspacecloud.com/v1.0/88/groups/1234567890/policies/321456/webhooks/;); + WebhookApi api = requestsSendResponses( +

Re: [jclouds-labs-openstack] JCLOUDS-215 - Adds Webhook and Execution support to autoscale (#48)

2013-11-08 Thread Ignasi Barrera
Changes look good to me. Thanks @zack-shoylev! Just a tip (although it is a matter of preference): when addressing review comments, push the changes in a separate commit. Don't squash until it is ok to merge (or requested). This helps focusing only on the last changes, without having to go

Re: [jclouds-labs-openstack] JCLOUDS-215 - Adds Webhook and Execution support to autoscale (#48)

2013-11-08 Thread Zack Shoylev
Very good point, thanks. I was under the impression we want to keep it to one commit at all times... Much better keeping all the commits until merge. Thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/48#issuecomment-28096075

Re: [jclouds-labs-openstack] JCLOUDS-215 - Adds Webhook and Execution support to autoscale (#48)

2013-11-08 Thread Zack Shoylev
I will be merging this in a bit then. Thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/48#issuecomment-28096653

RE: unauthenticated calls suggestions

2013-11-08 Thread Zack Shoylev
Well there is this particular execute call that can be done in 2 ways: 1) Regular service call, authenticated, you specify exactly what you are calling (through ids) 2) Anonymous call. Basically call a hashed URL without authentication or even context, and you can't tell what you are calling.

Re: [jclouds] JCLOUDS-365: ChefSolo should not depend on InstallChefGems (#196)

2013-11-08 Thread Andrew Phillips
This is something that will fail when running the bootstrap script with a `Command not found: chef-solo.` OK. I think that should be fine, but would it be easy to amend that to add something like Unable to find chef-solo -please install Chef? --- Reply to this email directly or view it on

Re: Basic authentication did not work

2013-11-08 Thread Nirmal Fernando
On Fri, Nov 8, 2013 at 11:53 PM, Andrew Phillips aphill...@qrmedia.comwrote: However when using jclouds , with the base64 encode token of the basic authentication produce an Access Forbidden error. Are you passing the base64 encoded version of the password to jclouds as the credential? That

What're the differences between vcloud and vcloud-director in labs?

2013-11-08 Thread Nirmal Fernando
Hi Devs, $Subject? When do you think someone should use one over the other? It's kind of confusing as of now. -- Thanks regards, Nirmal Senior Software Engineer- Platform Technologies Team, WSO2 Inc. Mobile: +94715779733 Blog: http://nirmalfdo.blogspot.com/

Vcloud-director test endpoint working?

2013-11-08 Thread Nirmal Fernando
Is this endpoint suppose to work? https://github.com/jclouds/jclouds-labs/blob/master/vcloud-director/pom.xml -- Thanks regards, Nirmal Senior Software Engineer- Platform Technologies Team, WSO2 Inc. Mobile: +94715779733 Blog: http://nirmalfdo.blogspot.com/